From: keith.busch@intel.com (Keith Busch)
Subject: [PATCHv2] NVMe: Fix partition detection issue(hot remove followed by hot add)
Date: Tue, 9 Dec 2014 16:18:31 +0000 (UTC) [thread overview]
Message-ID: <alpine.LNX.2.00.1412091615120.3973@localhost.lm.intel.com> (raw)
In-Reply-To: <027101d013be$b7731170$26593450$@samsung.com>
On Tue, 9 Dec 2014, Indraneel Mukherjee wrote:
> diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
> --- a/drivers/block/nvme-core.c
> +++ b/drivers/block/nvme-core.c
> @@ -2735,7 +2735,6 @@ static void nvme_free_dev(struct kref *kref)
>
> pci_dev_put(dev->pci_dev);
> nvme_free_namespaces(dev);
> - nvme_release_instance(dev);
> free_percpu(dev->io_queue);
> kfree(dev->queues);
> kfree(dev->entry);
> @@ -2996,6 +2995,7 @@ static void nvme_remove(struct pci_dev *pdev)
> nvme_dev_shutdown(dev);
> nvme_free_queues(dev, 0);
> nvme_dev_remove(dev);
> + nvme_release_instance(dev);
> nvme_release_prp_pools(dev);
> kref_put(&dev->kref, nvme_free_dev);
> }
>
> This ensures that the new node gets a different name (in case there is a
> stale node).
>
> If the fix is okay, I can send this separately as a patch.
Yes, please send as a patch and I'd Ack it. You might want to make one
against Jens' linux-block tree as well.
prev parent reply other threads:[~2014-12-09 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 10:24 [PATCHv2] NVMe: Fix partition detection issue(hot remove followed by hot add) Indraneel Mukherjee
2014-09-23 13:45 ` Keith Busch
2014-12-09 14:44 ` Indraneel Mukherjee
2014-12-09 16:18 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1412091615120.3973@localhost.lm.intel.com \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox