Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCHv2] NVMe: Fix partition detection issue(hot remove followed by hot add)
Date: Tue, 23 Sep 2014 07:45:46 -0600 (MDT)	[thread overview]
Message-ID: <alpine.LRH.2.03.1409230733000.4696@AMR> (raw)
In-Reply-To: <1411467843-3003-1-git-send-email-indraneel.m@samsung.com>

On Tue, 23 Sep 2014, Indraneel Mukherjee wrote:
> Finally managing to re-send this patch to address the review comments
> after Firewall issues were resolved at our end. Though not sure how
> valid this patch is now after Keith's attempts to fix this in the block
> layer. Keith, any thoughts on what will be the final form of this fix?

Hi Indraneel,

Is there anything we need to do in the driver anymore? We should get
the desired behavior with the dev_t minor allocation fix:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/block/genhd.c?id=2da78092dda13f1efd26edbbf99a567776913750

If anything, maybe the nvme_dev's instance could be released in
nvme_free_dev(), but even that seems unnecessary. The test seems to work
on my machine, but please let me know if something else is amiss.

Thanks,
Keith

  reply	other threads:[~2014-09-23 13:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 10:24 [PATCHv2] NVMe: Fix partition detection issue(hot remove followed by hot add) Indraneel Mukherjee
2014-09-23 13:45 ` Keith Busch [this message]
2014-12-09 14:44   ` Indraneel Mukherjee
2014-12-09 16:18     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.2.03.1409230733000.4696@AMR \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox