Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <kbusch@meta.com>,
	linux-nvme@lists.infradead.org, hch@lst.de, axboe@kernel.dk
Subject: Re: [PATCH RFC] nvme-tcp: allow multiple queues per hctx
Date: Tue, 8 Sep 2026 11:10:27 -0600	[thread overview]
Message-ID: <aqBBgzV1Q9pP7Z44@kbusch-mbp> (raw)
In-Reply-To: <aqAZ6S6lBILltRwq@kbusch-mbp>

On Tue, Sep 08, 2026 at 08:21:29AM -0600, Keith Busch wrote:
> On Sun, Sep 06, 2026 at 03:04:42AM +0300, Sagi Grimberg wrote:
> > I'm wandering if you guys can do the same --duplicate-connect and setting
> > mpath with round-robin/queue-depth would get you the same result? Perhaps
> > we can add this flag to nvme discover/connect-all for simplicity?
> 
> Thanks, I'll give that suggestion a try. I think I also need to tie the
> "duplicate_connect" option to the module's wq_unbound option too.

Initial results show there's some promise to this suggestion, however, I
think in addition to the wq_unbound, it looks like I also need to adjust
the "io_cpu" to change to the submitter's CPU. I incorporated that in
this RFC, but there's also a proposal specifically for that here:

  https://lore.kernel.org/linux-nvme/20260820083634.71689-1-saravanand@crusoe.ai/

I need to catch up on the discussion there, but from what I can tell,
the cpu hint provided to the queue work appears to be important.


  reply	other threads:[~2026-09-08 17:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 15:26 [PATCH RFC] nvme-tcp: allow multiple queues per hctx Keith Busch
2026-09-06  0:04 ` Sagi Grimberg
2026-09-08 14:21   ` Keith Busch
2026-09-08 17:10     ` Keith Busch [this message]
2026-09-09  5:21       ` Saravanan D
2026-09-11 21:44       ` Sagi Grimberg
2026-09-21 12:21 ` Hannes Reinecke
2026-09-21 17:29   ` Keith Busch
2026-10-06 11:03     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqBBgzV1Q9pP7Z44@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@meta.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox