Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Saravanan D <saravanand@crusoe.ai>
Cc: linux-block@vger.kernel.org, nilay@linux.ibm.com,
	 linux-nvme@lists.infradead.org, dwagner@suse.de, hare@suse.de,
	sagi@grimberg.me,  kbusch@kernel.org, iyamahata@crusoe.ai,
	kiyer@crusoe.ai, ganbalagane@crusoe.ai,  sjpark@crusoe.ai,
	bchen@crusoe.ai
Subject: Re: [PATCH blktests v2] nvme/081: test the per-queue io_cpu sysfs attribute
Date: Sat, 14 Nov 2026 18:10:24 +0900	[thread overview]
Message-ID: <avglC5DZBx6_P0M5@shinmob> (raw)
In-Reply-To: <20261110115005.47367-1-saravanand@crusoe.ai>

On Nov 10, 2026 / 11:50, Saravanan D wrote:
> nvme-tcp exposes /sys/class/nvme/nvmeX/queues/<qid>/io_cpu and managed,
> so a control plane can choose the CPU that runs each I/O queue's socket
> work [1]. Test that
> 
>   - io_cpu reads back a written CPU and rejects invalid values
>   - managed is read only and turns 0 once io_cpu is written
>   - an assignment and the queue directories survive a controller reset
>   - the queue directories follow the queue count as attr_qid_max
>     shrinks and grows it
>   - removing the controller while io_cpu is written completes
> 
> The test skips when the kernel does not have the queues/ directory or
> the io_cpu attribute.
> 
> [1] https://lore.kernel.org/linux-nvme/cover.1794015622.git.saravanand@crusoe.ai/
> 
> Assisted-by: Claude:claude-opus-5-5 [Claude Code]
> Signed-off-by: Saravanan D <saravanand@crusoe.ai>

Thanks for the patch. It looks good to me. I would like to wait for the
corresponding kernel side patches get applied. Please ping me when the
kernel patches land on the Linus master branch,


      parent reply	other threads:[~2026-11-14  9:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07  9:53 [PATCH v8 0/2] nvme-tcp: allow setting per-queue io_cpu through sysfs Saravanan D
2026-11-07  9:53 ` [PATCH v8 1/2] nvme: add per-queue sysfs directories Saravanan D
2026-11-09 11:27   ` Nilay Shroff
2026-11-10 13:06   ` Hannes Reinecke
2026-11-07  9:53 ` [PATCH v8 2/2] nvme-tcp: allow setting per-queue io_cpu through sysfs Saravanan D
2026-11-09 11:40   ` Nilay Shroff
2026-11-10 13:09   ` Hannes Reinecke
2026-11-07  9:53 ` [PATCH blktests] nvme/081: test the per-queue io_cpu sysfs attribute Saravanan D
2026-11-09 13:43   ` Nilay Shroff
2026-11-10 11:49     ` Saravanan D
2026-11-10 11:50     ` [PATCH blktests v2] " Saravanan D
2026-11-11  8:47       ` Nilay Shroff
2026-11-14  9:10       ` Shin'ichiro Kawasaki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avglC5DZBx6_P0M5@shinmob \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=bchen@crusoe.ai \
    --cc=dwagner@suse.de \
    --cc=ganbalagane@crusoe.ai \
    --cc=hare@suse.de \
    --cc=iyamahata@crusoe.ai \
    --cc=kbusch@kernel.org \
    --cc=kiyer@crusoe.ai \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nilay@linux.ibm.com \
    --cc=sagi@grimberg.me \
    --cc=saravanand@crusoe.ai \
    --cc=sjpark@crusoe.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox