From: Hannes Reinecke <hare@suse.de>
To: Guixin Liu <kanie@linux.alibaba.com>,
hch@lst.de, sagi@grimberg.me, kch@nvidia.com
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvmetcli: fix double ana groupid when save config
Date: Fri, 29 Nov 2024 12:07:38 +0100 [thread overview]
Message-ID: <b398c12c-318f-430b-94ee-ea9866c0eea9@suse.de> (raw)
In-Reply-To: <20241029034312.15083-1-kanie@linux.alibaba.com>
On 10/29/24 04:43, Guixin Liu wrote:
> There are two ana grpid in json file after save the config,
> including ana group: "ana":{"grpid"}, and "ana_grpid", remove one,
> still one can use both of them to set ana_grpid.
>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
> nvmet/nvme.py | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/nvmet/nvme.py b/nvmet/nvme.py
> index 59efdb5..41b4845 100644
> --- a/nvmet/nvme.py
> +++ b/nvmet/nvme.py
> @@ -626,7 +626,6 @@ class Namespace(CFSNode):
> def dump(self):
> d = super(Namespace, self).dump()
> d['nsid'] = self.nsid
> - d['ana_grpid'] = self.grpid
> return d
>
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2024-11-29 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 3:43 [PATCH] nvmetcli: fix double ana groupid when save config Guixin Liu
2024-10-31 2:37 ` Guixin Liu
2024-11-26 8:43 ` Guixin Liu
2024-11-29 11:07 ` Hannes Reinecke [this message]
2024-12-24 11:53 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b398c12c-318f-430b-94ee-ea9866c0eea9@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox