Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Guixin Liu <kanie@linux.alibaba.com>
To: hch@lst.de, sagi@grimberg.me, kch@nvidia.com
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvmetcli: fix double ana groupid when save config
Date: Tue, 26 Nov 2024 16:43:55 +0800	[thread overview]
Message-ID: <926a7a12-fbdf-471a-906e-5ef41fddccad@linux.alibaba.com> (raw)
In-Reply-To: <7539e263-76ed-4c54-91ee-f6ff1a5304a3@linux.alibaba.com>

Hi Christoph,

   Could you please take a look on this patch? And also "[PATCH] 
nvmetcli: reservation

configuration support" which send in 2024/10/29, thanks.

Best Regards,

Guixin Liu

在 2024/10/31 10:37, Guixin Liu 写道:
> gentle ping...
>
> Best Regards,
>
> Guixin Liu
>
> 在 2024/10/29 11:43, Guixin Liu 写道:
>> There are two ana grpid in json file after save the config,
>> including ana group: "ana":{"grpid"}, and "ana_grpid", remove one,
>> still one can use both of them to set ana_grpid.
>>
>> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
>> ---
>>   nvmet/nvme.py | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/nvmet/nvme.py b/nvmet/nvme.py
>> index 59efdb5..41b4845 100644
>> --- a/nvmet/nvme.py
>> +++ b/nvmet/nvme.py
>> @@ -626,7 +626,6 @@ class Namespace(CFSNode):
>>       def dump(self):
>>           d = super(Namespace, self).dump()
>>           d['nsid'] = self.nsid
>> -        d['ana_grpid'] = self.grpid
>>           return d


  reply	other threads:[~2024-11-26  8:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29  3:43 [PATCH] nvmetcli: fix double ana groupid when save config Guixin Liu
2024-10-31  2:37 ` Guixin Liu
2024-11-26  8:43   ` Guixin Liu [this message]
2024-11-29 11:07 ` Hannes Reinecke
2024-12-24 11:53 ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=926a7a12-fbdf-471a-906e-5ef41fddccad@linux.alibaba.com \
    --to=kanie@linux.alibaba.com \
    --cc=hch@lst.de \
    --cc=kch@nvidia.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox