* [PATCH] nvmetcli: fix double ana groupid when save config
@ 2024-10-29 3:43 Guixin Liu
2024-10-31 2:37 ` Guixin Liu
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Guixin Liu @ 2024-10-29 3:43 UTC (permalink / raw)
To: hch, sagi, kch; +Cc: linux-nvme
There are two ana grpid in json file after save the config,
including ana group: "ana":{"grpid"}, and "ana_grpid", remove one,
still one can use both of them to set ana_grpid.
Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
---
nvmet/nvme.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/nvmet/nvme.py b/nvmet/nvme.py
index 59efdb5..41b4845 100644
--- a/nvmet/nvme.py
+++ b/nvmet/nvme.py
@@ -626,7 +626,6 @@ class Namespace(CFSNode):
def dump(self):
d = super(Namespace, self).dump()
d['nsid'] = self.nsid
- d['ana_grpid'] = self.grpid
return d
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] nvmetcli: fix double ana groupid when save config
2024-10-29 3:43 [PATCH] nvmetcli: fix double ana groupid when save config Guixin Liu
@ 2024-10-31 2:37 ` Guixin Liu
2024-11-26 8:43 ` Guixin Liu
2024-11-29 11:07 ` Hannes Reinecke
2024-12-24 11:53 ` Sagi Grimberg
2 siblings, 1 reply; 5+ messages in thread
From: Guixin Liu @ 2024-10-31 2:37 UTC (permalink / raw)
To: hch, sagi, kch; +Cc: linux-nvme
gentle ping...
Best Regards,
Guixin Liu
在 2024/10/29 11:43, Guixin Liu 写道:
> There are two ana grpid in json file after save the config,
> including ana group: "ana":{"grpid"}, and "ana_grpid", remove one,
> still one can use both of them to set ana_grpid.
>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
> nvmet/nvme.py | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/nvmet/nvme.py b/nvmet/nvme.py
> index 59efdb5..41b4845 100644
> --- a/nvmet/nvme.py
> +++ b/nvmet/nvme.py
> @@ -626,7 +626,6 @@ class Namespace(CFSNode):
> def dump(self):
> d = super(Namespace, self).dump()
> d['nsid'] = self.nsid
> - d['ana_grpid'] = self.grpid
> return d
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] nvmetcli: fix double ana groupid when save config
2024-10-31 2:37 ` Guixin Liu
@ 2024-11-26 8:43 ` Guixin Liu
0 siblings, 0 replies; 5+ messages in thread
From: Guixin Liu @ 2024-11-26 8:43 UTC (permalink / raw)
To: hch, sagi, kch; +Cc: linux-nvme
Hi Christoph,
Could you please take a look on this patch? And also "[PATCH]
nvmetcli: reservation
configuration support" which send in 2024/10/29, thanks.
Best Regards,
Guixin Liu
在 2024/10/31 10:37, Guixin Liu 写道:
> gentle ping...
>
> Best Regards,
>
> Guixin Liu
>
> 在 2024/10/29 11:43, Guixin Liu 写道:
>> There are two ana grpid in json file after save the config,
>> including ana group: "ana":{"grpid"}, and "ana_grpid", remove one,
>> still one can use both of them to set ana_grpid.
>>
>> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
>> ---
>> nvmet/nvme.py | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/nvmet/nvme.py b/nvmet/nvme.py
>> index 59efdb5..41b4845 100644
>> --- a/nvmet/nvme.py
>> +++ b/nvmet/nvme.py
>> @@ -626,7 +626,6 @@ class Namespace(CFSNode):
>> def dump(self):
>> d = super(Namespace, self).dump()
>> d['nsid'] = self.nsid
>> - d['ana_grpid'] = self.grpid
>> return d
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvmetcli: fix double ana groupid when save config
2024-10-29 3:43 [PATCH] nvmetcli: fix double ana groupid when save config Guixin Liu
2024-10-31 2:37 ` Guixin Liu
@ 2024-11-29 11:07 ` Hannes Reinecke
2024-12-24 11:53 ` Sagi Grimberg
2 siblings, 0 replies; 5+ messages in thread
From: Hannes Reinecke @ 2024-11-29 11:07 UTC (permalink / raw)
To: Guixin Liu, hch, sagi, kch; +Cc: linux-nvme
On 10/29/24 04:43, Guixin Liu wrote:
> There are two ana grpid in json file after save the config,
> including ana group: "ana":{"grpid"}, and "ana_grpid", remove one,
> still one can use both of them to set ana_grpid.
>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
> nvmet/nvme.py | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/nvmet/nvme.py b/nvmet/nvme.py
> index 59efdb5..41b4845 100644
> --- a/nvmet/nvme.py
> +++ b/nvmet/nvme.py
> @@ -626,7 +626,6 @@ class Namespace(CFSNode):
> def dump(self):
> d = super(Namespace, self).dump()
> d['nsid'] = self.nsid
> - d['ana_grpid'] = self.grpid
> return d
>
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] nvmetcli: fix double ana groupid when save config
2024-10-29 3:43 [PATCH] nvmetcli: fix double ana groupid when save config Guixin Liu
2024-10-31 2:37 ` Guixin Liu
2024-11-29 11:07 ` Hannes Reinecke
@ 2024-12-24 11:53 ` Sagi Grimberg
2 siblings, 0 replies; 5+ messages in thread
From: Sagi Grimberg @ 2024-12-24 11:53 UTC (permalink / raw)
To: Guixin Liu, hch, kch; +Cc: linux-nvme
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-24 11:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-29 3:43 [PATCH] nvmetcli: fix double ana groupid when save config Guixin Liu
2024-10-31 2:37 ` Guixin Liu
2024-11-26 8:43 ` Guixin Liu
2024-11-29 11:07 ` Hannes Reinecke
2024-12-24 11:53 ` Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox