Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: maxg@mellanox.com (Max Gurtovoy)
Subject: [PATCH 1/1] nvme: Modify the debug level for setting shutdown timeout
Date: Thu, 4 Jan 2018 19:04:19 +0200	[thread overview]
Message-ID: <b46266c8-e239-ac12-d66e-33d613de597b@mellanox.com> (raw)
In-Reply-To: <20180104100440.GC4436@lst.de>



On 1/4/2018 12:04 PM, Christoph Hellwig wrote:
> On Sun, Dec 31, 2017@03:33:27PM +0200, Max Gurtovoy wrote:
>> When an NVMe controller reports RTD3 Entry Latency larger than
>> the value of shutdown_timeout module parameter, we update the
>> shutdown_timeout accordingly to honor RTD3 Entry Latency. Use an
>> Informational debug level instead of a Warning level for it.
>>
>> Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
> 
> I'm ok with just info, but in the end it seems like a pretty
> buggy device..
> 

but shutdown_timeout is a module param that one can set to be 10 secs 
(for example) and then it might be == transition_time and we won't see 
the print. Then is it not a buggy device anymore ? :)

  reply	other threads:[~2018-01-04 17:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-31 13:33 [PATCH 1/1] nvme: Modify the debug level for setting shutdown timeout Max Gurtovoy
2018-01-04 10:04 ` Christoph Hellwig
2018-01-04 17:04   ` Max Gurtovoy [this message]
2018-01-04 17:24     ` Martin K. Petersen
2018-01-04 17:48       ` Max Gurtovoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b46266c8-e239-ac12-d66e-33d613de597b@mellanox.com \
    --to=maxg@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox