From: maxg@mellanox.com (Max Gurtovoy)
Subject: [PATCH 1/1] nvme: Modify the debug level for setting shutdown timeout
Date: Thu, 4 Jan 2018 19:48:04 +0200 [thread overview]
Message-ID: <fd7305d1-e76c-bcce-ccfb-07f4be27f3ab@mellanox.com> (raw)
In-Reply-To: <yq11sj5v8o5.fsf@oracle.com>
Hi Martin,
On 1/4/2018 7:24 PM, Martin K. Petersen wrote:
>
> Max,
>
>> but shutdown_timeout is a module param that one can set to be 10 secs
>> (for example) and then it might be == transition_time and we won't see
>> the print. Then is it not a buggy device anymore ? :)
>
> The intent was to only print when the resulting shutdown_timeout
> deviated from the default value (whether the driver default or the
> admin-provided module parameter).
>
> My only concern with info over warning is that info is often dropped.
> And therefore you have a harder time finding out which value was in
> effect when you subsequently peak at the logs.
>
Ok, it just bothered me to see this print every time I probed the device.
But I can live with that. You can ignore this patch.
-Max.
prev parent reply other threads:[~2018-01-04 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-31 13:33 [PATCH 1/1] nvme: Modify the debug level for setting shutdown timeout Max Gurtovoy
2018-01-04 10:04 ` Christoph Hellwig
2018-01-04 17:04 ` Max Gurtovoy
2018-01-04 17:24 ` Martin K. Petersen
2018-01-04 17:48 ` Max Gurtovoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd7305d1-e76c-bcce-ccfb-07f4be27f3ab@mellanox.com \
--to=maxg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox