From: Sagi Grimberg <sagi@grimberg.me>
To: Hannes Reinecke <hare@suse.de>,
mwilck@suse.com, Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>
Cc: marting@netapp.com, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] nvme: multipath: round-robin: fix logic for non-optimized paths
Date: Tue, 21 Jul 2020 10:19:57 -0700 [thread overview]
Message-ID: <c51e7fa1-2e89-e5e1-6962-bc16470afd59@grimberg.me> (raw)
In-Reply-To: <b2e59b6e-e71a-a9d8-c768-a4a052449cf6@suse.de>
>>> Handle the special case where we have exactly one optimized path,
>>> which we should keep using in this case. Also, use the next
>>> non-optimized path, not the last one.
>>
>> Not sure I understand, does this patch also use nonopt paths if we
>> have a single opt path?
>
> Indeed, the latter change should be removed from this patch.
Why should we even do this? we have a clear indication from the
controller on ns access. If we have a optimized path we should never
select any non-optimized path.
What if a non-optimized path has a 50x higher access latency? it's just
wrong to use this path...
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-07-21 17:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 19:59 [PATCH 1/2] nvme: multipath: round-robin: fix logic for non-optimized paths mwilck
2020-07-16 19:59 ` [PATCH 2/2] nvme: multipath: round-robin: don't fall back to numa mwilck
2020-07-17 6:10 ` Hannes Reinecke
2020-07-17 6:08 ` [PATCH 1/2] nvme: multipath: round-robin: fix logic for non-optimized paths Hannes Reinecke
2020-07-20 19:51 ` Sagi Grimberg
2020-07-21 6:39 ` Hannes Reinecke
2020-07-21 17:19 ` Sagi Grimberg [this message]
2020-07-22 5:35 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c51e7fa1-2e89-e5e1-6962-bc16470afd59@grimberg.me \
--to=sagi@grimberg.me \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-nvme@lists.infradead.org \
--cc=marting@netapp.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox