Re: [PATCH v3] nvme: enable FDP support

[Jens Axboe <axboe@kernel.dk>]

On 7/2/24 9:36 AM, Christoph Hellwig wrote:
> On Tue, Jul 02, 2024 at 09:15:06AM -0600, Keith Busch wrote:
>> My first concern for applying something like this is what kind of
>> maintenance burdens does this create, or any potential harm to users who
>> don't subscribe to the feature? Nothing here looks alarming to me, and
>> there is a clear demand to be able to access these features like this.
>> Maybe it works out for some workloads, maybe it doesn't, but I don't see
>> a need to block this at this point.
> 
> We're just abusing the interface, and giving how badly designed and
> intentionally Linux-hostile it was I see no point.
> 
> If Samsung and Meta care enough about good Linux I/O temperature hint
> support we'll get what we want in the technical working group, please
> help working on that!

I'm with Keith on this one - there's no real maintenance burden to bear
for this feature, it's pretty well contained. There's no point gate
keeping it based on changing the spec, as that will take a long time to
get done. And there's no reason to hold this back until this happens
based on mostly ideological reasons, when there are actual users that
could use it now. What do we have to lose?

-- 
Jens Axboe