Re: [PATCH 2/6] IB/isert: remove the handling of last WQE reached event

[Max Gurtovoy <mgurtovoy@nvidia.com>]

On 19/06/2024 12:16, Sagi Grimberg wrote:
>
>
> On 18/06/2024 3:10, Max Gurtovoy wrote:
>> This event is handled by the RDMA core layer.
>>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> ---
>>   drivers/infiniband/ulp/isert/ib_isert.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c 
>> b/drivers/infiniband/ulp/isert/ib_isert.c
>> index 00a7303c8cc6..42977a5326ee 100644
>> --- a/drivers/infiniband/ulp/isert/ib_isert.c
>> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
>> @@ -91,9 +91,6 @@ isert_qp_event_callback(struct ib_event *e, void 
>> *context)
>>       case IB_EVENT_COMM_EST:
>>           rdma_notify(isert_conn->cm_id, IB_EVENT_COMM_EST);
>>           break;
>> -    case IB_EVENT_QP_LAST_WQE_REACHED:
>> -        isert_warn("Reached TX IB_EVENT_QP_LAST_WQE_REACHED\n");
>> -        break;
>
> Don't think you need to touch the ulps, they want to log these events, 
> so be it.
> Although, a warn is not appropriate at all here.

Ok. I'll remove the ULP patches, besides iSER target that is not even 
implement SRQ.

This is a dead code.