From: Sagi Grimberg <sagi@grimberg.me>
To: Max Gurtovoy <mgurtovoy@nvidia.com>,
leonro@nvidia.com, jgg@nvidia.com,
linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,
chuck.lever@oracle.com
Cc: oren@nvidia.com, israelr@nvidia.com, maorg@nvidia.com,
yishaih@nvidia.com, hch@lst.de, bvanassche@acm.org,
shiraz.saleem@intel.com, edumazet@google.com
Subject: Re: [PATCH 2/6] IB/isert: remove the handling of last WQE reached event
Date: Wed, 19 Jun 2024 12:16:37 +0300 [thread overview]
Message-ID: <f12e1a75-2fd1-46ef-aee9-520cced08f11@grimberg.me> (raw)
In-Reply-To: <20240618001034.22681-3-mgurtovoy@nvidia.com>
On 18/06/2024 3:10, Max Gurtovoy wrote:
> This event is handled by the RDMA core layer.
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
> drivers/infiniband/ulp/isert/ib_isert.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
> index 00a7303c8cc6..42977a5326ee 100644
> --- a/drivers/infiniband/ulp/isert/ib_isert.c
> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
> @@ -91,9 +91,6 @@ isert_qp_event_callback(struct ib_event *e, void *context)
> case IB_EVENT_COMM_EST:
> rdma_notify(isert_conn->cm_id, IB_EVENT_COMM_EST);
> break;
> - case IB_EVENT_QP_LAST_WQE_REACHED:
> - isert_warn("Reached TX IB_EVENT_QP_LAST_WQE_REACHED\n");
> - break;
Don't think you need to touch the ulps, they want to log these events,
so be it.
Although, a warn is not appropriate at all here.
next prev parent reply other threads:[~2024-06-19 9:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 0:10 [PATCH v1 0/6] Last WQE Reached event treatment Max Gurtovoy
2024-06-18 0:10 ` [PATCH 1/6] IB/core: add support for draining Shared receive queues Max Gurtovoy
2024-06-18 16:07 ` Bart Van Assche
2024-06-19 9:14 ` Sagi Grimberg
2024-06-19 11:12 ` Max Gurtovoy
2024-06-19 9:09 ` Sagi Grimberg
2024-06-19 11:16 ` Max Gurtovoy
2024-06-18 0:10 ` [PATCH 2/6] IB/isert: remove the handling of last WQE reached event Max Gurtovoy
2024-06-19 9:16 ` Sagi Grimberg [this message]
2024-06-19 15:25 ` Max Gurtovoy
2024-06-18 0:10 ` [PATCH 3/6] RDMA/srpt: " Max Gurtovoy
2024-06-18 16:08 ` Bart Van Assche
2024-06-18 0:10 ` [PATCH 4/6] nvmet-rdma: " Max Gurtovoy
2024-06-18 0:10 ` [PATCH 5/6] svcrdma: " Max Gurtovoy
2024-06-18 15:12 ` Chuck Lever
2024-06-18 0:10 ` [PATCH 6/6] RDMA/IPoIB: " Max Gurtovoy
2024-06-19 9:18 ` Sagi Grimberg
2024-06-19 9:25 ` Leon Romanovsky
2024-06-23 13:03 ` [PATCH v1 0/6] Last WQE Reached event treatment Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f12e1a75-2fd1-46ef-aee9-520cced08f11@grimberg.me \
--to=sagi@grimberg.me \
--cc=bvanassche@acm.org \
--cc=chuck.lever@oracle.com \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=israelr@nvidia.com \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=mgurtovoy@nvidia.com \
--cc=oren@nvidia.com \
--cc=shiraz.saleem@intel.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox