From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/1] nvme: fix implicit bool to flags conversion
Date: Tue, 20 May 2025 09:21:26 -0600 [thread overview]
Message-ID: <eac36a76-fc41-480c-b2f1-542a9bdf8d1d@kernel.dk> (raw)
In-Reply-To: <d8ed3f9ae153dfc3e8a2a63ed5abbc5e1f0589fb.1747753887.git.asml.silence@gmail.com>
On 5/20/25 9:14 AM, Pavel Begunkov wrote:
> nvme_map_user_request() takes flags as the last argument, but
> nvme_uring_cmd_io() shoves a bool "vec" into it. It behaves as
> expected because bool is converted to 0/1 and NVME_IOCTL_VEC is
> defined as 1, but it's better to pass flags explicitly.
LGTM:
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2025-05-20 15:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250520152811epcas5p3a0c63ffa250d376b3a9bec758fd12524@epcas5p3.samsung.com>
2025-05-20 15:14 ` [PATCH 1/1] nvme: fix implicit bool to flags conversion Pavel Begunkov
2025-05-20 15:21 ` Jens Axboe [this message]
2025-05-20 15:38 ` Anuj gupta
2025-05-20 15:42 ` Caleb Sander Mateos
2025-05-20 15:46 ` Keith Busch
2025-05-21 9:29 ` Pavel Begunkov
2025-05-20 15:51 ` Kanchan Joshi
2025-05-20 19:17 ` Chaitanya Kulkarni
2025-05-21 11:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eac36a76-fc41-480c-b2f1-542a9bdf8d1d@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox