public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 0/3] nvmet: fix compilation warnings
@ 2022-03-08 23:00 Chaitanya Kulkarni
  2022-03-08 23:00 ` [PATCH 1/3] nvmet-fc: fix compilation warning for register Chaitanya Kulkarni
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2022-03-08 23:00 UTC (permalink / raw)
  To: linux-nvme; +Cc: hch, sagi, Chaitanya Kulkarni

Hi,

Fixes for compilation warning for target.

-ck

Chaitanya Kulkarni (3):
  nvmet-fc: fix compilation warning for register
  nvmet-fc: fix compilation warning for unregitser
  nvmet-rdma: fix compilation warning

 drivers/nvme/target/fc.c   | 4 ++--
 drivers/nvme/target/rdma.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.29.0



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/3] nvmet-fc: fix compilation warning for register
  2022-03-08 23:00 [PATCH 0/3] nvmet: fix compilation warnings Chaitanya Kulkarni
@ 2022-03-08 23:00 ` Chaitanya Kulkarni
  2022-03-08 23:00 ` [PATCH 2/3] nvmet-fc: fix compilation warning for unregitser Chaitanya Kulkarni
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2022-03-08 23:00 UTC (permalink / raw)
  To: linux-nvme; +Cc: hch, sagi, Chaitanya Kulkarni

This fixes following compilation warning :-

drivers/nvme/target/fc.c:1365: warning: expecting prototype for nvme_fc_register_targetport(). Prototype was for nvmet_fc_register_targetport() instead

Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
 drivers/nvme/target/fc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index cb013516784c..56c2bdfd8e3b 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -1341,7 +1341,7 @@ nvmet_fc_portentry_rebind_tgt(struct nvmet_fc_tgtport *tgtport)
 }
 
 /**
- * nvme_fc_register_targetport - transport entry point called by an
+ * nvmet_fc_register_targetport - transport entry point called by an
  *                              LLDD to register the existence of a local
  *                              NVME subystem FC port.
  * @pinfo:     pointer to information about the port to be registered
-- 
2.29.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] nvmet-fc: fix compilation warning for unregitser
  2022-03-08 23:00 [PATCH 0/3] nvmet: fix compilation warnings Chaitanya Kulkarni
  2022-03-08 23:00 ` [PATCH 1/3] nvmet-fc: fix compilation warning for register Chaitanya Kulkarni
@ 2022-03-08 23:00 ` Chaitanya Kulkarni
  2022-03-08 23:00 ` [PATCH 3/3] nvmet-rdma: fix compilation warning Chaitanya Kulkarni
  2022-03-08 23:33 ` [PATCH 0/3] nvmet: fix compilation warnings Jens Axboe
  3 siblings, 0 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2022-03-08 23:00 UTC (permalink / raw)
  To: linux-nvme; +Cc: hch, sagi, Chaitanya Kulkarni

This fixes following compilation warning:-

drivers/nvme/target/fc.c:1619: warning: expecting prototype for nvme_fc_unregister_targetport(). Prototype was for nvmet_fc_unregister_targetport() instead

Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
 drivers/nvme/target/fc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index 56c2bdfd8e3b..de90001fc5c4 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -1604,7 +1604,7 @@ nvmet_fc_delete_ctrl(struct nvmet_ctrl *ctrl)
 }
 
 /**
- * nvme_fc_unregister_targetport - transport entry point called by an
+ * nvmet_fc_unregister_targetport - transport entry point called by an
  *                              LLDD to deregister/remove a previously
  *                              registered a local NVME subsystem FC port.
  * @target_port: pointer to the (registered) target port that is to be
-- 
2.29.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/3] nvmet-rdma: fix compilation warning
  2022-03-08 23:00 [PATCH 0/3] nvmet: fix compilation warnings Chaitanya Kulkarni
  2022-03-08 23:00 ` [PATCH 1/3] nvmet-fc: fix compilation warning for register Chaitanya Kulkarni
  2022-03-08 23:00 ` [PATCH 2/3] nvmet-fc: fix compilation warning for unregitser Chaitanya Kulkarni
@ 2022-03-08 23:00 ` Chaitanya Kulkarni
  2022-03-08 23:33 ` [PATCH 0/3] nvmet: fix compilation warnings Jens Axboe
  3 siblings, 0 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2022-03-08 23:00 UTC (permalink / raw)
  To: linux-nvme; +Cc: hch, sagi, Chaitanya Kulkarni

This fixes following compilation warning:-

drivers/nvme/target/rdma.c:1722: warning: expecting prototype for nvme_rdma_device_removal(). Prototype was for nvmet_rdma_device_removal() instead

Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
 drivers/nvme/target/rdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 00656754e331..2446d0918a41 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -1703,7 +1703,7 @@ static void nvmet_rdma_queue_connect_fail(struct rdma_cm_id *cm_id,
 }
 
 /**
- * nvme_rdma_device_removal() - Handle RDMA device removal
+ * nvmet_rdma_device_removal() - Handle RDMA device removal
  * @cm_id:	rdma_cm id, used for nvmet port
  * @queue:      nvmet rdma queue (cm id qp_context)
  *
-- 
2.29.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/3] nvmet: fix compilation warnings
  2022-03-08 23:00 [PATCH 0/3] nvmet: fix compilation warnings Chaitanya Kulkarni
                   ` (2 preceding siblings ...)
  2022-03-08 23:00 ` [PATCH 3/3] nvmet-rdma: fix compilation warning Chaitanya Kulkarni
@ 2022-03-08 23:33 ` Jens Axboe
  2022-03-09  4:15   ` Chaitanya Kulkarni
  3 siblings, 1 reply; 6+ messages in thread
From: Jens Axboe @ 2022-03-08 23:33 UTC (permalink / raw)
  To: Chaitanya Kulkarni, linux-nvme; +Cc: hch, sagi

On 3/8/22 4:00 PM, Chaitanya Kulkarni wrote:
> Hi,
> 
> Fixes for compilation warning for target.
> 
> -ck
> 
> Chaitanya Kulkarni (3):
>   nvmet-fc: fix compilation warning for register
>   nvmet-fc: fix compilation warning for unregitser
>   nvmet-rdma: fix compilation warning

Nit - these are kerneldoc warnings, they are not compilation warnings. I
would reword those commits.

-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/3] nvmet: fix compilation warnings
  2022-03-08 23:33 ` [PATCH 0/3] nvmet: fix compilation warnings Jens Axboe
@ 2022-03-09  4:15   ` Chaitanya Kulkarni
  0 siblings, 0 replies; 6+ messages in thread
From: Chaitanya Kulkarni @ 2022-03-09  4:15 UTC (permalink / raw)
  To: Jens Axboe
  Cc: hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org,
	Chaitanya Kulkarni

On 3/8/22 15:33, Jens Axboe wrote:
> On 3/8/22 4:00 PM, Chaitanya Kulkarni wrote:
>> Hi,
>>
>> Fixes for compilation warning for target.
>>
>> -ck
>>
>> Chaitanya Kulkarni (3):
>>    nvmet-fc: fix compilation warning for register
>>    nvmet-fc: fix compilation warning for unregitser
>>    nvmet-rdma: fix compilation warning
> 
> Nit - these are kerneldoc warnings, they are not compilation warnings. I
> would reword those commits.

Okay will send out v2, thanks.

-ck



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-03-09  4:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-08 23:00 [PATCH 0/3] nvmet: fix compilation warnings Chaitanya Kulkarni
2022-03-08 23:00 ` [PATCH 1/3] nvmet-fc: fix compilation warning for register Chaitanya Kulkarni
2022-03-08 23:00 ` [PATCH 2/3] nvmet-fc: fix compilation warning for unregitser Chaitanya Kulkarni
2022-03-08 23:00 ` [PATCH 3/3] nvmet-rdma: fix compilation warning Chaitanya Kulkarni
2022-03-08 23:33 ` [PATCH 0/3] nvmet: fix compilation warnings Jens Axboe
2022-03-09  4:15   ` Chaitanya Kulkarni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox