* [PATCH] qla2xxx: convert nvme Transport error to internal error
@ 2017-09-14 18:30 James Smart
2017-09-14 19:39 ` Madhani, Himanshu
0 siblings, 1 reply; 5+ messages in thread
From: James Smart @ 2017-09-14 18:30 UTC (permalink / raw)
Patch removing transport-specific errors crosssed with a qla2xxx update
that referenced the status value being removed.
Swap status to an internal error.
Signed-off-by: James Smart <james.smart at broadcom.com>
---
drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
index 1f59e7a74c7b..6b33a1f24f56 100644
--- a/drivers/scsi/qla2xxx/qla_nvme.c
+++ b/drivers/scsi/qla2xxx/qla_nvme.c
@@ -180,7 +180,7 @@ static void qla_nvme_sp_done(void *ptr, int res)
goto rel;
if (unlikely(res == QLA_FUNCTION_FAILED))
- fd->status = NVME_SC_FC_TRANSPORT_ERROR;
+ fd->status = NVME_SC_INTERNAL;
else
fd->status = 0;
--
2.13.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] qla2xxx: convert nvme Transport error to internal error
2017-09-14 18:30 [PATCH] qla2xxx: convert nvme Transport error to internal error James Smart
@ 2017-09-14 19:39 ` Madhani, Himanshu
2017-09-16 1:02 ` Martin K. Petersen
0 siblings, 1 reply; 5+ messages in thread
From: Madhani, Himanshu @ 2017-09-14 19:39 UTC (permalink / raw)
> On Sep 14, 2017,@11:30 AM, James Smart <jsmart2021@gmail.com> wrote:
>
> Patch removing transport-specific errors crosssed with a qla2xxx update
> that referenced the status value being removed.
>
> Swap status to an internal error.
>
> Signed-off-by: James Smart <james.smart at broadcom.com>
> ---
> drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
> index 1f59e7a74c7b..6b33a1f24f56 100644
> --- a/drivers/scsi/qla2xxx/qla_nvme.c
> +++ b/drivers/scsi/qla2xxx/qla_nvme.c
> @@ -180,7 +180,7 @@ static void qla_nvme_sp_done(void *ptr, int res)
> goto rel;
>
> if (unlikely(res == QLA_FUNCTION_FAILED))
> - fd->status = NVME_SC_FC_TRANSPORT_ERROR;
> + fd->status = NVME_SC_INTERNAL;
> else
> fd->status = 0;
>
> --
> 2.13.1
>
Looks good.
Acked-by: Himanshu Madhani <himanshu.madhani at cavium.com>
Thanks,
- Himanshu
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] qla2xxx: convert nvme Transport error to internal error
2017-09-14 19:39 ` Madhani, Himanshu
@ 2017-09-16 1:02 ` Martin K. Petersen
2017-09-16 1:09 ` hch
0 siblings, 1 reply; 5+ messages in thread
From: Martin K. Petersen @ 2017-09-16 1:02 UTC (permalink / raw)
Himanshu,
>> Patch removing transport-specific errors crosssed with a qla2xxx update
>> that referenced the status value being removed.
>>
>> Swap status to an internal error.
Applied to 4.14/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] qla2xxx: convert nvme Transport error to internal error
2017-09-16 1:02 ` Martin K. Petersen
@ 2017-09-16 1:09 ` hch
2017-09-16 1:12 ` Martin K. Petersen
0 siblings, 1 reply; 5+ messages in thread
From: hch @ 2017-09-16 1:09 UTC (permalink / raw)
On Fri, Sep 15, 2017@09:02:22PM -0400, Martin K. Petersen wrote:
>
> Himanshu,
>
> >> Patch removing transport-specific errors crosssed with a qla2xxx update
> >> that referenced the status value being removed.
> >>
> >> Swap status to an internal error.
>
> Applied to 4.14/scsi-fixes.
I've already picked this up with the reset of James' series to get rid of
these errors in lpfc and the nvme code. I can still rebase the nvme tree,
but it will require the scsi tree to get in first which is a little
annoying.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] qla2xxx: convert nvme Transport error to internal error
2017-09-16 1:09 ` hch
@ 2017-09-16 1:12 ` Martin K. Petersen
0 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2017-09-16 1:12 UTC (permalink / raw)
Christoph,
> I've already picked this up with the reset of James' series to get rid
> of these errors in lpfc and the nvme code. I can still rebase the
> nvme tree, but it will require the scsi tree to get in first which is
> a little annoying.
That's fine. I'll just drop it.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-16 1:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-14 18:30 [PATCH] qla2xxx: convert nvme Transport error to internal error James Smart
2017-09-14 19:39 ` Madhani, Himanshu
2017-09-16 1:02 ` Martin K. Petersen
2017-09-16 1:09 ` hch
2017-09-16 1:12 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox