Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCH] nvme: Quirks for PM1725 controllers
Date: Wed, 28 Jun 2017 12:51:51 -0400	[thread overview]
Message-ID: <yq1fuekxdg8.fsf@oracle.com> (raw)
In-Reply-To: <20170628164449.GA2650@localhost.localdomain> (Keith Busch's message of "Wed, 28 Jun 2017 12:44:50 -0400")


Keith,

>> and the this is:
>> 
>> 	} else if (dev->ctrl.quirks & NVME_QUIRK_QD_LIMIT_64) {
>> 
>> While its inside the pci driver, I think it would be cleaner to
>> use the quirks mechanism.
>> 
>> Kieth? thoughts?
>
> Yeah, that's better than VID:DID checks. We only get 32 defined quirks
> using driver_data, and while we currently can spare 2 of them for q-depth
> quirks, I was hoping to use these bits more sparingly.

That's fine. I did tinker with quirks for the queue depth at some point
but I think I had problems due to needing to clamp the admin queue depth
as well. I had to shuffle a bunch of stuff and introduce wrappers for
accessing the AQ depth. But with Sagi's recent patch that's no longer
necessary. So most of that churn went away when I rebased yesterday.

Will resend.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2017-06-28 16:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28  2:27 [PATCH] nvme: Quirks for PM1725 controllers Martin K. Petersen
2017-06-28  7:27 ` Sagi Grimberg
2017-06-28 16:44   ` Keith Busch
2017-06-28 16:51     ` Martin K. Petersen [this message]
2017-07-01 21:31 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1fuekxdg8.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox