[PATCH] Add OHCI USB platform init

[PATCH] Add OHCI USB platform init

[viral.mehta-oonXi/34qI7c+919tysfdA]

From: Viral Mehta <viral.mehta-oonXi/34qI7c+919tysfdA@public.gmane.org>

Add platform init code for OHCI USB on OMAP2430 SDP

Signed-off-by: Viral Mehta <viral.mehta-oonXi/34qI7c+919tysfdA@public.gmane.org>
---
 arch/arm/mach-omap2/board-2430sdp.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c
index 346e1d2..047d5ae 100644
--- a/arch/arm/mach-omap2/board-2430sdp.c
+++ b/arch/arm/mach-omap2/board-2430sdp.c
@@ -206,6 +206,15 @@ static struct omap_musb_board_data musb_board_data = {
        .mode                   = MUSB_OTG,
        .power                  = 100,
 };
+static struct omap_usb_config sdp2430_usb_config __initdata = {
+       .otg            = 1,
+#ifdef  CONFIG_USB_GADGET_OMAP
+       .hmc_mode       = 0x0,
+#elif   defined(CONFIG_USB_OHCI_HCD) || defined(CONFIG_USB_OHCI_HCD_MODULE)
+       .hmc_mode       = 0x1,
+#endif
+       .pins[0]        = 3,
+}

 static void __init omap_2430sdp_init(void)
 {
@@ -216,6 +225,7 @@ static void __init omap_2430sdp_init(void)
        platform_add_devices(sdp2430_devices, ARRAY_SIZE(sdp2430_devices));
        omap_serial_init();
        omap2_hsmmc_init(mmc);
+       omap_usb_init(&sdp2430_usb_config);
        usb_musb_init(&musb_board_data);
        board_smc91x_init();

--
1.6.6


This Email may contain confidential or privileged information for the intended recipient (s) If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

______________________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] Add OHCI USB platform init

[Maulik]

> +static struct omap_usb_config sdp2430_usb_config __initdata = {
> +       .otg            = 1,
> +#ifdef  CONFIG_USB_GADGET_OMAP
> +       .hmc_mode       = 0x0,
> +#elif   defined(CONFIG_USB_OHCI_HCD) ||
> defined(CONFIG_USB_OHCI_HCD_MODULE)
> +       .hmc_mode       = 0x1,
> +#endif
> +       .pins[0]        = 3,
> +}

Use tabs instead of spaces. 

> 
>  static void __init omap_2430sdp_init(void)
>  {
> @@ -216,6 +225,7 @@ static void __init omap_2430sdp_init(void)
>         platform_add_devices(sdp2430_devices,
> ARRAY_SIZE(sdp2430_devices));
>         omap_serial_init();
>         omap2_hsmmc_init(mmc);
> +       omap_usb_init(&sdp2430_usb_config);

And here too.

Maulik

RE: [PATCH] Add OHCI USB platform init

[Viral Mehta]

>> +static struct omap_usb_config sdp2430_usb_config __initdata = {
>> +       .otg            = 1,
>> +#ifdef  CONFIG_USB_GADGET_OMAP
>> +       .hmc_mode       = 0x0,
>> +#elif   defined(CONFIG_USB_OHCI_HCD) ||
>> defined(CONFIG_USB_OHCI_HCD_MODULE)
>> +       .hmc_mode       = 0x1,
>> +#endif
>> +       .pins[0]        = 3,
>> +}

>Use tabs instead of spaces.


tabs only used. even checkpatch says no warning/error.

[root@viral my_git]# /home/omap2430/mod.linux-2.6.33.1/scripts/checkpatch.pl 0002-Add-I2C-bus-1-initialisation.patch
total: 0 errors, 0 warnings, 18 lines checked

0002-Add-I2C-bus-1-initialisation.patch has no obvious style problems and is ready for submission.

I assume its your mailer that mangled the things. Sent through git-send-email and so that should not cause a problem, too. If some one else also points out, will try to resend.

Thanks,
Viral

This Email may contain confidential or privileged information for the intended recipient (s) If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

______________________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] Add OHCI USB platform init

[Gadiyar, Anand]

Viral Mehta wrote:
> >Use tabs instead of spaces.
> 
> 
> tabs only used. even checkpatch says no warning/error.
> 
> [root@viral my_git]# 
> /home/omap2430/mod.linux-2.6.33.1/scripts/checkpatch.pl 
> 0002-Add-I2C-bus-1-initialisation.patch
> total: 0 errors, 0 warnings, 18 lines checked
> 
> 0002-Add-I2C-bus-1-initialisation.patch has no obvious style 
> problems and is ready for submission.
> 
> I assume its your mailer that mangled the things. Sent 
> through git-send-email and so that should not cause a 
> problem, too. If some one else also points out, will try to resend.
> 

We can see the tab-damage when viewing this in the archives.

See [1] for your patch, and see [2] for a patch that is not tab-damaged.

- Anand

[1] <http://marc.info/?l=linux-usb&m=127104671809949&w=2>
[2] <http://marc.info/?l=linux-usb&m=127106719931759&w=2>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html