[PATCH v1 0/1] Add TI TPS65215 PMIC GPIO Support

[PATCH v1 0/1] Add TI TPS65215 PMIC GPIO Support

[Shree Ramamoorthy]

TPS65214 is a Power Management Integrated Circuit (PMIC) that has
significant register map overlap with TPS65215 and TPS65219. The series 
introduces TPS65214 and adds the device to the multi-PMIC support driver.

This follow-up series is dependent on:
Commit 2c4fd76d13ec ("mfd: tps65214: Add support for TI TPS65214 PMIC")
Commit d23b7176df4a ("regulator: dt-bindings: Add TI TPS65214 PMIC bindings")

TPS65215 Driver Series:
GPIO: https://lore.kernel.org/all/20250113225530.124213-1-s-ramamoorthy@ti.com/
MFD: https://lore.kernel.org/all/20250113230750.124843-1-s-ramamoorthy@ti.com/
Reg: https://lore.kernel.org/all/20250113231018.125426-1-s-ramamoorthy@ti.com/
Input: https://lore.kernel.org/all/20241226220049.398794-1-s-ramamoorthy@ti.com/

TPS65219 Cleanup Series:
GPIO: https://lore.kernel.org/all/20241217204755.1011731-1-s-ramamoorthy@ti.com/
MFD: https://lore.kernel.org/all/20241217204935.1012106-1-s-ramamoorthy@ti.com/
Reg: https://lore.kernel.org/all/20241217204526.1010989-1-s-ramamoorthy@ti.com/

- TPS65214 is a Power Management IC with 3 Buck regulators and 2 LDOs.
- TPS65214 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs.
- TPS65214's LDO1 maps to TPS65219's LDO3.
- A key difference between TPS65215 & TPS65214 are the LDO current and
  voltage output ranges and the configurable options available.
- The remaining features for both devices are the same.

TPS65214 TRM: https://www.ti.com/lit/pdf/slvud30

AM62L + TPS65214 Test Logs:
https://gist.github.com/ramamoorthyhs/0793f7813332d94423ca1baee02f62c9

Shree Ramamoorthy (1):
  gpio: tps65214: Add support for TI TPS65214 PMIC

 drivers/gpio/gpio-tps65219.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

-- 
2.43.0

[PATCH v1 1/1] gpio: tps65214: Add support for TI TPS65214 PMIC

[Shree Ramamoorthy]

Add TPS65214 support to platform_id table and device-specific chip_data
struct. Update descriptions to reflect the driver supports 3 PMICs:
TPS65214, TPS65215, and TPS65219.

Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
---
 drivers/gpio/gpio-tps65219.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-tps65219.c b/drivers/gpio/gpio-tps65219.c
index 6845f2920f3a..6b8d88ca3e8a 100644
--- a/drivers/gpio/gpio-tps65219.c
+++ b/drivers/gpio/gpio-tps65219.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * GPIO driver for TI TPS65215/TPS65219 PMICs
+ * TI TPS65214/TPS65215/TPS65219 PMIC GPIO Driver
  *
  * Copyright (C) 2024 Texas Instruments Incorporated - http://www.ti.com/
  */
@@ -156,6 +156,10 @@ static const struct gpio_chip tps65219_template_chip = {
 };
 
 static const struct tps65219_chip_data chip_info_table[] = {
+	[TPS65214] = {
+		.ngpio = 2,
+		.offset = 1,
+	},
 	[TPS65215] = {
 		.ngpio = 2,
 		.offset = 1,
@@ -191,6 +195,7 @@ static int tps65219_gpio_probe(struct platform_device *pdev)
 }
 
 static const struct platform_device_id tps6521x_gpio_id_table[] = {
+	{ "tps65214-gpio", TPS65214 },
 	{ "tps65215-gpio", TPS65215 },
 	{ "tps65219-gpio", TPS65219 },
 	{ }
@@ -207,5 +212,5 @@ static struct platform_driver tps65219_gpio_driver = {
 module_platform_driver(tps65219_gpio_driver);
 
 MODULE_AUTHOR("Jonathan Cormier <jcormier@criticallink.com>");
-MODULE_DESCRIPTION("TPS65215/TPS65219 GPIO driver");
+MODULE_DESCRIPTION("TPS65214/TPS65215/TPS65219 GPIO driver");
 MODULE_LICENSE("GPL");
-- 
2.43.0

Re: [PATCH v1 0/1] Add TI TPS65215 PMIC GPIO Support

[Krzysztof Kozlowski]

On 16/01/2025 23:38, Shree Ramamoorthy wrote:
> TPS65214 is a Power Management Integrated Circuit (PMIC) that has
> significant register map overlap with TPS65215 and TPS65219. The series 
> introduces TPS65214 and adds the device to the multi-PMIC support driver.
> 
> This follow-up series is dependent on:
> Commit 2c4fd76d13ec ("mfd: tps65214: Add support for TI TPS65214 PMIC")
> Commit d23b7176df4a ("regulator: dt-bindings: Add TI TPS65214 PMIC bindings")
> 
So this now depends on everything? That's total mess.
Best regards,
Krzysztof

Re: [PATCH v1 1/1] gpio: tps65214: Add support for TI TPS65214 PMIC

[Krzysztof Kozlowski]

On 16/01/2025 23:38, Shree Ramamoorthy wrote:
>  /*
> - * GPIO driver for TI TPS65215/TPS65219 PMICs
> + * TI TPS65214/TPS65215/TPS65219 PMIC GPIO Driver
>   *
>   * Copyright (C) 2024 Texas Instruments Incorporated - http://www.ti.com/
>   */
> @@ -156,6 +156,10 @@ static const struct gpio_chip tps65219_template_chip = {
>  };
>  
>  static const struct tps65219_chip_data chip_info_table[] = {
> +	[TPS65214] = {
> +		.ngpio = 2,
> +		.offset = 1,


So that's the same as TPS65215? Why do you keep duplicating entries?

> +	},
>  	[TPS65215] = {
>  		.ngpio = 2,
>  		.offset = 1,

Best regards,
Krzysztof

Re: [PATCH v1 1/1] gpio: tps65214: Add support for TI TPS65214 PMIC

[Shree Ramamoorthy]

Hi,

On 1/17/25 3:27 AM, Krzysztof Kozlowski wrote:
> On 16/01/2025 23:38, Shree Ramamoorthy wrote:
>>  /*
>> - * GPIO driver for TI TPS65215/TPS65219 PMICs
>> + * TI TPS65214/TPS65215/TPS65219 PMIC GPIO Driver
>>   *
>>   * Copyright (C) 2024 Texas Instruments Incorporated - http://www.ti.com/
>>   */
>> @@ -156,6 +156,10 @@ static const struct gpio_chip tps65219_template_chip = {
>>  };
>>  
>>  static const struct tps65219_chip_data chip_info_table[] = {
>> +	[TPS65214] = {
>> +		.ngpio = 2,
>> +		.offset = 1,
> So that's the same as TPS65215? Why do you keep duplicating entries?

Thanks for reviewing! I will register TPS65214 as "tps65215-gpio" in the
MFD driver to minimize changes. This will eliminate the tps65215 gpio series,
since only the description changes are left.

>> +	},
>>  	[TPS65215] = {
>>  		.ngpio = 2,
>>  		.offset = 1,
> Best regards,
> Krzysztof

-- 
Best,
Shree Ramamoorthy
PMIC Software Engineer