* Question regarding OMAP NAND driver read_buf16() function
@ 2008-11-20 19:13 Peter Barada
2008-11-20 20:53 ` David Brownell
0 siblings, 1 reply; 2+ messages in thread
From: Peter Barada @ 2008-11-20 19:13 UTC (permalink / raw)
To: linux-omap
In drivers/mtd/nand/omap2.c, I see the call to __raw_readsl:
__raw_readsl(nand->IO_ADDR_R, buf, len / 2);
Since len is in bytes (from the comment), shouldn't this either be:
__raw_readsl(nand->IO_ADDR_R, buf, len / 4);
or:
__raw_readsw(nand->IO_ADDR_R, buf, len / 2);
--
Peter Barada // senior software engineer
LOGIC // embedded product solutions
411 Washington Ave. N. Suite 400
Minneapolis, MN 55401
M // 617.513.5874
Peter.Barada@logicpd.com
www.logicpd.com
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Question regarding OMAP NAND driver read_buf16() function
2008-11-20 19:13 Question regarding OMAP NAND driver read_buf16() function Peter Barada
@ 2008-11-20 20:53 ` David Brownell
0 siblings, 0 replies; 2+ messages in thread
From: David Brownell @ 2008-11-20 20:53 UTC (permalink / raw)
To: Peter Barada; +Cc: linux-omap
On Thursday 20 November 2008, Peter Barada wrote:
> In drivers/mtd/nand/omap2.c, I see the call to __raw_readsl:
>
> __raw_readsl(nand->IO_ADDR_R, buf, len / 2);
>
> Since len is in bytes (from the comment), shouldn't this either be:
>
> __raw_readsl(nand->IO_ADDR_R, buf, len / 4);
>
> or:
>
> __raw_readsw(nand->IO_ADDR_R, buf, len / 2);
>
Current GIT has the latter. Upgrde your kernel. ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-20 20:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-20 19:13 Question regarding OMAP NAND driver read_buf16() function Peter Barada
2008-11-20 20:53 ` David Brownell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox