Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: linux-omap@vger.kernel.org
Cc: paul@pwsan.com
Subject: [PATCH v2 02/13] OMAP: hwmod: allow idle after HWMOD_INIT_NO_IDLE
Date: Thu, 24 Jun 2010 16:44:33 -0700	[thread overview]
Message-ID: <1277423084-25528-3-git-send-email-khilman@deeprootsystems.com> (raw)
In-Reply-To: <1277423084-25528-1-git-send-email-khilman@deeprootsystems.com>

If an omap_hwmod is setup using HWMOD_INIT_NO_IDLE flag, there is
currently way to idle it since omap_hwmod_idle() requires the hwmod to
be in the enabled state.

This patch adds a check to omap_hwmod_idle() so if the hwmod was has
the INIT_NO_IDLE flag, calling omap_hwmod_idle() will still succeed.

Cc: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
---
 arch/arm/mach-omap2/omap_hwmod.c |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index 95c9a5f..ac75407 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -938,7 +938,13 @@ static int _enable(struct omap_hwmod *oh)
  */
 static int _idle(struct omap_hwmod *oh)
 {
-	if (oh->_state != _HWMOD_STATE_ENABLED) {
+	/*
+	 * To idle, hwmod must be enabled, EXCEPT if hwmod was
+	 * initialized using the INIT_NO_IDLE flag.  In this case it
+	 * will not yet be enabled so we have to allow it to be idled.
+	 */
+	if ((oh->_state != _HWMOD_STATE_ENABLED) &&
+	    !(oh->flags & HWMOD_INIT_NO_IDLE)) {
 		WARN(1, "omap_hwmod: %s: idle state can only be entered from "
 		     "enabled state\n", oh->name);
 		return -EINVAL;
@@ -953,6 +959,9 @@ static int _idle(struct omap_hwmod *oh)
 
 	oh->_state = _HWMOD_STATE_IDLE;
 
+	/* Clear init flag which should only affect first call to idle */
+	oh->flags &= ~HWMOD_INIT_NO_IDLE;
+
 	return 0;
 }
 
-- 
1.7.0.2


  parent reply	other threads:[~2010-06-24 23:44 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-24 23:44 [PATCH v2 00/13] OMAP: CM, hwmod, omap_device fixes and updates Kevin Hilman
2010-06-24 23:44 ` [PATCH v2 01/13] OMAP24xx: CM: fix mask used for checking IDLEST status Kevin Hilman
2010-06-24 23:44 ` Kevin Hilman [this message]
2010-06-24 23:44 ` [PATCH v2 03/13] OMAP2/3: hwmod: L3 and L4 CORE/PER/WKUP hwmods don't have IDLEST Kevin Hilman
2010-06-24 23:44 ` [PATCH v2 04/13] OMAP: hwmod: Fix the missing braces Kevin Hilman
2010-07-02 11:49   ` Paul Walmsley
2010-06-24 23:44 ` [PATCH v2 05/13] OMAP2&3: hwmod: Remove _hwmod prefix in name string Kevin Hilman
2010-06-24 23:44 ` [PATCH v2 06/13] OMAP: hwmod: add non-locking versions of enable and idle functions Kevin Hilman
2010-06-24 23:44 ` [PATCH v2 07/13] OMAP: hwmod: don't auto-disable hwmod when !CONFIG_PM_RUNTIME Kevin Hilman
2010-06-24 23:44 ` [PATCH v2 08/13] OMAP4: hwmod: Enable omap_device build for OMAP4 Kevin Hilman
2010-06-25 13:16   ` Cousson, Benoit
2010-06-25 17:27     ` Kevin Hilman
2010-06-24 23:44 ` [PATCH v2 09/13] OMAP: omap_device: ensure hwmod tracks attached omap_device pointer Kevin Hilman
2010-07-02  9:05   ` Paul Walmsley
2010-06-24 23:44 ` [PATCH v2 10/13] OMAP: create omap_devices for MPU, DSP, L3 Kevin Hilman
2010-06-26 16:08   ` DebBarma, Tarun Kanti
2010-06-29 17:29   ` Kevin Hilman
2010-06-30  4:18     ` Gopinath, Thara
2010-06-30 20:38       ` Kevin Hilman
2010-07-01  4:04         ` Gopinath, Thara
2010-07-01  4:16           ` Shilimkar, Santosh
2010-07-01  4:20             ` Gopinath, Thara
2010-07-02 11:45     ` Paul Walmsley
2010-07-02 15:08       ` Paul Walmsley
2010-06-24 23:44 ` [PATCH v2 11/13] OMAP: hwmod data: add class for IVA hwmods Kevin Hilman
2010-06-24 23:44 ` [PATCH v2 12/13] OMAP2&3: hwmod: Replace l3 -> l3_main Kevin Hilman
2010-06-24 23:44 ` [PATCH v2 13/13] OMAP3: hwmod data: add data for OMAP3 IVA2 Kevin Hilman
2010-07-02 11:50 ` [PATCH v2 00/13] OMAP: CM, hwmod, omap_device fixes and updates Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1277423084-25528-3-git-send-email-khilman@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox