From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Steve Sakoman <sakoman@gmail.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/2] OMAP: DSS2: Add DSS2 support for Overo
Date: Fri, 4 Mar 2011 17:30:14 +0200 [thread overview]
Message-ID: <1299252614.2053.5.camel@deskari> (raw)
In-Reply-To: <AANLkTikSq+9A_HVy0dk2coYb9AvVRgHZOG1q0RRCJtV1@mail.gmail.com>
On Fri, 2011-03-04 at 09:25 -0600, Steve Sakoman wrote:
> On Fri, Mar 4, 2011 at 12:00 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>
> > Why check for CONFIG_PANEL_LGPHILIPS_LB035Q02, but not for the lcd43?
> >
> > And is that even necessary? Of course it would make the kernel very
> > slightly smaller if you leave some code out, but otherwise does that
> > help? If you have the device definitions there, but the user doesn't
> > load the driver, they wouldn't do anything, would they?
> >
> > For me the ifdefs just make the code harder to read, but I'm not sure if
> > there's some standard custom to have these.
<snip>
> The spidev driver turns out to be useful for a lot of embedded
> applications, so I would prefer to leave the check in place if you
> agree that this could be useful.
Yes, sounds like a valid reason to me.
Tomi
prev parent reply other threads:[~2011-03-04 15:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 23:46 [PATCH 0/2] Add DSS2 support on Overo Steve Sakoman
2011-03-03 23:46 ` [PATCH 1/2] OMAP: DSS2: Add support for LG Philips LB035Q02 panel Steve Sakoman
2011-03-04 7:55 ` Tomi Valkeinen
2011-03-04 15:29 ` Steve Sakoman
2011-03-04 15:41 ` Tomi Valkeinen
2011-03-04 17:08 ` Steve Sakoman
2011-03-03 23:46 ` [PATCH 2/2] OMAP: DSS2: Add DSS2 support for Overo Steve Sakoman
2011-03-04 8:00 ` Tomi Valkeinen
2011-03-04 15:25 ` Steve Sakoman
2011-03-04 15:30 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299252614.2053.5.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=sakoman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox