Re: [PATCH 1/2] OMAP: DSS2: Add support for LG Philips LB035Q02 panel

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

On Fri, 2011-03-04 at 09:29 -0600, Steve Sakoman wrote:
> On Thu, Mar 3, 2011 at 11:55 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:

<snip>

> > This wouldn't work with two panel devices. If you think the case where
> > you have to panels, meaning two spi devices and two dss devices. You
> > first register the spi driver, which would call probe for both of the
> > spi devices. The first spi probe call would registers the dss driver,
> > which would call probe for both of the dss devices. At this point only
> > the first spi device would have been probed...
> >
> > This is a bit tricky, and I'm not sure if there's any ready-made
> > solution for this. But what we need is a way to link a spesific spi
> > device to a specific dss device in the board file.
> >
> > Then this panel module would register both dss driver and spi driver in
> > the module_init(), and after both dss and spi probe has been called for
> > the particular dss+spi device pair, the actual display driver would
> > start.
> >
> > So this needs some work, and also some careful checks in, for example,
> > panel_enable, because nothing says that the spi device is ready when
> > panel_enable is called.
> 
> Well, on Overo it would not be possible to add more than one Palo35,
> but I see your point in theory.

Yes, I think the only possible scenario on OMAP currently is OMAP4 with
two DSI displays.

> Do you want me to try to address this in this initial submission, or
> is it something we can revisit in a subsequent "fix-it" patch for all
> panels with SPI init?

If you have extra time and a good solution, then of course I want you to
address it =). But most likely we'll just revisit it later. It's not
critical now and we may also have to look at how DSS manages the panel
drivers.

 Tomi