* [PATCH] cbus-retu-wdt: Constify watchdog_info structure
@ 2011-03-04 15:33 Michael Buesch
2011-03-07 7:39 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: Michael Buesch @ 2011-03-04 15:33 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Felipe Balbi, linux-omap
Nobody modifies the watchdog_info structure, so make it const.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
---
Index: linux-2.6.38-rc6/drivers/cbus/retu-wdt.c
===================================================================
--- linux-2.6.38-rc6.orig/drivers/cbus/retu-wdt.c 2011-03-04 16:21:39.106113985 +0100
+++ linux-2.6.38-rc6/drivers/cbus/retu-wdt.c 2011-03-04 16:21:48.503540758 +0100
@@ -149,7 +149,7 @@ static long retu_wdt_ioctl(struct file *
struct retu_wdt_dev *wdev = container_of(mdev, struct retu_wdt_dev, miscdev);
int new_margin;
- static struct watchdog_info ident = {
+ static const struct watchdog_info ident = {
.identity = "Retu Watchdog",
.options = WDIOF_SETTIMEOUT,
.firmware_version = 0,
--
Greetings, Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cbus-retu-wdt: Constify watchdog_info structure
2011-03-04 15:33 [PATCH] cbus-retu-wdt: Constify watchdog_info structure Michael Buesch
@ 2011-03-07 7:39 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2011-03-07 7:39 UTC (permalink / raw)
To: Michael Buesch; +Cc: Tony Lindgren, Felipe Balbi, linux-omap
On Fri, Mar 04, 2011 at 04:33:27PM +0100, Michael Buesch wrote:
> Nobody modifies the watchdog_info structure, so make it const.
>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
Acked-by: Felipe Balbi <balbi@ti.com>
--
balbi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-07 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-04 15:33 [PATCH] cbus-retu-wdt: Constify watchdog_info structure Michael Buesch
2011-03-07 7:39 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox