* [PATCH RFC] n810 USB: Initialize USB-FS
@ 2011-03-09 18:20 Michael Buesch
2011-03-16 21:55 ` Michael Büsch
0 siblings, 1 reply; 2+ messages in thread
From: Michael Buesch @ 2011-03-09 18:20 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Felipe Balbi, linux-omap
The "omap_otg" platform device has to be registered in order
to get USB working on the n810.
I currently do this by calling the USB-FS init, which in turn
registers the omap_otg platform device.
The omap_usb_config structure values were copied from n770 code, so
I have no idea whether this is correct or not.
However, with all the patches I just sent (including this one),
I get USB working properly on the n810.
Not-yet-signed-off-by: Michael Buesch <mb@bu3sch.de>
---
Index: linux-2.6.38-rc7/arch/arm/mach-omap2/board-n8x0.c
===================================================================
--- linux-2.6.38-rc7.orig/arch/arm/mach-omap2/board-n8x0.c 2011-03-09 18:47:07.749508720 +0100
+++ linux-2.6.38-rc7/arch/arm/mach-omap2/board-n8x0.c 2011-03-09 18:59:14.355835051 +0100
@@ -40,6 +40,7 @@
#include <plat/serial.h>
#include <plat/cbus.h>
#include <plat/gpio-switch.h>
+#include <plat/usb.h>
#include "mux.h"
@@ -395,6 +396,14 @@ static struct musb_hdrc_platform_data tu
.config = &musb_config,
};
+static struct omap_usb_config n8x0_omap_usb_config __initdata = {
+ .otg = 1,
+ .register_host = 1,
+ .register_dev = 1,
+ .hmc_mode = 16,
+ .pins[0] = 6,
+};
+
static void __init n8x0_usb_init(void)
{
int ret = 0;
@@ -417,6 +426,8 @@ static void __init n8x0_usb_init(void)
if (ret != 0)
goto err;
+ omap2_usbfs_init(&n8x0_omap_usb_config);
+
printk(announce);
return;
--
Greetings, Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH RFC] n810 USB: Initialize USB-FS
2011-03-09 18:20 [PATCH RFC] n810 USB: Initialize USB-FS Michael Buesch
@ 2011-03-16 21:55 ` Michael Büsch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Büsch @ 2011-03-16 21:55 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Felipe Balbi, linux-omap
On Wed, 2011-03-09 at 19:20 +0100, Michael Buesch wrote:
> The "omap_otg" platform device has to be registered in order
> to get USB working on the n810.
> I currently do this by calling the USB-FS init, which in turn
> registers the omap_otg platform device.
>
> The omap_usb_config structure values were copied from n770 code, so
> I have no idea whether this is correct or not.
>
> However, with all the patches I just sent (including this one),
> I get USB working properly on the n810.
>
> Not-yet-signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> ---
>
> Index: linux-2.6.38-rc7/arch/arm/mach-omap2/board-n8x0.c
> ===================================================================
> --- linux-2.6.38-rc7.orig/arch/arm/mach-omap2/board-n8x0.c 2011-03-09 18:47:07.749508720 +0100
> +++ linux-2.6.38-rc7/arch/arm/mach-omap2/board-n8x0.c 2011-03-09 18:59:14.355835051 +0100
> @@ -40,6 +40,7 @@
> #include <plat/serial.h>
> #include <plat/cbus.h>
> #include <plat/gpio-switch.h>
> +#include <plat/usb.h>
>
> #include "mux.h"
>
> @@ -395,6 +396,14 @@ static struct musb_hdrc_platform_data tu
> .config = &musb_config,
> };
>
> +static struct omap_usb_config n8x0_omap_usb_config __initdata = {
> + .otg = 1,
> + .register_host = 1,
> + .register_dev = 1,
> + .hmc_mode = 16,
> + .pins[0] = 6,
> +};
> +
> static void __init n8x0_usb_init(void)
> {
> int ret = 0;
> @@ -417,6 +426,8 @@ static void __init n8x0_usb_init(void)
> if (ret != 0)
> goto err;
>
> + omap2_usbfs_init(&n8x0_omap_usb_config);
> +
> printk(announce);
>
> return;
>
Is there any news on this one?
If not, I'd suggest merging this in its current form, even if
we're unsure whether it's 100% correct, because it actually
makes the USB work on the n810.
If you merge this, you can add a
Signed-off-by: Michael Buesch <mb@bu3sch.de>
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-16 21:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-09 18:20 [PATCH RFC] n810 USB: Initialize USB-FS Michael Buesch
2011-03-16 21:55 ` Michael Büsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox