* [PATCH 09/11] video: Remove redundant spi driver bus initialization [not found] <1322148561-25138-1-git-send-email-lars@metafoo.de> @ 2011-11-24 15:29 ` Lars-Peter Clausen 2011-11-29 10:19 ` Tomi Valkeinen 2011-12-04 0:36 ` Florian Tobias Schandinat 0 siblings, 2 replies; 3+ messages in thread From: Lars-Peter Clausen @ 2011-11-24 15:29 UTC (permalink / raw) To: linux-kernel Cc: Lars-Peter Clausen, Tomi Valkeinen, Florian Tobias Schandinat, linux-fbdev, linux-omap In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_driver_register(), so we can drop the manual assignment. The patch was generated using the following coccinelle semantic patch: // <smpl> @@ identifier _driver; @@ struct spi_driver _driver = { .driver = { - .bus = &spi_bus_type, }, }; // </smpl> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> Cc: linux-fbdev@vger.kernel.org Cc: linux-omap@vger.kernel.org --- drivers/video/omap/lcd_mipid.c | 1 - drivers/video/omap2/displays/panel-acx565akm.c | 1 - drivers/video/omap2/displays/panel-n8x0.c | 1 - .../omap2/displays/panel-nec-nl8048hl11-01b.c | 1 - .../video/omap2/displays/panel-tpo-td043mtea1.c | 1 - 5 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/video/omap/lcd_mipid.c b/drivers/video/omap/lcd_mipid.c index eb381db..8d546dd 100644 --- a/drivers/video/omap/lcd_mipid.c +++ b/drivers/video/omap/lcd_mipid.c @@ -603,7 +603,6 @@ static int mipid_spi_remove(struct spi_device *spi) static struct spi_driver mipid_spi_driver = { .driver = { .name = MIPID_MODULE_NAME, - .bus = &spi_bus_type, .owner = THIS_MODULE, }, .probe = mipid_spi_probe, diff --git a/drivers/video/omap2/displays/panel-acx565akm.c b/drivers/video/omap2/displays/panel-acx565akm.c index dbd59b8..51a87e1 100644 --- a/drivers/video/omap2/displays/panel-acx565akm.c +++ b/drivers/video/omap2/displays/panel-acx565akm.c @@ -803,7 +803,6 @@ static int acx565akm_spi_remove(struct spi_device *spi) static struct spi_driver acx565akm_spi_driver = { .driver = { .name = "acx565akm", - .bus = &spi_bus_type, .owner = THIS_MODULE, }, .probe = acx565akm_spi_probe, diff --git a/drivers/video/omap2/displays/panel-n8x0.c b/drivers/video/omap2/displays/panel-n8x0.c index 150e8ba..dc9408d 100644 --- a/drivers/video/omap2/displays/panel-n8x0.c +++ b/drivers/video/omap2/displays/panel-n8x0.c @@ -708,7 +708,6 @@ static int mipid_spi_remove(struct spi_device *spi) static struct spi_driver mipid_spi_driver = { .driver = { .name = "lcd_mipid", - .bus = &spi_bus_type, .owner = THIS_MODULE, }, .probe = mipid_spi_probe, diff --git a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c index 2ba9d0c..8365e77 100644 --- a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c +++ b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c @@ -303,7 +303,6 @@ static struct spi_driver nec_8048_spi_driver = { .resume = nec_8048_spi_resume, .driver = { .name = "nec_8048_spi", - .bus = &spi_bus_type, .owner = THIS_MODULE, }, }; diff --git a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c index 2462b9e..e6649aa 100644 --- a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c +++ b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c @@ -512,7 +512,6 @@ static int __devexit tpo_td043_spi_remove(struct spi_device *spi) static struct spi_driver tpo_td043_spi_driver = { .driver = { .name = "tpo_td043mtea1_panel_spi", - .bus = &spi_bus_type, .owner = THIS_MODULE, }, .probe = tpo_td043_spi_probe, -- 1.7.7.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 09/11] video: Remove redundant spi driver bus initialization 2011-11-24 15:29 ` [PATCH 09/11] video: Remove redundant spi driver bus initialization Lars-Peter Clausen @ 2011-11-29 10:19 ` Tomi Valkeinen 2011-12-04 0:36 ` Florian Tobias Schandinat 1 sibling, 0 replies; 3+ messages in thread From: Tomi Valkeinen @ 2011-11-29 10:19 UTC (permalink / raw) To: Lars-Peter Clausen Cc: linux-kernel, Florian Tobias Schandinat, linux-fbdev, linux-omap [-- Attachment #1: Type: text/plain, Size: 791 bytes --] On Thu, 2011-11-24 at 16:29 +0100, Lars-Peter Clausen wrote: > In ancient times it was necessary to manually initialize the bus field of an > spi_driver to spi_bus_type. These days this is done in spi_driver_register(), > so we can drop the manual assignment. > > The patch was generated using the following coccinelle semantic patch: > // <smpl> > @@ > identifier _driver; > @@ > struct spi_driver _driver = { > .driver = { > - .bus = &spi_bus_type, > }, > }; > // </smpl> > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> > Cc: linux-fbdev@vger.kernel.org > Cc: linux-omap@vger.kernel.org Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Tomi [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 09/11] video: Remove redundant spi driver bus initialization 2011-11-24 15:29 ` [PATCH 09/11] video: Remove redundant spi driver bus initialization Lars-Peter Clausen 2011-11-29 10:19 ` Tomi Valkeinen @ 2011-12-04 0:36 ` Florian Tobias Schandinat 1 sibling, 0 replies; 3+ messages in thread From: Florian Tobias Schandinat @ 2011-12-04 0:36 UTC (permalink / raw) To: Lars-Peter Clausen; +Cc: linux-kernel, Tomi Valkeinen, linux-fbdev, linux-omap On 11/24/2011 03:29 PM, Lars-Peter Clausen wrote: > In ancient times it was necessary to manually initialize the bus field of an > spi_driver to spi_bus_type. These days this is done in spi_driver_register(), > so we can drop the manual assignment. > > The patch was generated using the following coccinelle semantic patch: > // <smpl> > @@ > identifier _driver; > @@ > struct spi_driver _driver = { > .driver = { > - .bus = &spi_bus_type, > }, > }; > // </smpl> > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> > Cc: linux-fbdev@vger.kernel.org > Cc: linux-omap@vger.kernel.org Applied this patch. Thanks, Florian Tobias Schandinat > --- > drivers/video/omap/lcd_mipid.c | 1 - > drivers/video/omap2/displays/panel-acx565akm.c | 1 - > drivers/video/omap2/displays/panel-n8x0.c | 1 - > .../omap2/displays/panel-nec-nl8048hl11-01b.c | 1 - > .../video/omap2/displays/panel-tpo-td043mtea1.c | 1 - > 5 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/drivers/video/omap/lcd_mipid.c b/drivers/video/omap/lcd_mipid.c > index eb381db..8d546dd 100644 > --- a/drivers/video/omap/lcd_mipid.c > +++ b/drivers/video/omap/lcd_mipid.c > @@ -603,7 +603,6 @@ static int mipid_spi_remove(struct spi_device *spi) > static struct spi_driver mipid_spi_driver = { > .driver = { > .name = MIPID_MODULE_NAME, > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > }, > .probe = mipid_spi_probe, > diff --git a/drivers/video/omap2/displays/panel-acx565akm.c b/drivers/video/omap2/displays/panel-acx565akm.c > index dbd59b8..51a87e1 100644 > --- a/drivers/video/omap2/displays/panel-acx565akm.c > +++ b/drivers/video/omap2/displays/panel-acx565akm.c > @@ -803,7 +803,6 @@ static int acx565akm_spi_remove(struct spi_device *spi) > static struct spi_driver acx565akm_spi_driver = { > .driver = { > .name = "acx565akm", > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > }, > .probe = acx565akm_spi_probe, > diff --git a/drivers/video/omap2/displays/panel-n8x0.c b/drivers/video/omap2/displays/panel-n8x0.c > index 150e8ba..dc9408d 100644 > --- a/drivers/video/omap2/displays/panel-n8x0.c > +++ b/drivers/video/omap2/displays/panel-n8x0.c > @@ -708,7 +708,6 @@ static int mipid_spi_remove(struct spi_device *spi) > static struct spi_driver mipid_spi_driver = { > .driver = { > .name = "lcd_mipid", > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > }, > .probe = mipid_spi_probe, > diff --git a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c > index 2ba9d0c..8365e77 100644 > --- a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c > +++ b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c > @@ -303,7 +303,6 @@ static struct spi_driver nec_8048_spi_driver = { > .resume = nec_8048_spi_resume, > .driver = { > .name = "nec_8048_spi", > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > }, > }; > diff --git a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c > index 2462b9e..e6649aa 100644 > --- a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c > +++ b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c > @@ -512,7 +512,6 @@ static int __devexit tpo_td043_spi_remove(struct spi_device *spi) > static struct spi_driver tpo_td043_spi_driver = { > .driver = { > .name = "tpo_td043mtea1_panel_spi", > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > }, > .probe = tpo_td043_spi_probe, ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-04 0:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1322148561-25138-1-git-send-email-lars@metafoo.de>
2011-11-24 15:29 ` [PATCH 09/11] video: Remove redundant spi driver bus initialization Lars-Peter Clausen
2011-11-29 10:19 ` Tomi Valkeinen
2011-12-04 0:36 ` Florian Tobias Schandinat
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox