Re: [PATCHv4 04/15] omap4: add pmic startup / shutdown times

[Tero Kristo <t-kristo@ti.com>]

On Wed, 2011-11-30 at 06:20 -0600, Menon, Nishanth wrote:
> On Wed, Nov 30, 2011 at 03:45, Tero Kristo <t-kristo@ti.com> wrote:
> >
> > On Tue, 2011-11-29 at 12:30 -0600, Menon, Nishanth wrote:
> > > On Fri, Nov 25, 2011 at 09:49, Tero Kristo <t-kristo@ti.com> wrote:
> > > > Both startup and shutdown take 500us at maximum, value taken from
> > > > TWL6030 data manual.
> Might be good to add reference version as well for traceability.

Good point.

> 
> > > >
> > > > Signed-off-by: Tero Kristo <t-kristo@ti.com>
> > > > ---
> > > >  arch/arm/mach-omap2/omap_twl.c |    2 ++
> > > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > > >
> > > > diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach-omap2/omap_twl.c
> > > > index 62ed050..bd99328 100644
> > > > --- a/arch/arm/mach-omap2/omap_twl.c
> > > > +++ b/arch/arm/mach-omap2/omap_twl.c
> > > > @@ -207,6 +207,8 @@ static struct omap_voltdm_pmic omap4_iva_pmic = {
> > > >  static struct omap_voltdm_pmic omap4_core_pmic = {
> > > >        .slew_rate              = 4000,
> > > >        .step_size              = 12660,
> > > > +       .startup_time           = 500,
> > > 549?
> >
> > Where do you get 549? You looking at a different version of the DM? Or
> > are you adding something to the value?
> >
> woohoo.. welcome to TWL6030 doc hell ;)
> Data Sheet: 0.05: T on =500Usec
> *but* TRM 0.1 says T on = 500uSec for SMPS  not freq locked, and upto
> 3ms with SMPS frequency locked).
> *then* Functional spec rev 0.12 says "Enable VCORE[1,2,3] = 549uSec.

Oh yea, thats great. Well, lets see what the design team says what we
should actually use. :)

-Tero