Re: [PATCHv4 10/15] omap: beagle: set oscillator startup time to 10ms for rev c4

[Tero Kristo <t-kristo@ti.com>]

On Fri, 2011-12-09 at 11:11 -0800, Kevin Hilman wrote:
> Tero Kristo <t-kristo@ti.com> writes:
> 
> > Based on the oscillator datasheet for this device.
> >
> > Signed-off-by: Tero Kristo <t-kristo@ti.com>
> > ---
> >  arch/arm/mach-omap2/board-omap3beagle.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> > index a7c3d60..5e3f575 100644
> > --- a/arch/arm/mach-omap2/board-omap3beagle.c
> > +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> > @@ -516,6 +516,9 @@ static void __init beagle_opp_init(void)
> >  			opp_disable(mpu_dev, 720000000);
> >  			opp_disable(iva_dev, 520000000);
> >  		}
> > +
> > +		/* Setup oscillator startup time to 10ms */
> > +		omap_pm_setup_oscillator(10000, 0);
> >  	}
> 
> ...but shutdown time is probably not zero. :)
> 
> This should probably be -1, or ULONG_MAX.
> 
> Yes, I see that tshut isn't even used on OMAP3, so it doesn't matter,
> but it does help readability IMO.

Exactly the reason it was set as zero... I'll think of something for the
next rev for this. Maybe use -1 as you suggested (and add a comment), it
is not going to break anything.

-Tero