linux-next problems

linux-next problems

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 3507 bytes --]

Hi,

I was trying to compile linux-next for OMAP, but it doesn't compile with
the default configs.

drivers/remoteproc/remoteproc_rpmsg.c: In function 'rp_find_vq':
drivers/remoteproc/remoteproc_rpmsg.c:100:6: warning: passing argument 7 of 'vring_new_virtqueue' from incompatible pointer type
include/linux/virtio_ring.h:168:19: note: expected 'void (*)(struct virtqueue *)' but argument is of type 'const char *'
drivers/remoteproc/remoteproc_rpmsg.c:100:6: error: too few arguments to function 'vring_new_virtqueue'
include/linux/virtio_ring.h:168:19: note: declared here
make[2]: *** [drivers/remoteproc/remoteproc_rpmsg.o] Error 1

and

arch/arm/mach-omap2/prm_common.c:27:25: fatal error: mach/system.h: No such file or directory
compilation terminated.

Fixing those, I was able to boot Blaze, but I saw this:

[    2.296905] mmc0: new high speed MMC card at address 0001
[    2.304199] mmcblk0: mmc0:0001 SEM08G 7.39 GiB 
[    2.309326] mmcblk0boot0: mmc0:0001 SEM08G partition 1 1.00 MiB
[    2.315826] mmcblk0boot1: mmc0:0001 SEM08G partition 2 1.00 MiB
[    2.329925]  mmcblk0: unknown partition table
[    2.338195]  mmcblk0boot1: unknown partition table
[    2.343811] BUG: key de7aeef4 not in .data!
[    2.343811] ------------[ cut here ]------------
[    2.353057] WARNING: at kernel/lockdep.c:2986 sysfs_add_file_mode+0x84/0xe8()
[    2.360534] Modules linked in:
[    2.363800] [<c001b634>] (unwind_backtrace+0x0/0xf0) from [<c00424ec>] (warn_slowpath_common+0x4c
/0x64)
[    2.373657] [<c00424ec>] (warn_slowpath_common+0x4c/0x64) from [<c0042520>] (warn_slowpath_null+0
x1c/0x24)
[    2.383789] [<c0042520>] (warn_slowpath_null+0x1c/0x24) from [<c0167128>] (sysfs_add_file_mode+0x
84/0xe8)
[    2.393829] [<c0167128>] (sysfs_add_file_mode+0x84/0xe8) from [<c0391234>] (mmc_add_disk+0xb4/0x1
00)
[    2.403442] [<c0391234>] (mmc_add_disk+0xb4/0x100) from [<c03918b0>] (mmc_blk_probe+0x27c/0x2c8)
[    2.412658] [<c03918b0>] (mmc_blk_probe+0x27c/0x2c8) from [<c03855d4>] (mmc_bus_probe+0x18/0x1c)
[    2.421874] [<c03855d4>] (mmc_bus_probe+0x18/0x1c) from [<c02af6d8>] (driver_probe_device+0x98/0x
1a0)
[    2.431579] [<c02af6d8>] (driver_probe_device+0x98/0x1a0) from [<c02adfd0>] (bus_for_each_drv+0x5
c/0x88)
[    2.441528] [<c02adfd0>] (bus_for_each_drv+0x5c/0x88) from [<c02af570>] (device_attach+0x98/0xbc)
[    2.450836] [<c02af570>] (device_attach+0x98/0xbc) from [<c02aedac>] (bus_probe_device+0x88/0xac)
[    2.450836] [<c02aedac>] (bus_probe_device+0x88/0xac) from [<c02ad0cc>] (device_add+0x538/0x60c)
[    2.469360] [<c02ad0cc>] (device_add+0x538/0x60c) from [<c038591c>] (mmc_add_card+0xb8/0x1bc)
[    2.469360] [<c038591c>] (mmc_add_card+0xb8/0x1bc) from [<c0387ff0>] (mmc_attach_mmc+0xdc/0x1d0)
[    2.487518] [<c0387ff0>] (mmc_attach_mmc+0xdc/0x1d0) from [<c0385118>] (mmc_rescan+0x230/0x45c)
[    2.496612] [<c0385118>] (mmc_rescan+0x230/0x45c) from [<c005b444>] (process_one_work+0x18c/0x4e4
)
[    2.506042] [<c005b444>] (process_one_work+0x18c/0x4e4) from [<c005df9c>] (worker_thread+0x174/0x
378)
[    2.513153] [<c005df9c>] (worker_thread+0x174/0x378) from [<c0062ac8>] (kthread+0x90/0x9c)
[    2.520935] [<c0062ac8>] (kthread+0x90/0x9c) from [<c0014e04>] (kernel_thread_exit+0x0/0x8)
[    2.533172] ---[ end trace 27dad9159f211429 ]---

On OMAP3 Overo, I didn't get any errors, but the console (usb one) was
very unresponsive, impossible to use. Ssh terminal to the device worked
fine, though.

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next problems

[Ohad Ben-Cohen]

+ Stephen

Thanks, Tomi.

On Thu, Jan 12, 2012 at 5:38 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> I was trying to compile linux-next for OMAP, but it doesn't compile with
> the default configs.
...
> drivers/remoteproc/remoteproc_rpmsg.c:100:6: error: too few arguments to function 'vring_new_virtqueue'

This is due to a recent change in virtio.

Stephen, I guess this won't be relevant for more than a few days, but
can you please take this patch below to linux-next ?
(alternatively feel free just to squash this to the merge commit.
whatever is easiest for you.)

Thanks!
Ohad.

>From 305aefa86e84a161f2535e4302eaf8b2338eeff8 Mon Sep 17 00:00:00 2001
From: Ohad Ben-Cohen <ohad@wizery.com>
Date: Thu, 12 Jan 2012 09:26:57 +0200
Subject: [PATCH] remoteproc: don't use virtio's weak barriers

When creating a virtqueue for rpmsg, tell virtio we're not interested
in "weak" smp barriers, since we're talking to a real device.

On ARM, this means using a DSB instead of a DMB, which is needed
for platforms that kick the remote processor using some kind of
a mailbox device mapped to Device memory (otherwise the kick can
jump ahead and wake the remote processor before it has observed
the changes to the vrings).

Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
---
 drivers/remoteproc/remoteproc_rpmsg.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_rpmsg.c
b/drivers/remoteproc/remoteproc_rpmsg.c
index f30be4c..4f73e81 100644
--- a/drivers/remoteproc/remoteproc_rpmsg.c
+++ b/drivers/remoteproc/remoteproc_rpmsg.c
@@ -96,7 +96,11 @@ static struct virtqueue *rp_find_vq(struct
virtio_device *vdev,

 	dev_dbg(rproc->dev, "vring%d: va %p qsz %d\n", id, addr, len);

-	vq = vring_new_virtqueue(len, AMP_VRING_ALIGN, vdev, addr,
+	/*
+	 * Create the new vq, and tell virtio we're not interested in
+	 * the 'weak' smp barriers, since we're talking with a real device.
+	 */
+	vq = vring_new_virtqueue(len, AMP_VRING_ALIGN, vdev, false, addr,
 					rproc_virtio_notify, callback, name);
 	if (!vq) {
 		dev_err(rproc->dev, "vring_new_virtqueue %s failed\n", name);
-- 
1.7.5.4

Re: linux-next problems

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

On Thu, 2012-01-12 at 17:58 +0200, Ohad Ben-Cohen wrote:
> + Stephen
> 
> Thanks, Tomi.
> 
> On Thu, Jan 12, 2012 at 5:38 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> > I was trying to compile linux-next for OMAP, but it doesn't compile with
> > the default configs.
> ...
> > drivers/remoteproc/remoteproc_rpmsg.c:100:6: error: too few arguments to function 'vring_new_virtqueue'
> 
> This is due to a recent change in virtio.
> 
> Stephen, I guess this won't be relevant for more than a few days, but
> can you please take this patch below to linux-next ?
> (alternatively feel free just to squash this to the merge commit.
> whatever is easiest for you.)

Why don't you just update your for-next branch, and it will be included
into linux-next automatically?

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next problems

[Ohad Ben-Cohen]

On Thu, Jan 12, 2012 at 6:05 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> Why don't you just update your for-next branch, and it will be included
> into linux-next automatically?

I need to merge Rusty's branch into my for-next branch in order to do that.

I could do that, but the downside is that my pull request will include
Rusty's history.

Not a big deal, but I slightly prefer to avoid it if possible.

Ohad.