From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: NeilBrown <neilb@suse.de>, Jean Pihet <jean.pihet@newoldbits.com>,
Govindraj <govindraj.ti@gmail.com>, Kevin Hilman <khilman@ti.com>,
t-kristo@ti.com,
linux-omap mailing list <linux-omap@vger.kernel.org>,
Joe Woodward <jw@terrafix.co.uk>
Subject: Re: PM(?) problems on v3.3-rc1 on OMAP3
Date: Mon, 23 Jan 2012 12:48:36 +0200 [thread overview]
Message-ID: <1327315716.1916.34.camel@deskari> (raw)
In-Reply-To: <alpine.DEB.2.00.1201230229220.29673@utopia.booyaka.com>
[-- Attachment #1: Type: text/plain, Size: 1477 bytes --]
On Mon, 2012-01-23 at 02:31 -0700, Paul Walmsley wrote:
> On Mon, 23 Jan 2012, Tomi Valkeinen wrote:
>
> > On Mon, 2012-01-23 at 02:04 -0700, Paul Walmsley wrote:
> > > On Mon, 23 Jan 2012, Tomi Valkeinen wrote:
> > >
> > > > Then I noticed that the DISPC's ENWAKEUP is not set. Setting ENWAKEUP
> > > > (with SIDLEMODE/IDLEMODE in smart mode) also removes the problem.
> > >
> > > Sounds like you've nailed it.
> > >
> > > What is perplexing is that the hwmod code should be setting this by
> > > default in omap_hwmod.c:_enable_sysc(). I wonder why that is not
> > > happening.
> >
> > It seems the omap2_dispc_sysc is missing SYSC_HAS_ENAWAKEUP. I wonder if
> > that's a mistake or by purpose...
>
> That's almost certainly a mistake. It's documented in the 34xx vZR TRM
> and so far I don't know of any reason for omitting any of those bits.
>
> I just searched my linux-omap folder for the original patch for this. It
> seems to be
>
> Date: Mon, 3 Jan 2011 18:20:53 +0530
> From: Guruswamy Senthilvadivu <svadivu@ti.com>
> Subject: [PATCH v3 01/17] OMAP2420: hwmod data: add DSS DISPC RFBI VENC
>
> and it was missing in that patch. Guess I missed it when I reviewed this
> patch. Sigh...
>
> Want to spin a quick patch for v3.3-rc1 to add it?
I think there are other bits missing also. CLOCKACTIVITY is missing for
DISPC. And DSI doesn't have any SYSC flags defined... I'll try to go
through them all.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-23 10:48 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 10:33 PM(?) problems on v3.3-rc1 on OMAP3 Tomi Valkeinen
2012-01-20 10:49 ` Govindraj
2012-01-20 11:07 ` Tomi Valkeinen
2012-01-20 11:21 ` Govindraj
2012-01-20 12:32 ` Jean Pihet
2012-01-20 12:44 ` Govindraj
2012-01-21 7:39 ` Paul Walmsley
2012-01-21 7:38 ` Paul Walmsley
2012-01-20 11:56 ` Govindraj
2012-01-20 12:01 ` Tomi Valkeinen
2012-01-20 12:34 ` Jean Pihet
2012-01-20 12:40 ` Tomi Valkeinen
2012-01-20 13:36 ` Jean Pihet
2012-01-20 15:00 ` Tomi Valkeinen
2012-01-22 11:11 ` NeilBrown
2012-01-23 8:53 ` Tomi Valkeinen
2012-01-23 9:04 ` Paul Walmsley
2012-01-23 9:24 ` Tomi Valkeinen
2012-01-23 9:31 ` Paul Walmsley
2012-01-23 10:48 ` Tomi Valkeinen [this message]
2012-01-23 11:02 ` Paul Walmsley
2012-01-23 11:06 ` Tomi Valkeinen
2012-01-24 10:39 ` Tomi Valkeinen
2012-01-20 12:45 ` Govindraj
2012-01-20 12:47 ` Shubhrajyoti
2012-01-21 7:35 ` Paul Walmsley
2012-01-21 7:47 ` Paul Walmsley
2012-01-21 15:57 ` Tomi Valkeinen
2012-01-21 20:46 ` NeilBrown
2012-01-23 8:25 ` Tomi Valkeinen
2012-01-21 20:47 ` Paul Walmsley
2012-01-22 11:11 ` Valkeinen, Tomi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327315716.1916.34.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=govindraj.ti@gmail.com \
--cc=jean.pihet@newoldbits.com \
--cc=jw@terrafix.co.uk \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=neilb@suse.de \
--cc=paul@pwsan.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox