From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Ricardo Neri <ricardo.neri@ti.com>
Cc: mythripk@ti.com, a0393947@ti.com, molnar@ti.com,
s-guiriec@ti.com, lrg@ti.com, peter.ujfalusi@ti.com,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 0/3] OMAPDSS: HDMI: Add support for audio MCLK
Date: Tue, 14 Feb 2012 14:27:59 +0200 [thread overview]
Message-ID: <1329222479.1845.86.camel@deskari> (raw)
In-Reply-To: <1328757023-20543-1-git-send-email-ricardo.neri@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]
Hi,
On Wed, 2012-02-08 at 21:10 -0600, Ricardo Neri wrote:
> Hello,
>
> Certain OMAP4 revisions (i.e., 4430 ES2.3, 4460, and 4470) use
> a pseudo clock (generated from the TMDS clock), MCLK, to drive the
> generation of Audio Clock Regeneration packets. Other devices
> (i.e., 4430 ES2.[0,2]) use the TMDS clock directly.
>
> This set of patches introduces functionality to enable the MCLK on the
> relevant devices. Such clock is added as new DSS feature. The dss_features
> structures are rearranged to reflect the MCLK support across several
> silicon revisions.
>
> These patches have been validated on OMAP 4430 ES2.2 and ES2.3 as well as
> on 4460 ES1.0. The HDMI sinks used for validation are monitor Dell ST2210b,
> AV receiver Onkyo TX-SR508 and AV receiver Yamaha RX-V367. Audio playback
> is functional in all of them.
One question just to be sure: are you sure this clocking difference is
based on OMAP revision, and has nothing to do with the board?
I think this looks fine. However, it doesn't apply as the dss feat stuff
has been changed. Could you rebase the patches on top of
git://gitorious.org/linux-omap-dss2/linux.git dev
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-14 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 3:10 [PATCH 0/3] OMAPDSS: HDMI: Add support for audio MCLK Ricardo Neri
2012-02-09 3:10 ` [PATCH 1/3] OMAPDSS: Add DSS feature for HDMI MCLK for audio Ricardo Neri
2012-02-09 3:10 ` [PATCH 2/3] OMAPDSS: HDMI: Implement initialization of MCLK Ricardo Neri
2012-02-09 3:10 ` [PATCH 3/3] OMAPDSS: HDMI: Modify logic to configure MCLK Ricardo Neri
2012-02-14 12:27 ` Tomi Valkeinen [this message]
2012-02-16 2:58 ` [PATCH 0/3] OMAPDSS: HDMI: Add support for audio MCLK Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329222479.1845.86.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=a0393947@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=molnar@ti.com \
--cc=mythripk@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=ricardo.neri@ti.com \
--cc=s-guiriec@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox