From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Raphaël Assénat" <raph@8d.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAPDSS: Add timings for ChiMei G121S1-L01/L02 and G121X1-L01 LCD displays
Date: Tue, 21 Aug 2012 13:49:49 +0300 [thread overview]
Message-ID: <1345546189.4085.52.camel@deskari> (raw)
In-Reply-To: <502BBFBB.6090303@8d.com>
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
On Wed, 2012-08-15 at 11:26 -0400, Raphaël Assénat wrote:
> > +
> > + /* ChiMei G121S1-L01 */
> > + {
> > + {
>
> ...
>
> > + .vsync_level = OMAPDSS_SIG_ACTIVE_HIGH,
> > + .hsync_level = OMAPDSS_SIG_ACTIVE_HIGH,
> > + .data_pclk_edge = OMAPDSS_DRIVE_SIG_RISING_EDGE,
> > + .de_level = OMAPDSS_SIG_ACTIVE_HIGH,
> > + .sync_pclk_edge = OMAPDSS_DRIVE_SIG_OPPOSITE_EDGES,
>
> Actually those 3 panels only use the DE signal. The hsync/vsync signals
> are not used and on our system we mux them out to make sure they are
> kept low as recommended in the panel datasheets.
>
> Since vsync/hsync are not used, I think the vsync_level, hsync_level and
> sync_pclk_edge entries could be removed. Otherwise the updated patch
> works fine as is.
Okay. How do panels like that work? How can they know where a new frame
starts?
Actually, I now googled for those panels, and they are all LVDS panels,
not DPI panels. So the patch doesn't look correct at all.
Do you have a DPI-to-LVDS converter chip on your board?
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-21 10:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 14:01 [PATCH] OMAPDSS: Add timings for ChiMei G121S1-L01/L02 and G121X1-L01 LCD displays Raphael Assenat
2012-07-17 16:27 ` Jassi Brar
2012-07-20 8:11 ` Archit Taneja
2012-07-20 12:13 ` Jassi Brar
2012-07-20 12:44 ` Archit Taneja
2012-07-20 15:38 ` Jassi Brar
2012-07-31 7:51 ` Tomi Valkeinen
2012-07-31 8:03 ` Jassi Brar
2012-07-31 8:14 ` Tomi Valkeinen
2012-07-31 8:27 ` Jassi Brar
2012-07-31 8:42 ` Tomi Valkeinen
2012-07-31 8:57 ` Jassi Brar
2012-07-31 9:57 ` Tomi Valkeinen
2012-07-31 18:14 ` Jassi Brar
2012-08-15 9:31 ` Tomi Valkeinen
2012-08-15 15:26 ` Raphaël Assénat
2012-08-21 10:49 ` Tomi Valkeinen [this message]
2012-08-21 14:29 ` Raphaël Assénat
2012-08-24 8:38 ` Tomi Valkeinen
2012-08-24 13:50 ` Raphaël Assénat
2012-08-24 15:00 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345546189.4085.52.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=raph@8d.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox