Initialising omapfb on AM3517 issues

Initialising omapfb on AM3517 issues

[Marc Murphy]

Hello all,
I have been moving from the ti 2.6.37 BSP to the 3.x kernel with quite a bit of success, the main issue I have at the moment is trying to get the frame buffer and any displays I have initialised.

[    2.805358] omapfb omapfb: no driver for display: lcd
[    2.810729] omapfb omapfb: no displays
[    2.814666] omapfb omapfb: failed to setup omapfb

I have tried a few versions of release and none of them will initialise;

Currently on
[    0.000000] Linux version 3.6.0-rc3

I have started with board-am3517evm display config and even that doesn't initialise.  Is there something I am missing with the configs or is there a patch required to get the feature to work.

My current config options use;
#
# Graphics support
#
CONFIG_DRM=y
CONFIG_FB=y
CONFIG_FB_CFB_FILLRECT=y
CONFIG_FB_CFB_COPYAREA=y
CONFIG_FB_CFB_IMAGEBLIT=y

#
# Frame buffer hardware drivers
#
CONFIG_OMAP2_VRAM=y
CONFIG_OMAP2_VRFB=y
CONFIG_OMAP2_DSS=y
CONFIG_OMAP2_VRAM_SIZE=12
CONFIG_OMAP2_DSS_DPI=y
CONFIG_OMAP2_DSS_VENC=y
CONFIG_OMAP2_DSS_DSI=y
CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK=1
CONFIG_OMAP2_DSS_SLEEP_AFTER_VENC_RESET=y
CONFIG_FB_OMAP2=y
CONFIG_FB_OMAP2_NUM_FBS=3

#
# OMAP2/3 Display Device Drivers
#
CONFIG_PANEL_GENERIC_DPI=y
CONFIG_PANEL_SHARP_LS037V7DW01=y
CONFIG_BACKLIGHT_LCD_SUPPORT=y
CONFIG_LCD_CLASS_DEVICE=y
CONFIG_BACKLIGHT_CLASS_DEVICE=y
CONFIG_BACKLIGHT_GENERIC=y

And the init structs are
static int am3517_evm_panel_enable_lcd(struct omap_dss_device *dssdev)
{
    gpio_set_value(TAM3517_DVI_PON_GPIO, 0);
    gpio_set_value(TAM3517_LCD_ENVDD_GPIO, 0);
    gpio_set_value(TAM3517_LCD_PON_GPIO, 1);
        printk("LCD voltage on\n");
	return 0;
}

static void am3517_evm_panel_disable_lcd(struct omap_dss_device *dssdev)
{
    gpio_set_value(TAM3517_LCD_ENVDD_GPIO, 1);
    gpio_set_value(TAM3517_LCD_PON_GPIO, 0);
}

static struct panel_generic_dpi_data lcd_panel = {
//    .name			= "generic_dpi_panel",
	.platform_enable	= am3517_evm_panel_enable_lcd,
	.platform_disable	= am3517_evm_panel_disable_lcd,
};

static struct omap_dss_device am3517_evm_lcd_device = {
    .type                   = OMAP_DISPLAY_TYPE_DPI,
    .name			= "lcd",
    .driver_name		= "generic_dpi_panel",
	.data			= &lcd_panel,
	.phy.dpi.data_lines 	= 16,
};

static int am3517_evm_panel_enable_tv(struct omap_dss_device *dssdev)
{
	return 0;
}

static void am3517_evm_panel_disable_tv(struct omap_dss_device *dssdev)
{
}

static struct omap_dss_device am3517_evm_tv_device = {
	.type 			= OMAP_DISPLAY_TYPE_VENC,
	.name 			= "tv",
	.driver_name		= "venc",
	.phy.venc.type		= OMAP_DSS_VENC_TYPE_SVIDEO,
	.platform_enable	= am3517_evm_panel_enable_tv,
	.platform_disable	= am3517_evm_panel_disable_tv,
};

static struct tfp410_platform_data dvi_panel = {
	.power_down_gpio	= -1,
};

static struct omap_dss_device am3517_evm_dvi_device = {
	.type			= OMAP_DISPLAY_TYPE_DPI,
	.name			= "dvi",
	.driver_name		= "tfp410",
	.data			= &dvi_panel,
	.phy.dpi.data_lines	= 24,
};     

static struct omap_dss_device *am3517_evm_dss_devices[] = {
	&am3517_evm_lcd_device,
//	&am3517_evm_tv_device,
//	&am3517_evm_dvi_device,
};

static struct omap_dss_board_info am3517_evm_dss_data = {
	.num_devices	= ARRAY_SIZE(am3517_evm_dss_devices),
	.devices	= am3517_evm_dss_devices,
  	.default_device	= &am3517_evm_lcd_device,
};

And the device initialised with 
    omap_display_init(&am3517_evm_dss_data);


Any help feedback appreciated.

Thanks
Marc

Re: Initialising omapfb on AM3517 issues

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 2777 bytes --]

Hi,

On Tue, 2012-09-18 at 16:41 +0000, Marc Murphy wrote:
> Hello all,
> I have been moving from the ti 2.6.37 BSP to the 3.x kernel with quite a bit of success, the main issue I have at the moment is trying to get the frame buffer and any displays I have initialised.
> 
> [    2.805358] omapfb omapfb: no driver for display: lcd
> [    2.810729] omapfb omapfb: no displays
> [    2.814666] omapfb omapfb: failed to setup omapfb
> 
> I have tried a few versions of release and none of them will initialise;
> 
> Currently on
> [    0.000000] Linux version 3.6.0-rc3
> 
> I have started with board-am3517evm display config and even that doesn't initialise.  Is there something I am missing with the configs or is there a patch required to get the feature to work.
> 
> My current config options use;
> #
> # Graphics support
> #
> CONFIG_DRM=y

omapdrm and omapfb cannot be used at the same time. That said, you don't
seem to enable omapdrm, only the core drm support, so it shouldn't
matter. But you don't need CONFIG_DRM if you use omapfb.

> CONFIG_FB=y
> CONFIG_FB_CFB_FILLRECT=y
> CONFIG_FB_CFB_COPYAREA=y
> CONFIG_FB_CFB_IMAGEBLIT=y
> 
> #
> # Frame buffer hardware drivers
> #
> CONFIG_OMAP2_VRAM=y
> CONFIG_OMAP2_VRFB=y
> CONFIG_OMAP2_DSS=y
> CONFIG_OMAP2_VRAM_SIZE=12
> CONFIG_OMAP2_DSS_DPI=y
> CONFIG_OMAP2_DSS_VENC=y
> CONFIG_OMAP2_DSS_DSI=y
> CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK=1
> CONFIG_OMAP2_DSS_SLEEP_AFTER_VENC_RESET=y
> CONFIG_FB_OMAP2=y
> CONFIG_FB_OMAP2_NUM_FBS=3
> 
> #
> # OMAP2/3 Display Device Drivers
> #
> CONFIG_PANEL_GENERIC_DPI=y
> CONFIG_PANEL_SHARP_LS037V7DW01=y
> CONFIG_BACKLIGHT_LCD_SUPPORT=y
> CONFIG_LCD_CLASS_DEVICE=y
> CONFIG_BACKLIGHT_CLASS_DEVICE=y
> CONFIG_BACKLIGHT_GENERIC=y
> 
> And the init structs are
> static int am3517_evm_panel_enable_lcd(struct omap_dss_device *dssdev)
> {
>     gpio_set_value(TAM3517_DVI_PON_GPIO, 0);
>     gpio_set_value(TAM3517_LCD_ENVDD_GPIO, 0);
>     gpio_set_value(TAM3517_LCD_PON_GPIO, 1);
>         printk("LCD voltage on\n");
> 	return 0;
> }
> 
> static void am3517_evm_panel_disable_lcd(struct omap_dss_device *dssdev)
> {
>     gpio_set_value(TAM3517_LCD_ENVDD_GPIO, 1);
>     gpio_set_value(TAM3517_LCD_PON_GPIO, 0);
> }
> 
> static struct panel_generic_dpi_data lcd_panel = {
> //    .name			= "generic_dpi_panel",

You need to define name for the panel you have. You can see the list of
supported panels in drivers/video/omap2/displays/panel-generic-dpi.c. If
you don't give a name, the panel driver doesn't start.

There's also a problem with the vdds_dsi regulator. Search the list for
"[PATCH] OMAPDSS: Do not require a VDDS_DSI regulator on am35xx". The
patch to fix it hasn't been merged yet.

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

RE: Initialising omapfb on AM3517 issues

[Marc Murphy]

Hi Tomi,
Thank you for those hints... I now have the LCD displaying the bootup logo, so it’s a good start.

How do I push the patch for the new panel ?

    	/* HannStar HSD043i9W1*/
	{
		{
			.x_res		= 480,
			.y_res		= 272,

			.pixel_clock	= 9000,

			.hsw		= 41,
			.hfp		= 2,
			.hbp		= 2,

			.vsw		= 10,
			.vfp		= 2,
			.vbp		= 2,

			.vsync_level	= OMAPDSS_SIG_ACTIVE_HIGH,
			.hsync_level	= OMAPDSS_SIG_ACTIVE_HIGH,
			.data_pclk_edge	= OMAPDSS_DRIVE_SIG_RISING_EDGE,
			.de_level	= OMAPDSS_SIG_ACTIVE_HIGH,
			.sync_pclk_edge	= OMAPDSS_DRIVE_SIG_OPPOSITE_EDGES,
		},
		.name			= "hannstar_hsd043i9w1",
	},

Regards
Marc


-----Original Message-----
From: Tomi Valkeinen [mailto:tomi.valkeinen@ti.com] 
Sent: 19 September 2012 08:24
To: Marc Murphy
Cc: 'linux-omap@vger.kernel.org'
Subject: Re: Initialising omapfb on AM3517 issues

Hi,

On Tue, 2012-09-18 at 16:41 +0000, Marc Murphy wrote:
> Hello all,
> I have been moving from the ti 2.6.37 BSP to the 3.x kernel with quite a bit of success, the main issue I have at the moment is trying to get the frame buffer and any displays I have initialised.
> 
> [    2.805358] omapfb omapfb: no driver for display: lcd
> [    2.810729] omapfb omapfb: no displays
> [    2.814666] omapfb omapfb: failed to setup omapfb
> 
> I have tried a few versions of release and none of them will 
> initialise;
> 
> Currently on
> [    0.000000] Linux version 3.6.0-rc3
> 
> I have started with board-am3517evm display config and even that doesn't initialise.  Is there something I am missing with the configs or is there a patch required to get the feature to work.
> 
> My current config options use;
> #
> # Graphics support
> #
> CONFIG_DRM=y

omapdrm and omapfb cannot be used at the same time. That said, you don't seem to enable omapdrm, only the core drm support, so it shouldn't matter. But you don't need CONFIG_DRM if you use omapfb.

> CONFIG_FB=y
> CONFIG_FB_CFB_FILLRECT=y
> CONFIG_FB_CFB_COPYAREA=y
> CONFIG_FB_CFB_IMAGEBLIT=y
> 
> #
> # Frame buffer hardware drivers
> #
> CONFIG_OMAP2_VRAM=y
> CONFIG_OMAP2_VRFB=y
> CONFIG_OMAP2_DSS=y
> CONFIG_OMAP2_VRAM_SIZE=12
> CONFIG_OMAP2_DSS_DPI=y
> CONFIG_OMAP2_DSS_VENC=y
> CONFIG_OMAP2_DSS_DSI=y
> CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK=1
> CONFIG_OMAP2_DSS_SLEEP_AFTER_VENC_RESET=y
> CONFIG_FB_OMAP2=y
> CONFIG_FB_OMAP2_NUM_FBS=3
> 
> #
> # OMAP2/3 Display Device Drivers
> #
> CONFIG_PANEL_GENERIC_DPI=y
> CONFIG_PANEL_SHARP_LS037V7DW01=y
> CONFIG_BACKLIGHT_LCD_SUPPORT=y
> CONFIG_LCD_CLASS_DEVICE=y
> CONFIG_BACKLIGHT_CLASS_DEVICE=y
> CONFIG_BACKLIGHT_GENERIC=y
> 
> And the init structs are
> static int am3517_evm_panel_enable_lcd(struct omap_dss_device *dssdev) 
> {
>     gpio_set_value(TAM3517_DVI_PON_GPIO, 0);
>     gpio_set_value(TAM3517_LCD_ENVDD_GPIO, 0);
>     gpio_set_value(TAM3517_LCD_PON_GPIO, 1);
>         printk("LCD voltage on\n");
> 	return 0;
> }
> 
> static void am3517_evm_panel_disable_lcd(struct omap_dss_device 
> *dssdev) {
>     gpio_set_value(TAM3517_LCD_ENVDD_GPIO, 1);
>     gpio_set_value(TAM3517_LCD_PON_GPIO, 0); }
> 
> static struct panel_generic_dpi_data lcd_panel = {
> //    .name			= "generic_dpi_panel",

You need to define name for the panel you have. You can see the list of supported panels in drivers/video/omap2/displays/panel-generic-dpi.c. If you don't give a name, the panel driver doesn't start.

There's also a problem with the vdds_dsi regulator. Search the list for "[PATCH] OMAPDSS: Do not require a VDDS_DSI regulator on am35xx". The patch to fix it hasn't been merged yet.

 Tomi