From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Raphael Assenat <raph@8d.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] OMAPDSS: Do not require a VDDS_DSI regulator on am35xx
Date: Wed, 19 Sep 2012 10:49:03 +0300 [thread overview]
Message-ID: <1348040943.2565.8.camel@deskari> (raw)
In-Reply-To: <1345545584.4085.49.camel@deskari>
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
On Tue, 2012-08-21 at 13:39 +0300, Tomi Valkeinen wrote:
> Hi,
>
> On Wed, 2012-08-15 at 15:16 -0400, Raphael Assenat wrote:
> > On our AM3505 based board, dpi.c complains that there is no VDSS_DSI regulator
> > and the framebuffer cannot be enabled. However, this check does not seem to
> > apply to AM3505/17 chips.
> >
> > Taking into account comments received after my first patch[1], I have added
> > entries to dss_features.c to support the am35xx soc. Then in dpi.c, instead
> > of using cpu_is_omap34xx() and soc_is_am35xx(), a call to dss_has_feature()
> > is used.
> >
> > [1] http://marc.info/?l=linux-fbdev&m=134272967203409&w=2
> >
> > Signed-off-by: Raphaël Assénat <raph@8d.com>
>
> Chandrabhanu has posted a series that removes a bunch of cpu_is checks
> from omapdss. On of them is the use of VDDS_DSI in dpi.c.
>
> Can you wait until I've merged those patches to omapdss master branch
> (probably a few days), and then create a new patch that adds AM35xx to
> dss_features?
If you have time, can you revisit this? The current omapdss master
branch has some cleanups for the cpu check:
git://gitorious.org/linux-omap-dss2/linux.git master
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-19 7:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 19:16 [PATCH v2] OMAPDSS: Do not require a VDDS_DSI regulator on am35xx Raphael Assenat
2012-08-21 10:39 ` Tomi Valkeinen
2012-09-19 7:49 ` Tomi Valkeinen [this message]
2012-09-19 19:53 ` Raphaël Assénat
2012-09-20 8:22 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348040943.2565.8.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=raph@8d.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox