From: Jon Hunter <jon-hunter@ti.com>
To: Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
Tony Lindgren <tony@atomide.com>,
Benoit Cousson <b-cousson@ti.com>
Cc: device-tree <devicetree-discuss@lists.ozlabs.org>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>,
Daniel Mack <zonque@gmail.com>, Jon Hunter <jon-hunter@ti.com>
Subject: [PATCH 10/14] ARM: OMAP2+: Add function to read GPMC settings from device-tree
Date: Tue, 26 Feb 2013 11:30:37 -0600 [thread overview]
Message-ID: <1361899842-30303-11-git-send-email-jon-hunter@ti.com> (raw)
In-Reply-To: <1361899842-30303-1-git-send-email-jon-hunter@ti.com>
Adds a function to read the various GPMC chip-select settings from
device-tree and store them in the gpmc_settings structure.
Update the GPMC device-tree binding documentation to describe these
options.
Signed-off-by: Jon Hunter <jon-hunter@ti.com>
---
Documentation/devicetree/bindings/bus/ti-gpmc.txt | 19 ++++++++
arch/arm/mach-omap2/gpmc.c | 50 +++++++++++++++++++++
arch/arm/mach-omap2/gpmc.h | 2 +
3 files changed, 71 insertions(+)
diff --git a/Documentation/devicetree/bindings/bus/ti-gpmc.txt b/Documentation/devicetree/bindings/bus/ti-gpmc.txt
index 5ddb2e9..a31c32a 100644
--- a/Documentation/devicetree/bindings/bus/ti-gpmc.txt
+++ b/Documentation/devicetree/bindings/bus/ti-gpmc.txt
@@ -65,6 +65,25 @@ The following are only applicable to OMAP3+ and AM335x:
- gpmc,wr-access
- gpmc,wr-data-mux-bus
+GPMC chip-select settings properties for child nodes. All are optional.
+
+- gpmc,burst-length Page/burst length. Must be 4, 8 or 16.
+- gpmc,burst-wrap Enables wrap bursting
+- gpmc,burst-read Enables read page/burst mode
+- gpmc,burst-write Enables write page/burst mode
+- gpmc,device-nand Device is NAND
+- gpmc,device-width Width of device connected to the GPMC in bytes. The
+ GPMC supports 8-bit and 16-bit devices and so this
+ property must be 1 or 2.
+- gpmc,mux-add-data Enables address and data multiplexing
+- gpmc,sync-read Enables synchronous read. Defaults to asynchronous
+ is this is not set.
+- gpmc,sync-write Enables synchronous writes. Defaults to asynchronous
+ is this is not set.
+- gpmc,wait-pin Wait-pin used by client. Must be less than
+ "gpmc,num-waitpins".
+- gpmc,wait-on-read Enables wait monitoring on reads.
+- gpmc,wait-on-write Enables wait monitoring on writes.
Example for an AM33xx board:
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 7cf3d98..e822d2b 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -1182,6 +1182,56 @@ static struct of_device_id gpmc_dt_ids[] = {
};
MODULE_DEVICE_TABLE(of, gpmc_dt_ids);
+/**
+ * gpmc_read_settings_dt - read gpmc settings from device-tree
+ * @np: pointer to device-tree node for a gpmc child device
+ * @p: pointer to gpmc settings structure
+ *
+ * Reads the GPMC settings for a GPMC child device from device-tree and
+ * stores them in the GPMC settings structure passed. The GPMC settings
+ * structure is initialise to zero by this function and so any previously
+ * stored settings will be clearer.
+ */
+void gpmc_read_settings_dt(struct device_node *np, struct gpmc_settings *p)
+{
+ memset(p, 0, sizeof(struct gpmc_settings));
+
+ if (of_find_property(np, "gpmc,sync-read", NULL))
+ p->sync_read = true;
+ if (of_find_property(np, "gpmc,sync-write", NULL))
+ p->sync_write = true;
+
+ if (!of_property_read_u32(np, "gpmc,burst-length", &p->burst_len)) {
+ if (of_find_property(np, "gpmc,burst-wrap", NULL))
+ p->burst_wrap = true;
+ if (of_find_property(np, "gpmc,burst-read", NULL))
+ p->burst_read = true;
+ if (of_find_property(np, "gpmc,burst-write", NULL))
+ p->burst_write = true;
+ if (!p->burst_read && !p->burst_write)
+ pr_warn("%s: page/burst-length set but not used!\n",
+ __func__);
+ }
+
+ if (!of_property_read_u32(np, "gpmc,wait-pin", &p->wait_pin)) {
+ if (of_find_property(np, "gpmc,wait-on-read", NULL))
+ p->wait_on_read = true;
+ if (of_find_property(np, "gpmc,wait-on-write", NULL))
+ p->wait_on_write = true;
+ if (!p->wait_on_read && !p->wait_on_write)
+ pr_warn("%s: read/write wait monitoring not enabled!\n",
+ __func__);
+ }
+
+ of_property_read_u32(np, "gpmc,device-width", &p->device_width);
+
+ if (of_find_property(np, "gpmc,device-nand", NULL))
+ p->device_nand = true;
+
+ if (of_find_property(np, "gpmc,mux-add-data", NULL))
+ p->mux_add_data = true;
+}
+
static void __maybe_unused gpmc_read_timings_dt(struct device_node *np,
struct gpmc_timings *gpmc_t)
{
diff --git a/arch/arm/mach-omap2/gpmc.h b/arch/arm/mach-omap2/gpmc.h
index d73fda0..c517eaa 100644
--- a/arch/arm/mach-omap2/gpmc.h
+++ b/arch/arm/mach-omap2/gpmc.h
@@ -230,5 +230,7 @@ extern int gpmc_cs_reserved(int cs);
extern void omap3_gpmc_save_context(void);
extern void omap3_gpmc_restore_context(void);
extern int gpmc_configure(int cmd, int wval);
+extern void gpmc_read_settings_dt(struct device_node *np,
+ struct gpmc_settings *p);
#endif
--
1.7.10.4
next prev parent reply other threads:[~2013-02-26 17:31 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 17:30 [PATCH 00/14] ARM: OMAP2+: GPMC clean-up and DT update Jon Hunter
2013-02-26 17:30 ` [PATCH 01/14] ARM: OMAP2+: Simplify code configuring ONENAND devices Jon Hunter
2013-02-26 17:30 ` [PATCH 02/14] ARM: OMAP2+: Add variable to store number of GPMC waitpins Jon Hunter
2013-02-26 17:30 ` [PATCH 03/14] ARM: OMAP2+: Add structure for storing GPMC settings Jon Hunter
2013-02-26 17:30 ` [PATCH 04/14] ARM: OMAP2+: Add function for configuring " Jon Hunter
2013-02-28 6:05 ` Philip, Avinash
[not found] ` <518397C60809E147AF5323E0420B992E3EA8F007-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2013-02-28 15:52 ` Jon Hunter
2013-02-28 17:12 ` Jon Hunter
2013-03-01 5:33 ` Philip, Avinash
2013-03-01 15:43 ` Jon Hunter
[not found] ` <5130CCA9.10905-l0cyMroinI0@public.gmane.org>
2013-03-04 10:05 ` Philip, Avinash
2013-02-26 17:30 ` [PATCH 05/14] ARM: OMAP2+: Convert ONENAND to use gpmc_cs_program_settings() Jon Hunter
2013-02-26 17:30 ` [PATCH 06/14] ARM: OMAP2+: Convert NAND " Jon Hunter
[not found] ` <1361899842-30303-7-git-send-email-jon-hunter-l0cyMroinI0@public.gmane.org>
2013-02-28 10:38 ` Philip, Avinash
2013-02-28 16:02 ` Jon Hunter
2013-03-01 5:40 ` Philip, Avinash
[not found] ` <518397C60809E147AF5323E0420B992E3EA90C46-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2013-03-01 15:50 ` Jon Hunter
2013-02-26 17:30 ` [PATCH 07/14] ARM: OMAP2+: Convert SMC91x " Jon Hunter
2013-02-26 17:30 ` [PATCH 08/14] ARM: OMAP2+: Convert TUSB " Jon Hunter
2013-02-26 17:30 ` [PATCH 09/14] ARM: OMAP2+: Don't configure of chip-select options in gpmc_cs_configure() Jon Hunter
2013-02-26 17:30 ` Jon Hunter [this message]
2013-02-26 17:30 ` [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash Jon Hunter
2013-03-01 21:25 ` Ezequiel Garcia
2013-03-01 22:24 ` Jon Hunter
2013-03-04 11:57 ` Ezequiel Garcia
2013-03-04 17:51 ` Jon Hunter
[not found] ` <5134DF2A.4050209-l0cyMroinI0@public.gmane.org>
2013-03-04 18:19 ` Jon Hunter
2013-03-05 14:34 ` Mark Jackson
2013-03-05 14:46 ` Jon Hunter
2013-03-05 16:20 ` Mark Jackson
2013-03-05 17:30 ` Jon Hunter
2013-03-05 17:43 ` Ezequiel Garcia
2013-03-05 18:41 ` Jon Hunter
2013-03-05 21:34 ` Jon Hunter
2013-03-06 10:23 ` Mark Jackson
2013-03-06 13:30 ` Mark Jackson
2013-03-06 16:44 ` Jon Hunter
2013-03-06 16:48 ` Mark Jackson
2013-03-06 17:00 ` Jon Hunter
2013-03-06 18:01 ` Jon Hunter
2013-03-06 11:58 ` Ezequiel Garcia
2013-03-06 16:46 ` Jon Hunter
2013-03-06 16:54 ` Ezequiel Garcia
2013-03-07 13:02 ` Ezequiel Garcia
2013-02-26 17:30 ` [PATCH 12/14] ARM: OMAP2+: Add additional GPMC timing parameters Jon Hunter
[not found] ` <1361899842-30303-13-git-send-email-jon-hunter-l0cyMroinI0@public.gmane.org>
2013-03-01 20:11 ` Ezequiel Garcia
2013-03-01 20:12 ` Ezequiel Garcia
2013-03-01 22:27 ` Jon Hunter
2013-03-01 22:27 ` Jon Hunter
2013-02-26 17:30 ` [PATCH 13/14] ARM: OMAP2+: Convert NAND to retrieve GPMC settings from DT Jon Hunter
2013-02-26 17:30 ` [PATCH 14/14] ARM: OMAP2+: Convert ONENAND " Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361899842-30303-11-git-send-email-jon-hunter@ti.com \
--to=jon-hunter@ti.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=tony@atomide.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox