[PATCH v5 0/5] Thermal: Support for hardware-tracked trip points

[PATCH v5 0/5] Thermal: Support for hardware-tracked trip points

[Caesar Wang]

Thank you all for providing inputs and comments on previous versions of
this patchset.
Especially thanks to the (Mikko,Sascha,Eduardo,Javi,Steve....).

The history patches come from Mikko and Sascha.
    http://thread.gmane.org/gmane.linux.power-management.general/59451

Now, I pick them up to continue upstream.
Nevermind!

This series history patches:
v4: https://lkml.org/lkml/2016/5/27/122
v3: https://lkml.org/lkml/2016/5/24/797
v2: https://lkml.org/lkml/2016/5/3/220
v1: https://lkml.org/lkml/2016/4/24/227

This series adds support for hardware trip points. It picks up earlier
work from Mikko Perttunen. Mikko implemented hardware trip points as part
of the device tree support. It was suggested back then to move the
functionality to the thermal core instead of putting more code into the
device tree support. This series does exactly that.

This series patches rebase the conflicts with the lastest next kernel.
Note that the hardware-tracked trip points are very well tested currently.

Verified and tested on https://github.com/Caesar-github/rockchip/tree/wip/fixes-thermal-0606
That's based on the next kernel (4.7-rc2).
localhost / # cat /proc/version
Linux version 4.7.0-rc2-next-20160606-02546-g534926d (wxt@nb)
---
There are five pathes in this series.
thermal: Add support for hardware-tracked trip point
thermal: of: implement .set_trips for device tree thermal zones
thermal: streamline get_trend callbacks
thermal: bang-bang governor: act on lower trip boundary
thermal: rockchip: add the set_trips function

Note: the hardware-tracked trip points that the similar patches were verified
on ChromoeOs platform.
e.g.:
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.18
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-4.4
---

Anyway, I take the lastest thermal change to test from next kernel,

Tested on RK3399 SoCs on https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-4.4
And
Tested on RK3288 SoCs with chromebook on next kernel.
localhost / # while true; do grep "" /sys/class/thermal/thermal_zone[0-1]/temp; sleep .5; done
/sys/class/thermal/thermal_zone1/temp:45454
/sys/class/thermal/thermal_zone2/temp:44090
/sys/class/thermal/thermal_zone1/temp:44545
/sys/class/thermal/thermal_zone2/temp:44545
/sys/class/thermal/thermal_zone1/temp:45454
/sys/class/thermal/thermal_zone2/temp:44545
/sys/class/thermal/thermal_zone1/temp:45000
...
Then add the loading,
localhost / # md5sum /dev/zero &
[3] 8354
..
The Set trips trigger the hardware-tracked points.

rockchip-thermal ff280000.tsadc: sensor 1 - temp: 68461, retval: 0
rockchip-thermal ff280000.tsadc: sensor 2 - temp: 64166, retval: 0
rockchip-thermal ff280000.tsadc: sensor 1 - temp: 70000, retval: 0
rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor 1: low: 68000, high 75000
rockchip-thermal ff280000.tsadc: sensor 2 - temp: 66153, retval: 0
rockchip-thermal ff280000.tsadc: sensor 1 - temp: 69230, retval: 0
rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor 1: low: 68000, high 70000
rockchip-thermal ff280000.tsadc: sensor 1 - temp: 68076, retval: 0
rockchip-thermal ff280000.tsadc: sensor 2 - temp: 65384, retval: 0
rockchip-thermal ff280000.tsadc: sensor 1 - temp: 69615, retval: 0
rockchip-thermal ff280000.tsadc: sensor 1 - temp: 70000, retval: 0
rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor 1: low: 68000, high 75000
rockchip-thermal ff280000.tsadc: sensor 2 - temp: 65384, retval: 0
rockchip-thermal ff280000.tsadc: sensor 1 - temp: 69615, retval: 0
rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor 1: low: 68000, high 70000
rockchip-thermal ff280000.tsadc: sensor 1 - temp: 69615, retval: 0
rockchip-thermal ff280000.tsadc: sensor 1 - temp: 69230, retval: 0
rockchip-thermal ff280000.tsadc: sensor 1 - temp: 70833, retval: 0
rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor 1: low: 68000, high 75000
rockchip-thermal ff280000.tsadc: sensor 2 - temp: 66153, retval: 0
rockchip-thermal ff280000.tsadc: sensor 1 - temp: 69230, retval: 0
rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor 1: low: 68000, high 70000
rockchip-thermal ff280000.tsadc: sensor 1 - temp: 70416, retval: 0
rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor 1: low: 68000, high 75000
rockchip-thermal ff280000.tsadc: sensor 1 - temp: 70000, retval: 0
rockchip-thermal ff280000.tsadc: sensor 1 - temp: 69615, retval: 0
rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor 1: low: 68000, high 70000
rockchip-thermal ff280000.tsadc: sensor 1 - temp: 70000, retval: 0
rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor 1: low: 68000, high 75000
..
---
Anyway, the series patches are verified on rockchip platform.

Thanks someone are reviewing and testing for it.

-Caesar


Changes in v5:
- add the lock for thermal_zone_set_trips function.
- change based on next kernel.
- add the tested by Steve.

Changes in v4:
- Missing the lock added in v3.
- as the Javi comments, %s/implemnets/implements.

Changes in v3:
- as Javi comments on https://patchwork.kernel.org/patch/9001281/.
- add the lock for preventing the called from multi placce
- add the note for pre_low/high_trip.
- as the Javi comments on https://patchwork.kernel.org/patch/9001311/.
- add the select if they set the option for devicetree.
- Add the peter's ACK.

Changes in v2:
- update the sysfs-api.txt for set_trips.
- add the commit in patch[v2 2/5].
- Update the commit for patch[v2 4/5].

Caesar Wang (1):
  thermal: rockchip: add the set_trips function

Sascha Hauer (4):
  thermal: Add support for hardware-tracked trip points
  thermal: of: implement .set_trips for device tree thermal zones
  thermal: streamline get_trend callbacks
  thermal: bang-bang governor: act on lower trip boundary

 Documentation/thermal/sysfs-api.txt                |  7 +++
 drivers/thermal/gov_bang_bang.c                    |  2 +-
 drivers/thermal/of-thermal.c                       | 30 ++++++++----
 drivers/thermal/rockchip_thermal.c                 | 39 ++++++++++++++++
 drivers/thermal/thermal_core.c                     | 54 ++++++++++++++++++++++
 drivers/thermal/thermal_sysfs.c                    |  3 ++
 drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 25 ++++------
 include/linux/thermal.h                            | 16 ++++++-
 8 files changed, 147 insertions(+), 29 deletions(-)

-- 
1.9.1

[PATCH v5 3/5] thermal: streamline get_trend callbacks

[Caesar Wang]

From: Sascha Hauer <s.hauer@pengutronix.de>

The .get_trend callback in struct thermal_zone_device_ops has
the prototype:
        int (*get_trend) (struct thermal_zone_device *, int,
                          enum thermal_trend *);
whereas the .get_trend callback in struct thermal_zone_of_device_ops
has:
        int (*get_trend)(void *, long *);

Streamline both prototypes and add the trip argument to the OF callback
aswell and use enum thermal_trend * instead of an integer pointer.

While the OF prototype may be the better one, this should be decided at
framework level and not on OF level.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: linux-pm@vger.kernel.org
---

Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 drivers/thermal/of-thermal.c                       | 11 +---------
 drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 25 +++++++---------------
 include/linux/thermal.h                            |  2 +-
 3 files changed, 10 insertions(+), 28 deletions(-)

diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
index 2d2a06f..ba72c35 100644
--- a/drivers/thermal/of-thermal.c
+++ b/drivers/thermal/of-thermal.c
@@ -202,24 +202,15 @@ static int of_thermal_get_trend(struct thermal_zone_device *tz, int trip,
 				enum thermal_trend *trend)
 {
 	struct __thermal_zone *data = tz->devdata;
-	long dev_trend;
 	int r;
 
 	if (!data->ops->get_trend)
 		return -EINVAL;
 
-	r = data->ops->get_trend(data->sensor_data, &dev_trend);
+	r = data->ops->get_trend(data->sensor_data, trip, trend);
 	if (r)
 		return r;
 
-	/* TODO: These intervals might have some thresholds, but in core code */
-	if (dev_trend > 0)
-		*trend = THERMAL_TREND_RAISING;
-	else if (dev_trend < 0)
-		*trend = THERMAL_TREND_DROPPING;
-	else
-		*trend = THERMAL_TREND_STABLE;
-
 	return 0;
 }
 
diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
index 15c0a9a..4a6757c 100644
--- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
+++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
@@ -239,7 +239,7 @@ static int ti_thermal_get_trip_temp(struct thermal_zone_device *thermal,
 	return 0;
 }
 
-static int __ti_thermal_get_trend(void *p, long *trend)
+static int __ti_thermal_get_trend(void *p, int trip, enum thermal_trend *trend)
 {
 	struct ti_thermal_data *data = p;
 	struct ti_bandgap *bgp;
@@ -252,22 +252,6 @@ static int __ti_thermal_get_trend(void *p, long *trend)
 	if (ret)
 		return ret;
 
-	*trend = tr;
-
-	return 0;
-}
-
-/* Get the temperature trend callback functions for thermal zone */
-static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
-				int trip, enum thermal_trend *trend)
-{
-	int ret;
-	long tr;
-
-	ret = __ti_thermal_get_trend(thermal->devdata, &tr);
-	if (ret)
-		return ret;
-
 	if (tr > 0)
 		*trend = THERMAL_TREND_RAISING;
 	else if (tr < 0)
@@ -278,6 +262,13 @@ static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
 	return 0;
 }
 
+/* Get the temperature trend callback functions for thermal zone */
+static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
+				int trip, enum thermal_trend *trend)
+{
+	return __ti_thermal_get_trend(thermal->devdata, trip, trend);
+}
+
 /* Get critical temperature callback functions for thermal zone */
 static int ti_thermal_get_crit_temp(struct thermal_zone_device *thermal,
 				    int *temp)
diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index 2440b8d..d3ce3a5 100644
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -352,7 +352,7 @@ struct thermal_genl_event {
  */
 struct thermal_zone_of_device_ops {
 	int (*get_temp)(void *, int *);
-	int (*get_trend)(void *, long *);
+	int (*get_trend)(void *, int, enum thermal_trend *);
 	int (*set_trips)(void *, int, int);
 	int (*set_emul_temp)(void *, int);
 	int (*set_trip_temp)(void *, int, int);
-- 
1.9.1

Re: [PATCH v5 3/5] thermal: streamline get_trend callbacks

[Keerthy]

On Monday 06 June 2016 05:14 PM, Caesar Wang wrote:
> From: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>
> The .get_trend callback in struct thermal_zone_device_ops has
> the prototype:
>          int (*get_trend) (struct thermal_zone_device *, int,
>                            enum thermal_trend *);
> whereas the .get_trend callback in struct thermal_zone_of_device_ops
> has:
>          int (*get_trend)(void *, long *);
>
> Streamline both prototypes and add the trip argument to the OF callback
> aswell and use enum thermal_trend * instead of an integer pointer.
>
> While the OF prototype may be the better one, this should be decided at
> framework level and not on OF level.

Tested this patch on omap5-uevm using emulation feature and saw that
cooling state was getting updated correctly w.r.t trip point tempereatures.

A minor comment below apart from that.

Reviewed-by: Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>

>
> Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Signed-off-by: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> Cc: Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: Eduardo Valentin <edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> ---
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
>   drivers/thermal/of-thermal.c                       | 11 +---------
>   drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 25 +++++++---------------
>   include/linux/thermal.h                            |  2 +-
>   3 files changed, 10 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index 2d2a06f..ba72c35 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -202,24 +202,15 @@ static int of_thermal_get_trend(struct thermal_zone_device *tz, int trip,
>   				enum thermal_trend *trend)
>   {
>   	struct __thermal_zone *data = tz->devdata;
> -	long dev_trend;
>   	int r;

	int r = 0;

>
>   	if (!data->ops->get_trend)
>   		return -EINVAL;
>
> -	r = data->ops->get_trend(data->sensor_data, &dev_trend);
> +	r = data->ops->get_trend(data->sensor_data, trip, trend);
>   	if (r)
>   		return r;

no need of this if check just
	
	return r;

>
> -	/* TODO: These intervals might have some thresholds, but in core code */
> -	if (dev_trend > 0)
> -		*trend = THERMAL_TREND_RAISING;
> -	else if (dev_trend < 0)
> -		*trend = THERMAL_TREND_DROPPING;
> -	else
> -		*trend = THERMAL_TREND_STABLE;
> -
>   	return 0;
>   }
>
> diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> index 15c0a9a..4a6757c 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> @@ -239,7 +239,7 @@ static int ti_thermal_get_trip_temp(struct thermal_zone_device *thermal,
>   	return 0;
>   }
>
> -static int __ti_thermal_get_trend(void *p, long *trend)
> +static int __ti_thermal_get_trend(void *p, int trip, enum thermal_trend *trend)
>   {
>   	struct ti_thermal_data *data = p;
>   	struct ti_bandgap *bgp;
> @@ -252,22 +252,6 @@ static int __ti_thermal_get_trend(void *p, long *trend)
>   	if (ret)
>   		return ret;
>
> -	*trend = tr;
> -
> -	return 0;
> -}
> -
> -/* Get the temperature trend callback functions for thermal zone */
> -static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
> -				int trip, enum thermal_trend *trend)
> -{
> -	int ret;
> -	long tr;
> -
> -	ret = __ti_thermal_get_trend(thermal->devdata, &tr);
> -	if (ret)
> -		return ret;
> -
>   	if (tr > 0)
>   		*trend = THERMAL_TREND_RAISING;
>   	else if (tr < 0)
> @@ -278,6 +262,13 @@ static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
>   	return 0;
>   }
>
> +/* Get the temperature trend callback functions for thermal zone */
> +static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
> +				int trip, enum thermal_trend *trend)
> +{
> +	return __ti_thermal_get_trend(thermal->devdata, trip, trend);
> +}
> +
>   /* Get critical temperature callback functions for thermal zone */
>   static int ti_thermal_get_crit_temp(struct thermal_zone_device *thermal,
>   				    int *temp)
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 2440b8d..d3ce3a5 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -352,7 +352,7 @@ struct thermal_genl_event {
>    */
>   struct thermal_zone_of_device_ops {
>   	int (*get_temp)(void *, int *);
> -	int (*get_trend)(void *, long *);
> +	int (*get_trend)(void *, int, enum thermal_trend *);
>   	int (*set_trips)(void *, int, int);
>   	int (*set_emul_temp)(void *, int);
>   	int (*set_trip_temp)(void *, int, int);
>

Re: [PATCH v5 3/5] thermal: streamline get_trend callbacks

[Caesar Wang]

On 2016年06月07日 14:14, Keerthy wrote:
>
>
> On Monday 06 June 2016 05:14 PM, Caesar Wang wrote:
>> From: Sascha Hauer <s.hauer@pengutronix.de>
>>
>> The .get_trend callback in struct thermal_zone_device_ops has
>> the prototype:
>> int (*get_trend) (struct thermal_zone_device *, int,
>> enum thermal_trend *);
>> whereas the .get_trend callback in struct thermal_zone_of_device_ops
>> has:
>> int (*get_trend)(void *, long *);
>>
>> Streamline both prototypes and add the trip argument to the OF callback
>> aswell and use enum thermal_trend * instead of an integer pointer.
>>
>> While the OF prototype may be the better one, this should be decided at
>> framework level and not on OF level.
>
> Tested this patch on omap5-uevm using emulation feature and saw that
> cooling state was getting updated correctly w.r.t trip point 
> tempereatures.
>
> A minor comment below apart from that.
>
> Reviewed-by: Keerthy <j-keerthy@ti.com>
>
>>
>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>> Cc: Zhang Rui <rui.zhang@intel.com>
>> Cc: Eduardo Valentin <edubezval@gmail.com>
>> Cc: linux-pm@vger.kernel.org
>> ---
>>
>> Changes in v5: None
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2: None
>>
>> drivers/thermal/of-thermal.c | 11 +---------
>> drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 25 
>> +++++++---------------
>> include/linux/thermal.h | 2 +-
>> 3 files changed, 10 insertions(+), 28 deletions(-)
>>
>> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
>> index 2d2a06f..ba72c35 100644
>> --- a/drivers/thermal/of-thermal.c
>> +++ b/drivers/thermal/of-thermal.c
>> @@ -202,24 +202,15 @@ static int of_thermal_get_trend(struct 
>> thermal_zone_device *tz, int trip,
>> enum thermal_trend *trend)
>> {
>> struct __thermal_zone *data = tz->devdata;
>> - long dev_trend;
>> int r;
>
> int r = 0;
>
>>
>> if (!data->ops->get_trend)
>> return -EINVAL;
>>
>> - r = data->ops->get_trend(data->sensor_data, &dev_trend);
>> + r = data->ops->get_trend(data->sensor_data, trip, trend);
>> if (r)
>> return r;
>
> no need of this if check just
>
> return r;

Maybe, we can return it with "data->ops->get_trend(data->sensor_data, 
trip, trend)"

return data->ops->get_trend(data->sensor_data, trip, trend);
>
>>
>> - /* TODO: These intervals might have some thresholds, but in core 
>> code */
>> - if (dev_trend > 0)
>> - *trend = THERMAL_TREND_RAISING;
>> - else if (dev_trend < 0)
>> - *trend = THERMAL_TREND_DROPPING;
>> - else
>> - *trend = THERMAL_TREND_STABLE;
>> -
>> return 0;
>> }
>>
>> diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c 
>> b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
>> index 15c0a9a..4a6757c 100644
>> --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
>> +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
>> @@ -239,7 +239,7 @@ static int ti_thermal_get_trip_temp(struct 
>> thermal_zone_device *thermal,
>> return 0;
>> }
>>
>> -static int __ti_thermal_get_trend(void *p, long *trend)
>> +static int __ti_thermal_get_trend(void *p, int trip, enum 
>> thermal_trend *trend)
>> {
>> struct ti_thermal_data *data = p;
>> struct ti_bandgap *bgp;
>> @@ -252,22 +252,6 @@ static int __ti_thermal_get_trend(void *p, long 
>> *trend)
>> if (ret)
>> return ret;
>>
>> - *trend = tr;
>> -
>> - return 0;
>> -}
>> -
>> -/* Get the temperature trend callback functions for thermal zone */
>> -static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
>> - int trip, enum thermal_trend *trend)
>> -{
>> - int ret;
>> - long tr;
>> -
>> - ret = __ti_thermal_get_trend(thermal->devdata, &tr);
>> - if (ret)
>> - return ret;
>> -
>> if (tr > 0)
>> *trend = THERMAL_TREND_RAISING;
>> else if (tr < 0)
>> @@ -278,6 +262,13 @@ static int ti_thermal_get_trend(struct 
>> thermal_zone_device *thermal,
>> return 0;
>> }
>>
>> +/* Get the temperature trend callback functions for thermal zone */
>> +static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
>> + int trip, enum thermal_trend *trend)
>> +{
>> + return __ti_thermal_get_trend(thermal->devdata, trip, trend);
>> +}
>> +
>> /* Get critical temperature callback functions for thermal zone */
>> static int ti_thermal_get_crit_temp(struct thermal_zone_device *thermal,
>> int *temp)
>> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
>> index 2440b8d..d3ce3a5 100644
>> --- a/include/linux/thermal.h
>> +++ b/include/linux/thermal.h
>> @@ -352,7 +352,7 @@ struct thermal_genl_event {
>> */
>> struct thermal_zone_of_device_ops {
>> int (*get_temp)(void *, int *);
>> - int (*get_trend)(void *, long *);
>> + int (*get_trend)(void *, int, enum thermal_trend *);
>> int (*set_trips)(void *, int, int);
>> int (*set_emul_temp)(void *, int);
>> int (*set_trip_temp)(void *, int, int);
>>
>
>
>

-- 
caesar wang | software engineer | wxt@rock-chip.com

[PATCH v5.1 3/5] thermal: streamline get_trend callbacks

[Caesar Wang]

From: Sascha Hauer <s.hauer@pengutronix.de>

The .get_trend callback in struct thermal_zone_device_ops has
the prototype:
        int (*get_trend) (struct thermal_zone_device *, int,
                          enum thermal_trend *);
whereas the .get_trend callback in struct thermal_zone_of_device_ops
has:
        int (*get_trend)(void *, long *);

Streamline both prototypes and add the trip argument to the OF callback
aswell and use enum thermal_trend * instead of an integer pointer.

While the OF prototype may be the better one, this should be decided at
framework level and not on OF level.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: linux-pm@vger.kernel.org
Reviewed-by: Keerthy <j-keerthy@ti.com>

---

Changes in v5.1:
- As the Keerthy comments, change the get_trend for of_thermal.c
- Add the Kee's Reviewed-by, I can remove it if you object it.
- I'm assumed that the Eduardo will apply it. I can do it if Eduardo wants
  me to resend them.

Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None

 drivers/thermal/of-thermal.c                       | 16 +-------------
 drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 25 +++++++---------------
 include/linux/thermal.h                            |  2 +-
 3 files changed, 10 insertions(+), 33 deletions(-)

diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
index 2d2a06f..20822ab 100644
--- a/drivers/thermal/of-thermal.c
+++ b/drivers/thermal/of-thermal.c
@@ -202,25 +202,11 @@ static int of_thermal_get_trend(struct thermal_zone_device *tz, int trip,
 				enum thermal_trend *trend)
 {
 	struct __thermal_zone *data = tz->devdata;
-	long dev_trend;
-	int r;
 
 	if (!data->ops->get_trend)
 		return -EINVAL;
 
-	r = data->ops->get_trend(data->sensor_data, &dev_trend);
-	if (r)
-		return r;
-
-	/* TODO: These intervals might have some thresholds, but in core code */
-	if (dev_trend > 0)
-		*trend = THERMAL_TREND_RAISING;
-	else if (dev_trend < 0)
-		*trend = THERMAL_TREND_DROPPING;
-	else
-		*trend = THERMAL_TREND_STABLE;
-
-	return 0;
+	return data->ops->get_trend(data->sensor_data, trip, trend);
 }
 
 static int of_thermal_bind(struct thermal_zone_device *thermal,
diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
index 15c0a9a..4a6757c 100644
--- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
+++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
@@ -239,7 +239,7 @@ static int ti_thermal_get_trip_temp(struct thermal_zone_device *thermal,
 	return 0;
 }
 
-static int __ti_thermal_get_trend(void *p, long *trend)
+static int __ti_thermal_get_trend(void *p, int trip, enum thermal_trend *trend)
 {
 	struct ti_thermal_data *data = p;
 	struct ti_bandgap *bgp;
@@ -252,22 +252,6 @@ static int __ti_thermal_get_trend(void *p, long *trend)
 	if (ret)
 		return ret;
 
-	*trend = tr;
-
-	return 0;
-}
-
-/* Get the temperature trend callback functions for thermal zone */
-static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
-				int trip, enum thermal_trend *trend)
-{
-	int ret;
-	long tr;
-
-	ret = __ti_thermal_get_trend(thermal->devdata, &tr);
-	if (ret)
-		return ret;
-
 	if (tr > 0)
 		*trend = THERMAL_TREND_RAISING;
 	else if (tr < 0)
@@ -278,6 +262,13 @@ static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
 	return 0;
 }
 
+/* Get the temperature trend callback functions for thermal zone */
+static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
+				int trip, enum thermal_trend *trend)
+{
+	return __ti_thermal_get_trend(thermal->devdata, trip, trend);
+}
+
 /* Get critical temperature callback functions for thermal zone */
 static int ti_thermal_get_crit_temp(struct thermal_zone_device *thermal,
 				    int *temp)
diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index 2440b8d..d3ce3a5 100644
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -352,7 +352,7 @@ struct thermal_genl_event {
  */
 struct thermal_zone_of_device_ops {
 	int (*get_temp)(void *, int *);
-	int (*get_trend)(void *, long *);
+	int (*get_trend)(void *, int, enum thermal_trend *);
 	int (*set_trips)(void *, int, int);
 	int (*set_emul_temp)(void *, int);
 	int (*set_trip_temp)(void *, int, int);
-- 
1.9.1

Re: [PATCH v5.1 3/5] thermal: streamline get_trend callbacks

[Keerthy]

On Tuesday 07 June 2016 06:31 PM, Caesar Wang wrote:
> From: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>
> The .get_trend callback in struct thermal_zone_device_ops has
> the prototype:
>          int (*get_trend) (struct thermal_zone_device *, int,
>                            enum thermal_trend *);
> whereas the .get_trend callback in struct thermal_zone_of_device_ops
> has:
>          int (*get_trend)(void *, long *);
>
> Streamline both prototypes and add the trip argument to the OF callback
> aswell and use enum thermal_trend * instead of an integer pointer.
>
> While the OF prototype may be the better one, this should be decided at
> framework level and not on OF level.
>
> Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Signed-off-by: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> Cc: Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: Eduardo Valentin <edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Reviewed-by: Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>
>
> ---
>
> Changes in v5.1:
> - As the Keerthy comments, change the get_trend for of_thermal.c
> - Add the Kee's Reviewed-by, I can remove it if you object it.

Looks go to me.

> - I'm assumed that the Eduardo will apply it. I can do it if Eduardo wants
>    me to resend them.
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
>   drivers/thermal/of-thermal.c                       | 16 +-------------
>   drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 25 +++++++---------------
>   include/linux/thermal.h                            |  2 +-
>   3 files changed, 10 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index 2d2a06f..20822ab 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -202,25 +202,11 @@ static int of_thermal_get_trend(struct thermal_zone_device *tz, int trip,
>   				enum thermal_trend *trend)
>   {
>   	struct __thermal_zone *data = tz->devdata;
> -	long dev_trend;
> -	int r;
>
>   	if (!data->ops->get_trend)
>   		return -EINVAL;
>
> -	r = data->ops->get_trend(data->sensor_data, &dev_trend);
> -	if (r)
> -		return r;
> -
> -	/* TODO: These intervals might have some thresholds, but in core code */
> -	if (dev_trend > 0)
> -		*trend = THERMAL_TREND_RAISING;
> -	else if (dev_trend < 0)
> -		*trend = THERMAL_TREND_DROPPING;
> -	else
> -		*trend = THERMAL_TREND_STABLE;
> -
> -	return 0;
> +	return data->ops->get_trend(data->sensor_data, trip, trend);
>   }
>
>   static int of_thermal_bind(struct thermal_zone_device *thermal,
> diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> index 15c0a9a..4a6757c 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> @@ -239,7 +239,7 @@ static int ti_thermal_get_trip_temp(struct thermal_zone_device *thermal,
>   	return 0;
>   }
>
> -static int __ti_thermal_get_trend(void *p, long *trend)
> +static int __ti_thermal_get_trend(void *p, int trip, enum thermal_trend *trend)
>   {
>   	struct ti_thermal_data *data = p;
>   	struct ti_bandgap *bgp;
> @@ -252,22 +252,6 @@ static int __ti_thermal_get_trend(void *p, long *trend)
>   	if (ret)
>   		return ret;
>
> -	*trend = tr;
> -
> -	return 0;
> -}
> -
> -/* Get the temperature trend callback functions for thermal zone */
> -static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
> -				int trip, enum thermal_trend *trend)
> -{
> -	int ret;
> -	long tr;
> -
> -	ret = __ti_thermal_get_trend(thermal->devdata, &tr);
> -	if (ret)
> -		return ret;
> -
>   	if (tr > 0)
>   		*trend = THERMAL_TREND_RAISING;
>   	else if (tr < 0)
> @@ -278,6 +262,13 @@ static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
>   	return 0;
>   }
>
> +/* Get the temperature trend callback functions for thermal zone */
> +static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
> +				int trip, enum thermal_trend *trend)
> +{
> +	return __ti_thermal_get_trend(thermal->devdata, trip, trend);
> +}
> +
>   /* Get critical temperature callback functions for thermal zone */
>   static int ti_thermal_get_crit_temp(struct thermal_zone_device *thermal,
>   				    int *temp)
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 2440b8d..d3ce3a5 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -352,7 +352,7 @@ struct thermal_genl_event {
>    */
>   struct thermal_zone_of_device_ops {
>   	int (*get_temp)(void *, int *);
> -	int (*get_trend)(void *, long *);
> +	int (*get_trend)(void *, int, enum thermal_trend *);
>   	int (*set_trips)(void *, int, int);
>   	int (*set_emul_temp)(void *, int);
>   	int (*set_trip_temp)(void *, int, int);
>

Re: [PATCH v5.1 3/5] thermal: streamline get_trend callbacks

[Keerthy]

On Wednesday 08 June 2016 09:09 AM, Keerthy wrote:
>
>
> On Tuesday 07 June 2016 06:31 PM, Caesar Wang wrote:
>> From: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>>
>> The .get_trend callback in struct thermal_zone_device_ops has
>> the prototype:
>>          int (*get_trend) (struct thermal_zone_device *, int,
>>                            enum thermal_trend *);
>> whereas the .get_trend callback in struct thermal_zone_of_device_ops
>> has:
>>          int (*get_trend)(void *, long *);
>>
>> Streamline both prototypes and add the trip argument to the OF callback
>> aswell and use enum thermal_trend * instead of an integer pointer.
>>
>> While the OF prototype may be the better one, this should be decided at
>> framework level and not on OF level.
>>
>> Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>> Signed-off-by: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>> Cc: Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>> Cc: Eduardo Valentin <edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Reviewed-by: Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>
>>
>> ---
>>
>> Changes in v5.1:
>> - As the Keerthy comments, change the get_trend for of_thermal.c
>> - Add the Kee's Reviewed-by, I can remove it if you object it.
>
> Looks go to me.

I meant LGTM.

>
>> - I'm assumed that the Eduardo will apply it. I can do it if Eduardo
>> wants
>>    me to resend them.
>>
>> Changes in v5: None
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2: None
>>
>>   drivers/thermal/of-thermal.c                       | 16 +-------------
>>   drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 25
>> +++++++---------------
>>   include/linux/thermal.h                            |  2 +-
>>   3 files changed, 10 insertions(+), 33 deletions(-)
>>
>> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
>> index 2d2a06f..20822ab 100644
>> --- a/drivers/thermal/of-thermal.c
>> +++ b/drivers/thermal/of-thermal.c
>> @@ -202,25 +202,11 @@ static int of_thermal_get_trend(struct
>> thermal_zone_device *tz, int trip,
>>                   enum thermal_trend *trend)
>>   {
>>       struct __thermal_zone *data = tz->devdata;
>> -    long dev_trend;
>> -    int r;
>>
>>       if (!data->ops->get_trend)
>>           return -EINVAL;
>>
>> -    r = data->ops->get_trend(data->sensor_data, &dev_trend);
>> -    if (r)
>> -        return r;
>> -
>> -    /* TODO: These intervals might have some thresholds, but in core
>> code */
>> -    if (dev_trend > 0)
>> -        *trend = THERMAL_TREND_RAISING;
>> -    else if (dev_trend < 0)
>> -        *trend = THERMAL_TREND_DROPPING;
>> -    else
>> -        *trend = THERMAL_TREND_STABLE;
>> -
>> -    return 0;
>> +    return data->ops->get_trend(data->sensor_data, trip, trend);
>>   }
>>
>>   static int of_thermal_bind(struct thermal_zone_device *thermal,
>> diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
>> b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
>> index 15c0a9a..4a6757c 100644
>> --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
>> +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
>> @@ -239,7 +239,7 @@ static int ti_thermal_get_trip_temp(struct
>> thermal_zone_device *thermal,
>>       return 0;
>>   }
>>
>> -static int __ti_thermal_get_trend(void *p, long *trend)
>> +static int __ti_thermal_get_trend(void *p, int trip, enum
>> thermal_trend *trend)
>>   {
>>       struct ti_thermal_data *data = p;
>>       struct ti_bandgap *bgp;
>> @@ -252,22 +252,6 @@ static int __ti_thermal_get_trend(void *p, long
>> *trend)
>>       if (ret)
>>           return ret;
>>
>> -    *trend = tr;
>> -
>> -    return 0;
>> -}
>> -
>> -/* Get the temperature trend callback functions for thermal zone */
>> -static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
>> -                int trip, enum thermal_trend *trend)
>> -{
>> -    int ret;
>> -    long tr;
>> -
>> -    ret = __ti_thermal_get_trend(thermal->devdata, &tr);
>> -    if (ret)
>> -        return ret;
>> -
>>       if (tr > 0)
>>           *trend = THERMAL_TREND_RAISING;
>>       else if (tr < 0)
>> @@ -278,6 +262,13 @@ static int ti_thermal_get_trend(struct
>> thermal_zone_device *thermal,
>>       return 0;
>>   }
>>
>> +/* Get the temperature trend callback functions for thermal zone */
>> +static int ti_thermal_get_trend(struct thermal_zone_device *thermal,
>> +                int trip, enum thermal_trend *trend)
>> +{
>> +    return __ti_thermal_get_trend(thermal->devdata, trip, trend);
>> +}
>> +
>>   /* Get critical temperature callback functions for thermal zone */
>>   static int ti_thermal_get_crit_temp(struct thermal_zone_device
>> *thermal,
>>                       int *temp)
>> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
>> index 2440b8d..d3ce3a5 100644
>> --- a/include/linux/thermal.h
>> +++ b/include/linux/thermal.h
>> @@ -352,7 +352,7 @@ struct thermal_genl_event {
>>    */
>>   struct thermal_zone_of_device_ops {
>>       int (*get_temp)(void *, int *);
>> -    int (*get_trend)(void *, long *);
>> +    int (*get_trend)(void *, int, enum thermal_trend *);
>>       int (*set_trips)(void *, int, int);
>>       int (*set_emul_temp)(void *, int);
>>       int (*set_trip_temp)(void *, int, int);
>>

Re: [PATCH v5 0/5] Thermal: Support for hardware-tracked trip points

[Zhang Rui]

On 二, 2016-06-21 at 09:42 +0800, Caesar Wang wrote:
> Do you have other ideas for the following patches? :-) 
> Even if only took two weeks feel after a long time.
> 
> 9157919 New          [v5,1/5] thermal: Add support for hardware-
> tracked trip points
> 9157917 New          [v5,2/5] thermal: of: implement .set_trips for
> device tree thermal zones
> 9161129 New          [v5.1,3/5] thermal: streamline get_trend
> callbacks
> 9157929 New          [v5,4/5] thermal: bang-bang governor: act on
> lower trip boundary
> 9157925 New          [v5,5/5] thermal: rockchip: add the set_trips
> function
> ---
> 
I have no objections to this patch set, except one change in patch 1/5.
But as this also touches of_thermal and rockchip thermal driver. I'd
leave this patch set for Eduardo to review and take.
BTW, Eduardo is traveling recently, so you may still need to wait some
time.

Thanks,
rui
> 
> Caesar
> 
> On 2016年06月06日 19:44, Caesar Wang wrote:
> > Thank you all for providing inputs and comments on previous
> > versions of
> > this patchset.
> > Especially thanks to the (Mikko,Sascha,Eduardo,Javi,Steve....).
> > 
> > The history patches come from Mikko and Sascha.
> >     http://thread.gmane.org/gmane.linux.power-management.general/59
> > 451
> > 
> > Now, I pick them up to continue upstream.
> > Nevermind!
> > 
> > This series history patches:
> > v4: https://lkml.org/lkml/2016/5/27/122
> > v3: https://lkml.org/lkml/2016/5/24/797
> > v2: https://lkml.org/lkml/2016/5/3/220
> > v1: https://lkml.org/lkml/2016/4/24/227
> > 
> > This series adds support for hardware trip points. It picks up
> > earlier
> > work from Mikko Perttunen. Mikko implemented hardware trip points
> > as part
> > of the device tree support. It was suggested back then to move the
> > functionality to the thermal core instead of putting more code into
> > the
> > device tree support. This series does exactly that.
> > 
> > This series patches rebase the conflicts with the lastest next
> > kernel.
> > Note that the hardware-tracked trip points are very well tested
> > currently.
> > 
> > Verified and tested on https://github.com/Caesar-github/rockchip/tr
> > ee/wip/fixes-thermal-0606
> > That's based on the next kernel (4.7-rc2).
> > localhost / # cat /proc/version
> > Linux version 4.7.0-rc2-next-20160606-02546-g534926d (wxt@nb)
> > ---
> > There are five pathes in this series.
> > thermal: Add support for hardware-tracked trip point
> > thermal: of: implement .set_trips for device tree thermal zones
> > thermal: streamline get_trend callbacks
> > thermal: bang-bang governor: act on lower trip boundary
> > thermal: rockchip: add the set_trips function
> > 
> > Note: the hardware-tracked trip points that the similar patches
> > were verified
> > on ChromoeOs platform.
> > e.g.:
> > https://chromium.googlesource.com/chromiumos/third_party/kernel/+/c
> > hromeos-3.14
> > https://chromium.googlesource.com/chromiumos/third_party/kernel/+/c
> > hromeos-3.18
> > https://chromium.googlesource.com/chromiumos/third_party/kernel/+/c
> > hromeos-4.4
> > ---
> > 
> > Anyway, I take the lastest thermal change to test from next kernel,
> > 
> > Tested on RK3399 SoCs on https://chromium.googlesource.com/chromium
> > os/third_party/kernel/+/chromeos-4.4
> > And
> > Tested on RK3288 SoCs with chromebook on next kernel.
> > localhost / # while true; do grep ""
> > /sys/class/thermal/thermal_zone[0-1]/temp; sleep .5; done
> > /sys/class/thermal/thermal_zone1/temp:45454
> > /sys/class/thermal/thermal_zone2/temp:44090
> > /sys/class/thermal/thermal_zone1/temp:44545
> > /sys/class/thermal/thermal_zone2/temp:44545
> > /sys/class/thermal/thermal_zone1/temp:45454
> > /sys/class/thermal/thermal_zone2/temp:44545
> > /sys/class/thermal/thermal_zone1/temp:45000
> > ...
> > Then add the loading,
> > localhost / # md5sum /dev/zero &
> > [3] 8354
> > ..
> > The Set trips trigger the hardware-tracked points.
> > 
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 68461, retval: 0
> > rockchip-thermal ff280000.tsadc: sensor 2 - temp: 64166, retval: 0
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 70000, retval: 0
> > rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor
> > 1: low: 68000, high 75000
> > rockchip-thermal ff280000.tsadc: sensor 2 - temp: 66153, retval: 0
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 69230, retval: 0
> > rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor
> > 1: low: 68000, high 70000
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 68076, retval: 0
> > rockchip-thermal ff280000.tsadc: sensor 2 - temp: 65384, retval: 0
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 69615, retval: 0
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 70000, retval: 0
> > rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor
> > 1: low: 68000, high 75000
> > rockchip-thermal ff280000.tsadc: sensor 2 - temp: 65384, retval: 0
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 69615, retval: 0
> > rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor
> > 1: low: 68000, high 70000
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 69615, retval: 0
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 69230, retval: 0
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 70833, retval: 0
> > rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor
> > 1: low: 68000, high 75000
> > rockchip-thermal ff280000.tsadc: sensor 2 - temp: 66153, retval: 0
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 69230, retval: 0
> > rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor
> > 1: low: 68000, high 70000
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 70416, retval: 0
> > rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor
> > 1: low: 68000, high 75000
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 70000, retval: 0
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 69615, retval: 0
> > rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor
> > 1: low: 68000, high 70000
> > rockchip-thermal ff280000.tsadc: sensor 1 - temp: 70000, retval: 0
> > rockchip-thermal ff280000.tsadc: rockchip_thermal_set_trips: sensor
> > 1: low: 68000, high 75000
> > ..
> > ---
> > Anyway, the series patches are verified on rockchip platform.
> > 
> > Thanks someone are reviewing and testing for it.
> > 
> > -Caesar
> > 
> > 
> > Changes in v5:
> > - add the lock for thermal_zone_set_trips function.
> > - change based on next kernel.
> > - add the tested by Steve.
> > 
> > Changes in v4:
> > - Missing the lock added in v3.
> > - as the Javi comments, %s/implemnets/implements.
> > 
> > Changes in v3:
> > - as Javi comments on https://patchwork.kernel.org/patch/9001281/.
> > - add the lock for preventing the called from multi placce
> > - add the note for pre_low/high_trip.
> > - as the Javi comments on https://patchwork.kernel.org/patch/900131
> > 1/.
> > - add the select if they set the option for devicetree.
> > - Add the peter's ACK.
> > 
> > Changes in v2:
> > - update the sysfs-api.txt for set_trips.
> > - add the commit in patch[v2 2/5].
> > - Update the commit for patch[v2 4/5].
> > 
> > Caesar Wang (1):
> >   thermal: rockchip: add the set_trips function
> > 
> > Sascha Hauer (4):
> >   thermal: Add support for hardware-tracked trip points
> >   thermal: of: implement .set_trips for device tree thermal zones
> >   thermal: streamline get_trend callbacks
> >   thermal: bang-bang governor: act on lower trip boundary
> > 
> >  Documentation/thermal/sysfs-api.txt                |  7 +++
> >  drivers/thermal/gov_bang_bang.c                    |  2 +-
> >  drivers/thermal/of-thermal.c                       | 30 ++++++++
> > ----
> >  drivers/thermal/rockchip_thermal.c                 | 39
> > ++++++++++++++++
> >  drivers/thermal/thermal_core.c                     | 54
> > ++++++++++++++++++++++
> >  drivers/thermal/thermal_sysfs.c                    |  3 ++
> >  drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 25 ++++------
> >  include/linux/thermal.h                            | 16 ++++++-
> >  8 files changed, 147 insertions(+), 29 deletions(-)
> > 
>  

Re: [PATCH v5 0/5] Thermal: Support for hardware-tracked trip points

[Caesar Wang]

On 2016年06月22日 11:25, Zhang Rui wrote:
> On 二, 2016-06-21 at 09:42 +0800, Caesar Wang wrote:
>> Do you have other ideas for the following patches? :-)
>> Even if only took two weeks feel after a long time.
>>
>> 9157919 New          [v5,1/5] thermal: Add support for hardware-
>> tracked trip points
>> 9157917 New          [v5,2/5] thermal: of: implement .set_trips for
>> device tree thermal zones
>> 9161129 New          [v5.1,3/5] thermal: streamline get_trend
>> callbacks
>> 9157929 New          [v5,4/5] thermal: bang-bang governor: act on
>> lower trip boundary
>> 9157925 New          [v5,5/5] thermal: rockchip: add the set_trips
>> function
>> ---
>>
> I have no objections to this patch set, except one change in patch 1/5.
> But as this also touches of_thermal and rockchip thermal driver. I'd
> leave this patch set for Eduardo to review and take.
> BTW, Eduardo is traveling recently, so you may still need to wait some
> time.

Okay, thanks for your reminder. and sorry for the noise.:-)

-
Caesar

>
> Thanks,
> rui
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip