From: Roger Quadros <rogerq@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
tony@atomide.com
Cc: kishon@ti.com, nm@ti.com, vigneshr@ti.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] memory: omap-gpmc: Fix menuconfig visibility
Date: Thu, 25 Nov 2021 14:09:53 +0200 [thread overview]
Message-ID: <15a58477-5a8b-6236-be15-ce1d8226fdc8@kernel.org> (raw)
In-Reply-To: <6a8f93a4-7390-1f1e-6ba0-601859c21ac0@canonical.com>
On 23/11/2021 21:43, Krzysztof Kozlowski wrote:
> On 23/11/2021 11:26, Roger Quadros wrote:
>> GPMC was not being visible if COMPILE_TEST is not enabled.
>>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>> ---
>> drivers/memory/Kconfig | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>
> ... which was probably on purpose, similarly to many other SoC drivers
> which are selected by platform. Therefore there is no bug to fix here -
> lack of visibility is not a problem. Please document instead why you
> want to change it, e.g. why this is a problem or unwanted behavior.
>
No strong enough reason. I'll drop this patch.
cheers,
-roger
next prev parent reply other threads:[~2021-11-25 12:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 10:26 [PATCH 0/4] memory: omap-gpmc: Add AM64 SoC support Roger Quadros
2021-11-23 10:26 ` [PATCH 1/4] dt-bindings: memory-controllers: ti,gpmc: Add compatible for AM64 Roger Quadros
2021-11-23 19:47 ` Krzysztof Kozlowski
2021-11-25 12:18 ` Roger Quadros
2021-11-30 22:02 ` Rob Herring
2021-12-01 11:14 ` Roger Quadros
2021-11-23 10:26 ` [PATCH 2/4] memory: gpmc: Fix menuconfig visibility Roger Quadros
2021-11-23 10:27 ` Roger Quadros
2021-11-23 10:26 ` [PATCH 2/4] memory: omap-gpmc: " Roger Quadros
2021-11-23 19:43 ` Krzysztof Kozlowski
2021-11-25 12:09 ` Roger Quadros [this message]
2021-11-23 10:26 ` [PATCH 3/4] memory: omap-gpmc: Add support for GPMC on AM64 SoC Roger Quadros
2021-11-23 10:26 ` [PATCH 3/4] memory: omap-gpmc: " Roger Quadros
2021-11-23 10:28 ` Roger Quadros
2021-11-23 10:26 ` [PATCH 4/4] memory: omap-gpmc: check for nand node name instead of just compatibility Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15a58477-5a8b-6236-be15-ce1d8226fdc8@kernel.org \
--to=rogerq@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox