From: Roger Quadros <rogerq@kernel.org>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: tony@atomide.com, kishon@ti.com, nm@ti.com, vigneshr@ti.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: memory-controllers: ti,gpmc: Add compatible for AM64
Date: Wed, 1 Dec 2021 13:14:58 +0200 [thread overview]
Message-ID: <acc05242-8d0a-093a-c076-af35a339333c@kernel.org> (raw)
In-Reply-To: <YaafXKXfzBQaNSvq@robh.at.kernel.org>
On 01/12/2021 00:02, Rob Herring wrote:
> On Tue, Nov 23, 2021 at 08:47:57PM +0100, Krzysztof Kozlowski wrote:
>> On 23/11/2021 11:26, Roger Quadros wrote:
>>> AM64 SoC contains the GPMC module. Add compatible for it.
>>>
>>> Newer SoCs don't necessarily map GPMC data region at the same place
>>> as legacy SoCs. Add reg-names "data", to provide this information to
>>> the device driver.
>>>
>>> Cc: Rob Herring <robh+dt@kernel.org>
>>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>>> ---
>>> .../bindings/memory-controllers/ti,gpmc.yaml | 12 +++++++++++-
>>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/memory-controllers/ti,gpmc.yaml b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc.yaml
>>> index 25b42d68f9b3..1869cc6f949b 100644
>>> --- a/Documentation/devicetree/bindings/memory-controllers/ti,gpmc.yaml
>>> +++ b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc.yaml
>>> @@ -23,13 +23,20 @@ properties:
>>> items:
>>> - enum:
>>> - ti,am3352-gpmc
>>> + - ti,am64-gpmc
>>> - ti,omap2420-gpmc
>>> - ti,omap2430-gpmc
>>> - ti,omap3430-gpmc
>>> - ti,omap4430-gpmc
>>>
>>> reg:
>>> - maxItems: 1
>>> + minItems: 1
>>> + maxItems: 2
>>> +
>>> + reg-names:
>>> + items:
>>> + - const: cfg
>>> + - const: data
>>
>> I see your driver handles cases with only one reg item, but I have other
>> question - is it correct to have older (ARMv7) platform with two reg
>> items? Or can am64-gpmc come with only one reg?
>> IOW, I am surprised there is no if-else case precising this minItems
>> requirement for different SocS.
>
> I don't think that is needed here. If the assumption is 'reg-names' is
> only present when there are 2 entries, then it is fine. Maybe
> 'reg-names' should be required for ti,am64-gpmc though.
Yes, I'll make 'reg-names' property required for ti,am64-gpmc.
cheers,
-roger
next prev parent reply other threads:[~2021-12-01 11:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 10:26 [PATCH 0/4] memory: omap-gpmc: Add AM64 SoC support Roger Quadros
2021-11-23 10:26 ` [PATCH 1/4] dt-bindings: memory-controllers: ti,gpmc: Add compatible for AM64 Roger Quadros
2021-11-23 19:47 ` Krzysztof Kozlowski
2021-11-25 12:18 ` Roger Quadros
2021-11-30 22:02 ` Rob Herring
2021-12-01 11:14 ` Roger Quadros [this message]
2021-11-23 10:26 ` [PATCH 2/4] memory: gpmc: Fix menuconfig visibility Roger Quadros
2021-11-23 10:27 ` Roger Quadros
2021-11-23 10:26 ` [PATCH 2/4] memory: omap-gpmc: " Roger Quadros
2021-11-23 19:43 ` Krzysztof Kozlowski
2021-11-25 12:09 ` Roger Quadros
2021-11-23 10:26 ` [PATCH 3/4] memory: omap-gpmc: Add support for GPMC on AM64 SoC Roger Quadros
2021-11-23 10:26 ` [PATCH 3/4] memory: omap-gpmc: " Roger Quadros
2021-11-23 10:28 ` Roger Quadros
2021-11-23 10:26 ` [PATCH 4/4] memory: omap-gpmc: check for nand node name instead of just compatibility Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acc05242-8d0a-093a-c076-af35a339333c@kernel.org \
--to=rogerq@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox