Re: [PATCH 00/23] twl4030 patches (v3)

Re: [PATCH 00/23] twl4030 patches (v3)

[David Brownell]

Well I can confirm that this is stuff I've seen to behave OK,
by diffing the patches against known-working versions.  There
were Overo differences, and some keymap things.

Patch 0002 (don't zero pullup/pulldown configuration) is still
missing the ACK I sent when it first came though.  :)


On the other hand, building against the tarball of patches
you sent gives me:

arch/arm/mach-omap2/board-overo.c:154: error: variable 'overo_usb_data' has initializer but incomplete type
arch/arm/mach-omap2/board-overo.c:155: error: unknown field 'usb_mode' specified in initializer
arch/arm/mach-omap2/board-overo.c:155: warning: excess elements in struct initializer
arch/arm/mach-omap2/board-overo.c:155: warning: (near initialization for 'overo_usb_data')
arch/arm/mach-omap2/board-overo.c:162: warning: initialization from incompatible pointer type
make[1]: *** [arch/arm/mach-omap2/board-overo.o] Error 1
make: *** [arch/arm/mach-omap2] Error 2
make: *** Waiting for unfinished jobs....
  CC      arch/arm/plat-omap/i2c.o

---
 arch/arm/mach-omap2/board-overo.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/arm/mach-omap2/board-overo.c
+++ b/arch/arm/mach-omap2/board-overo.c
@@ -151,7 +151,7 @@ static struct twl4030_gpio_platform_data
 	.irq_end	= TWL4030_GPIO_IRQ_END,
 };
 
-static struct twl4030_usb_platform_data overo_usb_data = {
+static struct twl4030_usb_data overo_usb_data = {
 	.usb_mode	= T2_USB_MODE_ULPI,
 };
 

Re: [PATCH 00/23] twl4030 patches (v3)

[Felipe Balbi]

On Mon, Sep 29, 2008 at 01:59:34PM -0700, David Brownell wrote:
> Well I can confirm that this is stuff I've seen to behave OK,
> by diffing the patches against known-working versions.  There
> were Overo differences, and some keymap things.
> 
> Patch 0002 (don't zero pullup/pulldown configuration) is still
> missing the ACK I sent when it first came though.  :)

Damn... i might have missed it when moving the patches around work and
home :-p

Will re-add it.

> On the other hand, building against the tarball of patches
> you sent gives me:

Steve also saw that, it's already fixed :-)

-- 
balbi