[PATCH] Fix omap-gpio warnings when compiling for ARCH_OMAP15XX

[PATCH] Fix omap-gpio warnings when compiling for ARCH_OMAP15XX

[Jonathan McDowell]

When compiling for ARCH_OMAP15XX I get the following compiler warning in
gpio.c:

arch/arm/plat-omap/gpio.c: In function ‘_set_gpio_wakeup’:
arch/arm/plat-omap/gpio.c:848: warning: unused variable ‘flags’

Simple patch below fixes this.

Signed-off-by: Jonathan McDowell <noodles@earth.li>

-----
diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index 8bb4542..bfbe366 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -845,7 +845,10 @@ static inline void _set_gpio_irqenable(struct gpio_bank *bank, int gpio, int ena
  */
 static int _set_gpio_wakeup(struct gpio_bank *bank, int gpio, int enable)
 {
+#if defined(CONFIG_ARCH_OMAP16XX) || defined(CONFIG_ARCH_OMAP24XX) || \
+		defined(CONFIG_ARCH_OMAP34XX)
 	unsigned long flags;
+#endif
 
 	switch (bank->method) {
 #ifdef CONFIG_ARCH_OMAP16XX
-----

J.

-- 
Web [   Asking whether machines can think is like asking whether   ]
site: http:// [           submarines can swim.           ]       Made by
www.earth.li/~noodles/  [                      ]         HuggieTag 0.0.23
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fix omap-gpio warnings when compiling for ARCH_OMAP15XX

[Tony Lindgren]

* Jonathan McDowell <noodles@earth.li> [081111 15:44]:
> When compiling for ARCH_OMAP15XX I get the following compiler warning in
> gpio.c:
> 
> arch/arm/plat-omap/gpio.c: In function ‘_set_gpio_wakeup’:
> arch/arm/plat-omap/gpio.c:848: warning: unused variable ‘flags’
> 
> Simple patch below fixes this.

Sorry for the delay on responding to this.. Let's rather start
splitting the gpio code into common code and processor specific code
to fix issues like this for good. In this case, we would only register
set_wakeup functions for 16xx, 24xx, and 34xx.

Regards,

Tony

> 
> Signed-off-by: Jonathan McDowell <noodles@earth.li>
> 
> -----
> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> index 8bb4542..bfbe366 100644
> --- a/arch/arm/plat-omap/gpio.c
> +++ b/arch/arm/plat-omap/gpio.c
> @@ -845,7 +845,10 @@ static inline void _set_gpio_irqenable(struct gpio_bank *bank, int gpio, int ena
>   */
>  static int _set_gpio_wakeup(struct gpio_bank *bank, int gpio, int enable)
>  {
> +#if defined(CONFIG_ARCH_OMAP16XX) || defined(CONFIG_ARCH_OMAP24XX) || \
> +		defined(CONFIG_ARCH_OMAP34XX)
>  	unsigned long flags;
> +#endif
>  
>  	switch (bank->method) {
>  #ifdef CONFIG_ARCH_OMAP16XX
> -----
> 
> J.
> 
> -- 
> Web [   Asking whether machines can think is like asking whether   ]
> site: http:// [           submarines can swim.           ]       Made by
> www.earth.li/~noodles/  [                      ]         HuggieTag 0.0.23
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fix omap-gpio warnings when compiling for ARCH_OMAP15XX

[David Brownell]

On Wednesday 26 November 2008, Tony Lindgren wrote:
> Let's rather start
> splitting the gpio code into common code and processor specific code
> to fix issues like this for good.

Working on that.  :)