From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Kanigeri, Hari" <h-kanigeri2@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"tony@atomide.com" <tony@atomide.com>,
Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
"Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Subject: Re: [PATCH v1 3/3] ARM:OMAP4 iommu:provide build support for omap4 iommu
Date: Tue, 4 Aug 2009 23:42:41 +0100 [thread overview]
Message-ID: <20090804224241.GA17716@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <8F7AF80515AF0D4D93307E594F3CB40E3ABDBAC2@dlee03.ent.ti.com>
On Tue, Aug 04, 2009 at 05:32:12PM -0500, Kanigeri, Hari wrote:
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index efe85d0..50aaefb 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -118,8 +118,11 @@ config OMAP_MBOX_FWK
> DSP, IVA1.0 and IVA2 in OMAP1/2/3.
>
> config OMAP_IOMMU
> - tristate
> -
> + tristate "iommu"
Insufficiently verbose description. "OMAP IOMMU Support" would be
better. I thought the idea here was to arrange for things to select
OMAP_IOMMU when they require it rather than offering it as a separate
configuration option.
The former way has the advantage that you don't need to know that you
need IOMMU support to (eg) use the Camera - enabling the Camera
should automatically enable IOMMU support.
next prev parent reply other threads:[~2009-08-04 22:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 22:32 [PATCH v1 3/3] ARM:OMAP4 iommu:provide build support for omap4 iommu Kanigeri, Hari
2009-08-04 22:42 ` Russell King - ARM Linux [this message]
2009-08-05 4:35 ` Hiroshi DOYU
2009-08-05 7:52 ` Russell King - ARM Linux
2009-08-05 9:15 ` Hiroshi DOYU
2009-08-05 16:44 ` Kanigeri, Hari
2009-08-05 20:22 ` Russell King - ARM Linux
2009-08-06 2:33 ` Kanigeri, Hari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090804224241.GA17716@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Hiroshi.DOYU@nokia.com \
--cc=h-kanigeri2@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox