public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Kanigeri, Hari" <h-kanigeri2@ti.com>
Cc: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"tony@atomide.com" <tony@atomide.com>,
	"Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Subject: Re: [PATCH v1 3/3] ARM:OMAP4 iommu:provide build support for omap4 iommu
Date: Wed, 5 Aug 2009 21:22:59 +0100	[thread overview]
Message-ID: <20090805202259.GA9303@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <8F7AF80515AF0D4D93307E594F3CB40E3ABDC0EF@dlee03.ent.ti.com>

On Wed, Aug 05, 2009 at 11:44:53AM -0500, Kanigeri, Hari wrote:
> -- I agree with your comments from OMAP3 point of view. 
> For OMAP4, I guess Camera is not going to use IOMMU module. IOMMU
> modules will be used only by the IPC that are communicating with 2
> remote Cores (Ducati and Tesla).

In which case what you do is:

config OMAP_CAMERA
	...
	select OMAP_IOMMU if ARCH_OMAP3

which means the IOMMU support will only be built if the camera is enabled
and we're building for OMAP3.

However, if the OMAP3 hardware uses the IOMMU but the OMAP4 hardware
doesn't, I'd hazard a guess (and it's only a guess) that the drivers
will be soo different that squeezing them into one file/config option
would be silly.

> Having said this, there might not
> be any clients of IOMMU in the Kernel space as we are looking at
> the option of using the IOMMU as a character driver from User-space.
> For this reason, I think we should have the configuration option to
> build iommu. Please let me know your comments.

In which case, the IOMMU character driver can select the core IOMMU
support.

Making symbols which are 'selected' visible causes problems - you
can't disable them and you can't work out why they're being
forcefully enabled, which just annoys people who are trying to
configure the kernel.

  reply	other threads:[~2009-08-05 20:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-04 22:32 [PATCH v1 3/3] ARM:OMAP4 iommu:provide build support for omap4 iommu Kanigeri, Hari
2009-08-04 22:42 ` Russell King - ARM Linux
2009-08-05  4:35   ` Hiroshi DOYU
2009-08-05  7:52     ` Russell King - ARM Linux
2009-08-05  9:15       ` Hiroshi DOYU
2009-08-05 16:44     ` Kanigeri, Hari
2009-08-05 20:22       ` Russell King - ARM Linux [this message]
2009-08-06  2:33         ` Kanigeri, Hari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090805202259.GA9303@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=h-kanigeri2@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox