public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Enric Balletbo i Serra <eballetbo@gmail.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Enric Balletbo i Serra <eballetbo@iseebcn.com>
Subject: Re: [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
Date: Tue, 16 Mar 2010 08:55:35 +0200	[thread overview]
Message-ID: <20100316065535.GB5438@nokia.com> (raw)
In-Reply-To: <1267455756-5081-1-git-send-email-eballetbo@gmail.com>

On Mon, Mar 01, 2010 at 04:02:36PM +0100, ext Enric Balletbo i Serra wrote:
>From: Enric Balletbo i Serra <eballetbo@iseebcn.com>
>
>IGEP v2 uses EHCI port 1 instead of EHCI port 2.
>
>Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>

I'm happy with the explanation:

Acked-by: Felipe Balbi <felipe.balbi@nokia.com>

>---
> arch/arm/mach-omap2/board-igep0020.c |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c
>index 3c7789d..d55c57b 100644
>--- a/arch/arm/mach-omap2/board-igep0020.c
>+++ b/arch/arm/mach-omap2/board-igep0020.c
>@@ -458,13 +458,13 @@ static struct omap_musb_board_data musb_board_data = {
> };
>
> static const struct ehci_hcd_omap_platform_data ehci_pdata __initconst = {
>-	.port_mode[0] = EHCI_HCD_OMAP_MODE_UNKNOWN,
>-	.port_mode[1] = EHCI_HCD_OMAP_MODE_PHY,
>+	.port_mode[0] = EHCI_HCD_OMAP_MODE_PHY,
>+	.port_mode[1] = EHCI_HCD_OMAP_MODE_UNKNOWN,
> 	.port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN,
>
> 	.phy_reset = true,
>-	.reset_gpio_port[0] = -EINVAL,
>-	.reset_gpio_port[1] = IGEP2_GPIO_USBH_NRESET,
>+	.reset_gpio_port[0] = IGEP2_GPIO_USBH_NRESET,
>+	.reset_gpio_port[1] = -EINVAL,
> 	.reset_gpio_port[2] = -EINVAL,
> };
>
>-- 
>1.5.4.3
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi

      parent reply	other threads:[~2010-03-16  6:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-01 15:02 [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board Enric Balletbo i Serra
2010-03-15 16:03 ` Felipe Balbi
     [not found]   ` <70c9a9111003151005j1233d8ffhe6c8f3440c1a4864@mail.gmail.com>
     [not found]     ` <70c9a9111003151006x41a1a965j4efa2edcaf5eeb90@mail.gmail.com>
2010-03-15 17:07       ` Enric Balletbò i Serra
2010-03-15 18:01         ` Felipe Balbi
2010-03-15 18:20           ` Enric Balletbò i Serra
2010-03-15 19:07             ` Felipe Balbi
2010-03-16  6:55 ` Felipe Balbi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100316065535.GB5438@nokia.com \
    --to=felipe.balbi@nokia.com \
    --cc=eballetbo@gmail.com \
    --cc=eballetbo@iseebcn.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox