[PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.

public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
@ 2010-03-01 15:02 Enric Balletbo i Serra
  2010-03-15 16:03 ` Felipe Balbi
  2010-03-16  6:55 ` Felipe Balbi
  0 siblings, 2 replies; 7+ messages in thread
From: Enric Balletbo i Serra @ 2010-03-01 15:02 UTC (permalink / raw)
  To: linux-omap; +Cc: Enric Balletbo i Serra

From: Enric Balletbo i Serra <eballetbo@iseebcn.com>

IGEP v2 uses EHCI port 1 instead of EHCI port 2.

Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>
---
 arch/arm/mach-omap2/board-igep0020.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c
index 3c7789d..d55c57b 100644
--- a/arch/arm/mach-omap2/board-igep0020.c
+++ b/arch/arm/mach-omap2/board-igep0020.c
@@ -458,13 +458,13 @@ static struct omap_musb_board_data musb_board_data = {
 };
 
 static const struct ehci_hcd_omap_platform_data ehci_pdata __initconst = {
-	.port_mode[0] = EHCI_HCD_OMAP_MODE_UNKNOWN,
-	.port_mode[1] = EHCI_HCD_OMAP_MODE_PHY,
+	.port_mode[0] = EHCI_HCD_OMAP_MODE_PHY,
+	.port_mode[1] = EHCI_HCD_OMAP_MODE_UNKNOWN,
 	.port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN,
 
 	.phy_reset = true,
-	.reset_gpio_port[0] = -EINVAL,
-	.reset_gpio_port[1] = IGEP2_GPIO_USBH_NRESET,
+	.reset_gpio_port[0] = IGEP2_GPIO_USBH_NRESET,
+	.reset_gpio_port[1] = -EINVAL,
 	.reset_gpio_port[2] = -EINVAL,
 };
 
-- 
1.5.4.3


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
  2010-03-01 15:02 [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board Enric Balletbo i Serra
@ 2010-03-15 16:03 ` Felipe Balbi
       [not found]   ` <70c9a9111003151005j1233d8ffhe6c8f3440c1a4864@mail.gmail.com>
  2010-03-16  6:55 ` Felipe Balbi
  1 sibling, 1 reply; 7+ messages in thread
From: Felipe Balbi @ 2010-03-15 16:03 UTC (permalink / raw)
  To: Enric Balletbo i Serra; +Cc: linux-omap, Enric Balletbo i Serra

Hi,

On Mon, Mar 01, 2010 at 04:02:36PM +0100, Enric Balletbo i Serra wrote:
> @@ -458,13 +458,13 @@ static struct omap_musb_board_data musb_board_data = {
>  };
>  
>  static const struct ehci_hcd_omap_platform_data ehci_pdata __initconst = {
> -	.port_mode[0] = EHCI_HCD_OMAP_MODE_UNKNOWN,
> -	.port_mode[1] = EHCI_HCD_OMAP_MODE_PHY,
> +	.port_mode[0] = EHCI_HCD_OMAP_MODE_PHY,
> +	.port_mode[1] = EHCI_HCD_OMAP_MODE_UNKNOWN,
>  	.port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN,
>  
>  	.phy_reset = true,
> -	.reset_gpio_port[0] = -EINVAL,
> -	.reset_gpio_port[1] = IGEP2_GPIO_USBH_NRESET,
> +	.reset_gpio_port[0] = IGEP2_GPIO_USBH_NRESET,
> +	.reset_gpio_port[1] = -EINVAL,

no way to be backwards compatible ? Is it worth to be backwards
compatible ?

-- 
balbi


^ permalink raw reply	[flat|nested] 7+ messages in thread

[parent not found: <70c9a9111003151005j1233d8ffhe6c8f3440c1a4864@mail.gmail.com>]

[parent not found: <70c9a9111003151006x41a1a965j4efa2edcaf5eeb90@mail.gmail.com>]

* Re: [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
       [not found]     ` <70c9a9111003151006x41a1a965j4efa2edcaf5eeb90@mail.gmail.com>
@ 2010-03-15 17:07       ` Enric Balletbò i Serra
  2010-03-15 18:01         ` Felipe Balbi
  0 siblings, 1 reply; 7+ messages in thread
From: Enric Balletbò i Serra @ 2010-03-15 17:07 UTC (permalink / raw)
  To: linux-omap

Hello,

Felipe, sorry but I don't understand your questions,m maybe I'm
missing something.

All IGEP v2 boards uses USB1HS EHCI port. My mistake was suppose that
port_mode[1] --> EHCI USB1HS but this is not correct, the EHCI USB1HS
is port_mode[0]. This patch only fixes this.

Best regards,

Enric

>> 2010/3/15 Felipe Balbi <me@felipebalbi.com>
>>>
>>> Hi,
>>>
>>> On Mon, Mar 01, 2010 at 04:02:36PM +0100, Enric Balletbo i Serra wrote:
>>> > @@ -458,13 +458,13 @@ static struct omap_musb_board_data musb_board_data = {
>>> >  };
>>> >
>>> >  static const struct ehci_hcd_omap_platform_data ehci_pdata __initconst = {
>>> > -     .port_mode[0] = EHCI_HCD_OMAP_MODE_UNKNOWN,
>>> > -     .port_mode[1] = EHCI_HCD_OMAP_MODE_PHY,
>>> > +     .port_mode[0] = EHCI_HCD_OMAP_MODE_PHY,
>>> > +     .port_mode[1] = EHCI_HCD_OMAP_MODE_UNKNOWN,
>>> >       .port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN,
>>> >
>>> >       .phy_reset = true,
>>> > -     .reset_gpio_port[0] = -EINVAL,
>>> > -     .reset_gpio_port[1] = IGEP2_GPIO_USBH_NRESET,
>>> > +     .reset_gpio_port[0] = IGEP2_GPIO_USBH_NRESET,
>>> > +     .reset_gpio_port[1] = -EINVAL,
>>>
>>> no way to be backwards compatible ? Is it worth to be backwards
>>> compatible ?
>>>
>>> --
>>> balbi
>>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
  2010-03-15 17:07       ` Enric Balletbò i Serra
@ 2010-03-15 18:01         ` Felipe Balbi
  2010-03-15 18:20           ` Enric Balletbò i Serra
  0 siblings, 1 reply; 7+ messages in thread
From: Felipe Balbi @ 2010-03-15 18:01 UTC (permalink / raw)
  To: Enric Balletb? i Serra; +Cc: linux-omap

Hi,

please don't top-post. Read more at [1].

On Mon, Mar 15, 2010 at 06:07:48PM +0100, Enric Balletb? i Serra wrote:
> Felipe, sorry but I don't understand your questions,m maybe I'm
> missing something.

is there a IGEP v1 board available ? Are there any developers around
using it ? If true, you should try to be backwards compatible.

[1] http://www.elinux.org/Netiquette

-- 
balbi

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
  2010-03-15 18:01         ` Felipe Balbi
@ 2010-03-15 18:20           ` Enric Balletbò i Serra
  2010-03-15 19:07             ` Felipe Balbi
  0 siblings, 1 reply; 7+ messages in thread
From: Enric Balletbò i Serra @ 2010-03-15 18:20 UTC (permalink / raw)
  To: me; +Cc: linux-omap

Hi,

2010/3/15 Felipe Balbi <me@felipebalbi.com>:
> Hi,
>
> please don't top-post. Read more at [1].

Sorry

> is there a IGEP v1 board available ? Are there any developers around
> using it ? If true, you should try to be backwards compatible.

Yes, IGEP v1 is available but it's a different platform with different processor
and aren't compatible.

See http://www.igep-platform.com.

 - IGEPv1 is low-power and fan-less single board computer based on ATMEL
 ARM9 processor.

 - IGEPv2 is low-power and fan-less single board computer based on
OMAP35x processor.

Regards,

--
Enric

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
  2010-03-15 18:20           ` Enric Balletbò i Serra
@ 2010-03-15 19:07             ` Felipe Balbi
  0 siblings, 0 replies; 7+ messages in thread
From: Felipe Balbi @ 2010-03-15 19:07 UTC (permalink / raw)
  To: Enric Balletb? i Serra; +Cc: me, linux-omap

Hi,

On Mon, Mar 15, 2010 at 07:20:29PM +0100, Enric Balletb? i Serra wrote:
> > please don't top-post. Read more at [1].
> 
> Sorry

np

> Yes, IGEP v1 is available but it's a different platform with different processor
> and aren't compatible.
> 
> See http://www.igep-platform.com.
> 
>  - IGEPv1 is low-power and fan-less single board computer based on ATMEL
>  ARM9 processor.
> 
>  - IGEPv2 is low-power and fan-less single board computer based on
> OMAP35x processor.

now I get it. Thanks for the info :-)

cool boards.

-- 
balbi

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board.
  2010-03-01 15:02 [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board Enric Balletbo i Serra
  2010-03-15 16:03 ` Felipe Balbi
@ 2010-03-16  6:55 ` Felipe Balbi
  1 sibling, 0 replies; 7+ messages in thread
From: Felipe Balbi @ 2010-03-16  6:55 UTC (permalink / raw)
  To: ext Enric Balletbo i Serra
  Cc: linux-omap@vger.kernel.org, Enric Balletbo i Serra

On Mon, Mar 01, 2010 at 04:02:36PM +0100, ext Enric Balletbo i Serra wrote:
>From: Enric Balletbo i Serra <eballetbo@iseebcn.com>
>
>IGEP v2 uses EHCI port 1 instead of EHCI port 2.
>
>Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>

I'm happy with the explanation:

Acked-by: Felipe Balbi <felipe.balbi@nokia.com>

>---
> arch/arm/mach-omap2/board-igep0020.c |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c
>index 3c7789d..d55c57b 100644
>--- a/arch/arm/mach-omap2/board-igep0020.c
>+++ b/arch/arm/mach-omap2/board-igep0020.c
>@@ -458,13 +458,13 @@ static struct omap_musb_board_data musb_board_data = {
> };
>
> static const struct ehci_hcd_omap_platform_data ehci_pdata __initconst = {
>-	.port_mode[0] = EHCI_HCD_OMAP_MODE_UNKNOWN,
>-	.port_mode[1] = EHCI_HCD_OMAP_MODE_PHY,
>+	.port_mode[0] = EHCI_HCD_OMAP_MODE_PHY,
>+	.port_mode[1] = EHCI_HCD_OMAP_MODE_UNKNOWN,
> 	.port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN,
>
> 	.phy_reset = true,
>-	.reset_gpio_port[0] = -EINVAL,
>-	.reset_gpio_port[1] = IGEP2_GPIO_USBH_NRESET,
>+	.reset_gpio_port[0] = IGEP2_GPIO_USBH_NRESET,
>+	.reset_gpio_port[1] = -EINVAL,
> 	.reset_gpio_port[2] = -EINVAL,
> };
>
>-- 
>1.5.4.3
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2010-03-16  6:56 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-01 15:02 [PATCH RESEND] omap3: Fix EHCI port for IGEP v2 board Enric Balletbo i Serra
2010-03-15 16:03 ` Felipe Balbi
     [not found]   ` <70c9a9111003151005j1233d8ffhe6c8f3440c1a4864@mail.gmail.com>
     [not found]     ` <70c9a9111003151006x41a1a965j4efa2edcaf5eeb90@mail.gmail.com>
2010-03-15 17:07       ` Enric Balletbò i Serra
2010-03-15 18:01         ` Felipe Balbi
2010-03-15 18:20           ` Enric Balletbò i Serra
2010-03-15 19:07             ` Felipe Balbi
2010-03-16  6:55 ` Felipe Balbi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox