From: Jarkko Nikula <jhnikula@gmail.com>
To: Jorge Eduardo Candelaria <jorge.candelaria@ti.com>
Cc: linux-omap@vger.kernel.org, Margarita Olaya Cabrera <magi.olaya@ti.com>
Subject: Re: [PATCH v2 2/2] ARM: McBSP: Add support for omap4 in McBSP driver
Date: Wed, 12 May 2010 11:15:08 +0300 [thread overview]
Message-ID: <20100512111508.48780edb.jhnikula@gmail.com> (raw)
In-Reply-To: <1273108546-2507-3-git-send-email-jorge.candelaria@ti.com>
On Wed, 5 May 2010 20:15:46 -0500
Jorge Eduardo Candelaria <jorge.candelaria@ti.com> wrote:
> McBSP module in OMAP4 needs to be able to set its tx/rx threshold
> and enable the transmitter/receiver when starting an audio stream.
>
> Signed-off-by: Jorge Eduardo Candelaria <jorge.candelaria@ti.com>
> Signed-off-by: Margarita Olaya Cabrera <magi.olaya@ti.com>
> ---
...
> @@ -899,7 +899,7 @@ void omap_mcbsp_stop(unsigned int id, int tx, int rx)
>
> /* Reset receiver */
> rx &= 1;
> - if (cpu_is_omap2430() || cpu_is_omap34xx()) {
> + if (cpu_is_omap2430() || cpu_is_omap34xx() || cpu_is_omap44xx) {
Parentheses missing here from cpu_is_omap44xx. Otherwise looks good.
--
Jarkko
next prev parent reply other threads:[~2010-05-12 8:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 1:15 [PATCH v2 0/0] McBSP changes for OMAP4 platform Jorge Eduardo Candelaria
2010-05-06 1:15 ` [PATCH v2 1/2] ARM: McBSP: Fix request for irq in OMAP4 Jorge Eduardo Candelaria
2010-05-06 1:15 ` [PATCH v2 2/2] ARM: McBSP: Add support for omap4 in McBSP driver Jorge Eduardo Candelaria
2010-05-12 8:15 ` Jarkko Nikula [this message]
2010-05-12 8:09 ` [PATCH v2 1/2] ARM: McBSP: Fix request for irq in OMAP4 Jarkko Nikula
2010-05-12 8:39 ` [PATCH v2 0/0] McBSP changes for OMAP4 platform Peter Ujfalusi
2010-05-12 8:49 ` Mark Brown
2010-05-12 9:07 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512111508.48780edb.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=jorge.candelaria@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=magi.olaya@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox