Re: [PATCH 5/6] OMAP: powerdomain: Arch specific funcs for mem control

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

On Tue, 16 Nov 2010 21:08:05 +0530
Rajendra Nayak <rnayak@ti.com> wrote:

> Define the following architecture specific funtions for omap2/3/4

funtions -> functions.

> +/* Common Internal functions used across OMAP rev's*/
> +int _get_mem_bank_onstate_mask(u8 bank)
> +{
> +	switch (bank) {
> +	case 0:
> +		return OMAP_MEM0_ONSTATE_MASK;
> +	case 1:
> +		return OMAP_MEM1_ONSTATE_MASK;
> +	case 2:
> +		return OMAP_MEM2_ONSTATE_MASK;
> +	case 3:
> +		return OMAP_MEM3_ONSTATE_MASK;
> +	case 4:
> +		return OMAP_MEM4_ONSTATE_MASK;
> +	default:
> +		WARN_ON(1); /* should never happen */
> +		return -EEXIST;

EEXIST is the error code for "File exists", so here I would rather
expect something like ENOENT. But I understand that it was already
-EEXIST in the existing code.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com