From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: linux-omap@vger.kernel.org, paul@pwsan.com, b-cousson@ti.com,
khilman@deeprootsystems.com
Subject: Re: [PATCH 2/6] OMAP: powerdomain: Infrastructure to put arch specific code
Date: Tue, 16 Nov 2010 17:11:17 +0100 [thread overview]
Message-ID: <20101116171117.46a13d0a@surf> (raw)
In-Reply-To: <1289921886-5139-3-git-send-email-rnayak@ti.com>
On Tue, 16 Nov 2010 21:08:02 +0530
Rajendra Nayak <rnayak@ti.com> wrote:
> +struct pwrdm_functions {
> + int (*pwrdm_set_next_pwrst)(struct powerdomain *pwrdm, u8 pwrst);
> + int (*pwrdm_read_next_pwrst)(struct powerdomain *pwrdm);
> + int (*pwrdm_read_pwrst)(struct powerdomain *pwrdm);
> + int (*pwrdm_read_prev_pwrst)(struct powerdomain *pwrdm);
> + int (*pwrdm_set_logic_retst)(struct powerdomain *pwrdm, u8 pwrst);
> + int (*pwrdm_set_mem_onst)(struct powerdomain *pwrdm, u8 bank, u8 pwrst);
> + int (*pwrdm_set_mem_retst)(struct powerdomain *pwrdm, u8 bank, u8 pwrst);
> + int (*pwrdm_read_logic_pwrst)(struct powerdomain *pwrdm);
> + int (*pwrdm_read_prev_logic_pwrst)(struct powerdomain *pwrdm);
> + int (*pwrdm_read_logic_retst)(struct powerdomain *pwrdm);
> + int (*pwrdm_read_mem_pwrst)(struct powerdomain *pwrdm, u8 bank);
> + int (*pwrdm_read_prev_mem_pwrst)(struct powerdomain *pwrdm, u8 bank);
> + int (*pwrdm_read_mem_retst)(struct powerdomain *pwrdm, u8 bank);
> + int (*pwrdm_clear_all_prev_pwrst)(struct powerdomain *pwrdm);
> + int (*pwrdm_enable_hdwr_sar)(struct powerdomain *pwrdm);
> + int (*pwrdm_disable_hdwr_sar)(struct powerdomain *pwrdm);
> + int (*pwrdm_set_lowpwrstchange)(struct powerdomain *pwrdm);
> + int (*pwrdm_wait_transition)(struct powerdomain *pwrdm);
> +};
It would probably be great to have some short documentation on this
structure, to detail what are the different operations, what they
should do, etc.
By the way, would pwrdm_operations be more linux-ish than
pwrdm_functions ?
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2010-11-16 16:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 15:38 [PATCH 0/6] Split powerdomain framework into plat specific/independent Rajendra Nayak
2010-11-16 15:38 ` [PATCH 1/6] OMAP: powerdomain: Move powerdomain.c from mach-omap2 to plat-omap Rajendra Nayak
2010-11-16 15:38 ` [PATCH 2/6] OMAP: powerdomain: Infrastructure to put arch specific code Rajendra Nayak
2010-11-16 15:38 ` [PATCH 3/6] OMAP: powerdomain: Arch specific funcs for state control Rajendra Nayak
2010-11-16 15:38 ` [PATCH 4/6] OMAP: powerdomain: Arch specific funcs for logic control Rajendra Nayak
2010-11-16 15:38 ` [PATCH 5/6] OMAP: powerdomain: Arch specific funcs for mem control Rajendra Nayak
2010-11-16 15:38 ` [PATCH 6/6] OMAP4: powerdomain: Add pwrdm_clear_all_prev_pwrst Rajendra Nayak
2010-11-29 0:31 ` Paul Walmsley
2010-11-16 16:09 ` [PATCH 5/6] OMAP: powerdomain: Arch specific funcs for mem control Thomas Petazzoni
2010-11-29 0:28 ` Paul Walmsley
2010-11-29 0:17 ` [PATCH 4/6] OMAP: powerdomain: Arch specific funcs for logic control Paul Walmsley
2010-11-29 0:14 ` [PATCH 3/6] OMAP: powerdomain: Arch specific funcs for state control Paul Walmsley
2010-11-30 15:47 ` Rajendra Nayak
2010-11-16 16:11 ` Thomas Petazzoni [this message]
2010-11-22 6:21 ` [PATCH 2/6] OMAP: powerdomain: Infrastructure to put arch specific code Rajendra Nayak
2010-11-29 0:07 ` Paul Walmsley
2010-11-29 0:05 ` [PATCH 1/6] OMAP: powerdomain: Move powerdomain.c from mach-omap2 to plat-omap Paul Walmsley
2010-11-29 9:22 ` Rajendra Nayak
2010-11-29 0:33 ` [PATCH 0/6] Split powerdomain framework into plat specific/independent Paul Walmsley
2010-11-29 9:24 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116171117.46a13d0a@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=b-cousson@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox