RE: Build error while adding debug LL support for new board

RE: Build error while adding debug LL support for new board

[Mohammed, Afzal]

Hi Russell,

n Mon, Oct 17, 2011 at 18:30:32, Mohammed, Afzal wrote:
> Hi, Russell,
> 
> While adding low level debug support for new board in OMAP2+ family, we
> came across following error,
> 
> arch/arm/kernel/debug.S: Assembler messages:
> arch/arm/kernel/debug.S:138: Error: invalid constant (428) after fixup
> 
> Following patch fixes it, I am not sure whether this is the right fix,
> please let us know your comments.

ping

Regards
Afzal

> From: Afzal Mohammed <afzal@ti.com>
> Date: Fri, 14 Oct 2011 12:56:16 +0530
> Subject: [PATCH] ARM: Fix error upon adding LL debug
> 
> Upon adding new board LL debug support, if the resultant code
> addition would not cause PC relative offset of "hexbuf" from
> "adr r2, hexbuf" (+2) instruction to be representable in a
> shifted 8-bit value (hence indirectly putting higher aligment
> requirement on larger offsets), following error occurs,
> 
> arch/arm/kernel/debug.S: Assembler messages:
> arch/arm/kernel/debug.S:138: Error: invalid constant (428) after fixup
> 
> Fix it by bringing "hexbuf" closer so that "adr"
> can have the offset.
> 
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> ---
>  arch/arm/kernel/debug.S |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/kernel/debug.S b/arch/arm/kernel/debug.S
> index bcd66e0..0f852d0 100644
> --- a/arch/arm/kernel/debug.S
> +++ b/arch/arm/kernel/debug.S
> @@ -151,6 +151,8 @@ printhex:   adr     r2, hexbuf
>                 b       printascii
>  ENDPROC(printhex2)
> 
> +hexbuf:                .space 16
> +
>                 .ltorg
> 
>  ENTRY(printascii)
> @@ -175,5 +177,3 @@ ENTRY(printch)
>                 mov     r0, #0
>                 b       1b
>  ENDPROC(printch)
> -
> -hexbuf:                .space 16
> --
> 1.6.2.4
> 
> 
> 

Re: Build error while adding debug LL support for new board

[Russell King - ARM Linux]

On Thu, Oct 20, 2011 at 05:09:07PM +0530, Mohammed, Afzal wrote:
> Hi Russell,
> 
> n Mon, Oct 17, 2011 at 18:30:32, Mohammed, Afzal wrote:
> > Hi, Russell,
> > 
> > While adding low level debug support for new board in OMAP2+ family, we
> > came across following error,
> > 
> > arch/arm/kernel/debug.S: Assembler messages:
> > arch/arm/kernel/debug.S:138: Error: invalid constant (428) after fixup
> > 
> > Following patch fixes it, I am not sure whether this is the right fix,
> > please let us know your comments.
> 
> ping

The patch looks fine.  Who's merging it?

Re: Build error while adding debug LL support for new board

[Tony Lindgren]

* Russell King - ARM Linux <linux@arm.linux.org.uk> [111020 05:23]:
> On Thu, Oct 20, 2011 at 05:09:07PM +0530, Mohammed, Afzal wrote:
> > Hi Russell,
> > 
> > n Mon, Oct 17, 2011 at 18:30:32, Mohammed, Afzal wrote:
> > > Hi, Russell,
> > > 
> > > While adding low level debug support for new board in OMAP2+ family, we
> > > came across following error,
> > > 
> > > arch/arm/kernel/debug.S: Assembler messages:
> > > arch/arm/kernel/debug.S:138: Error: invalid constant (428) after fixup
> > > 
> > > Following patch fixes it, I am not sure whether this is the right fix,
> > > please let us know your comments.
> > 
> > ping
> 
> The patch looks fine.  Who's merging it?

Can you please take it?

Acked-by: Tony Lindgren <tony@atomide.com>

Re: Build error while adding debug LL support for new board

[Russell King - ARM Linux]

On Thu, Oct 20, 2011 at 09:12:52AM -0700, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [111020 05:23]:
> > On Thu, Oct 20, 2011 at 05:09:07PM +0530, Mohammed, Afzal wrote:
> > > Hi Russell,
> > > 
> > > n Mon, Oct 17, 2011 at 18:30:32, Mohammed, Afzal wrote:
> > > > Hi, Russell,
> > > > 
> > > > While adding low level debug support for new board in OMAP2+ family, we
> > > > came across following error,
> > > > 
> > > > arch/arm/kernel/debug.S: Assembler messages:
> > > > arch/arm/kernel/debug.S:138: Error: invalid constant (428) after fixup
> > > > 
> > > > Following patch fixes it, I am not sure whether this is the right fix,
> > > > please let us know your comments.
> > > 
> > > ping
> > 
> > The patch looks fine.  Who's merging it?
> 
> Can you please take it?
> 
> Acked-by: Tony Lindgren <tony@atomide.com>

If it finds its way into the patch system.  Note that I'm not applying
patches after end of today until after the kernel summit.

Re: Build error while adding debug LL support for new board

[Tony Lindgren]

* Russell King - ARM Linux <linux@arm.linux.org.uk> [111020 09:15]:
> On Thu, Oct 20, 2011 at 09:12:52AM -0700, Tony Lindgren wrote:
> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [111020 05:23]:
> > > On Thu, Oct 20, 2011 at 05:09:07PM +0530, Mohammed, Afzal wrote:
> > > > Hi Russell,
> > > > 
> > > > n Mon, Oct 17, 2011 at 18:30:32, Mohammed, Afzal wrote:
> > > > > Hi, Russell,
> > > > > 
> > > > > While adding low level debug support for new board in OMAP2+ family, we
> > > > > came across following error,
> > > > > 
> > > > > arch/arm/kernel/debug.S: Assembler messages:
> > > > > arch/arm/kernel/debug.S:138: Error: invalid constant (428) after fixup
> > > > > 
> > > > > Following patch fixes it, I am not sure whether this is the right fix,
> > > > > please let us know your comments.
> > > > 
> > > > ping
> > > 
> > > The patch looks fine.  Who's merging it?
> > 
> > Can you please take it?
> > 
> > Acked-by: Tony Lindgren <tony@atomide.com>
> 
> If it finds its way into the patch system.  Note that I'm not applying
> patches after end of today until after the kernel summit.

Afzal, can you please put this into Russell's patch system?
Sounds like this could be applied after the merge window too.

Regards,

Tony

RE: Build error while adding debug LL support for new board

[Mohammed, Afzal]

Hi Tony, Russell,

On Thu, Oct 20, 2011 at 22:41:13, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [111020 09:15]:
> >
:
:
> > If it finds its way into the patch system.  Note that I'm not applying
> > patches after end of today until after the kernel summit.
> 
> Afzal, can you please put this into Russell's patch system?
> Sounds like this could be applied after the merge window too.
> 

Thanks, this has been put into Russell's patch system,

http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7137/1

Regards
Afzal