From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, sameo@linux.intel.com, lrg@ti.com,
khilman@ti.com, b-cousson@ti.com, rnayak@ti.com,
gg@slimlogic.co.uk
Subject: Re: [PATCHv7 6/7] regulator: twl: add support for external controller
Date: Mon, 28 Nov 2011 14:58:25 +0000 [thread overview]
Message-ID: <20111128145824.GB18958@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1322492005-27741-7-git-send-email-t-kristo@ti.com>
On Mon, Nov 28, 2011 at 04:53:24PM +0200, Tero Kristo wrote:
> +++ b/drivers/regulator/twl-regulator.c
> @@ -18,6 +18,7 @@
> #include <linux/regulator/machine.h>
> #include <linux/i2c/twl.h>
>
> +#include <plat/voltage.h>
You shouldn't be including platform specific headers in generic code.
> + /* voltagedomain, only used for VP controlled smps regulators */
> + union {
> + const char *name;
> + struct voltagedomain *ptr;
> + } voltdm;
> +
This looks pretty icky... Why are you using a union of a pointer to a
struct and a name? How do things know which to use?
> - twlreg_write(info, TWL_MODULE_PM_RECEIVER, VREG_VOLTAGE_SMPS_4030,
> - vsel);
> + if (info->voltdm.ptr)
> + voltdm_scale(info->voltdm.ptr, min_uV);
> + else {
Use braces on both branches.
next prev parent reply other threads:[~2011-11-28 14:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 14:53 [PATCHv7 0/7] External controller support for TWLxxxx Tero Kristo
2011-11-28 14:53 ` [PATCHv7 1/7] regulator: twl: fix twl4030 support for smps regulators Tero Kristo
2011-11-28 18:58 ` Mark Brown
2011-11-28 14:53 ` [PATCHv7 2/7] TEMP: OMAP3: beagle rev-c4: enable OPP6 Tero Kristo
2011-11-28 14:53 ` [PATCHv7 3/7] omap3: voltage: fix channel configuration Tero Kristo
2011-12-02 23:55 ` Kevin Hilman
2011-12-05 9:35 ` Tero Kristo
2011-12-05 20:23 ` Kevin Hilman
2011-12-07 8:57 ` Tero Kristo
2011-12-10 1:05 ` Kevin Hilman
2011-11-28 14:53 ` [PATCHv7 4/7] omap3: add common twl configurations for vdd1 and vdd2 Tero Kristo
2011-12-02 23:56 ` Kevin Hilman
2011-11-28 14:53 ` [PATCHv7 5/7] mfd: twl-core: pass driver data from pdata to add_regulator for VDD1 and VDD2 Tero Kristo
2011-12-12 18:04 ` Samuel Ortiz
2011-12-13 7:19 ` Tero Kristo
2011-11-28 14:53 ` [PATCHv7 6/7] regulator: twl: add support for external controller Tero Kristo
2011-11-28 14:58 ` Mark Brown [this message]
2011-11-28 15:43 ` Tero Kristo
2011-11-28 15:56 ` Mark Brown
2011-11-28 14:53 ` [PATCHv7 7/7] omap3: twl-common: enable VP SMPS mode for VDD1 and VDD2 Tero Kristo
[not found] <47CEF8C4B26E8C44B22B028A650E0EA9046299@DBDE01.ent.ti.com>
2011-11-29 7:10 ` [PATCHv7 6/7] regulator: twl: add support for external controller Bedia, Vaibhav
2011-11-29 11:19 ` Tero Kristo
2011-11-29 13:48 ` Bedia, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128145824.GB18958@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=b-cousson@ti.com \
--cc=gg@slimlogic.co.uk \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=rnayak@ti.com \
--cc=sameo@linux.intel.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox