From: "Mark A. Greer" <mgreer@animalcreek.com>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: "Kim, Milo" <Milo.Kim@ti.com>,
"tony@atomide.com" <tony@atomide.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] ARM: OMAP AM35x: clockdomain data: fix resolving dependency problem
Date: Mon, 9 Jul 2012 09:16:23 -0700 [thread overview]
Message-ID: <20120709161623.GA17180@animalcreek.com> (raw)
In-Reply-To: <20120707124131.GA9034@localhost.localdomain>
On Sat, Jul 07, 2012 at 02:41:31PM +0200, Ladislav Michl wrote:
> On Mon, Jul 02, 2012 at 10:41:38AM -0700, Mark A. Greer wrote:
> > On Mon, Jul 02, 2012 at 05:54:57AM +0000, Kim, Milo wrote:
> > > In am35x board , iva2 clock domain doesn't be used.
> > > So mpu_am35x_clkdm should be used rather than mpu_3xxx_clkdm.
> > > OMAP3430 : mpu_3xxx_clkdm (with iva2 clkdm)
> > > AM35x : mpu_am35x_clkdm (without iva2 clkdm)
> > > diff --git a/arch/arm/mach-omap2/clockdomains3xxx_data.c b/arch/arm/mach-omap2/clockdomains3xxx_data.c
> > > index d625844..56089c4 100644
> > > --- a/arch/arm/mach-omap2/clockdomains3xxx_data.c
> > > +++ b/arch/arm/mach-omap2/clockdomains3xxx_data.c
> > > @@ -454,7 +454,6 @@ static struct clkdm_autodep clkdm_am35x_autodeps[] = {
> > >
> > > static struct clockdomain *clockdomains_common[] __initdata = {
> > > &wkup_common_clkdm,
> > > - &mpu_3xxx_clkdm,
> > > &neon_clkdm,
> > > &core_l3_3xxx_clkdm,
> > > &core_l4_3xxx_clkdm,
> > > --
> > > 1.7.2.5
> >
> > Hi Milo.
> >
> > Thanks for the patch but this issue should already be fixed in a patch
> > that Tony just made a pull request for
> > (http://www.spinics.net/lists/linux-omap/msg73080.html).
> >
> > >From that email (and branch in the email), look for this patch:
> >
> > > Mark A. Greer (4):
> >
> > > ARM: OMAP AM35x: clockdomain data: Fix clockdomain dependencies
> >
> > Please take a look as another set of eyes never hurts. :)
>
> Hi Mark,
>
> just tested above patch on Technexion's TAM-3517 and it indeed fixes above
> warning. Without patch, warning is generated. Tested on Tony's master branch.
Great, thanks for the follow up, Ladis.
Mark
prev parent reply other threads:[~2012-07-09 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 5:54 [PATCH] ARM: OMAP AM35x: clockdomain data: fix resolving dependency problem Kim, Milo
2012-07-02 17:41 ` Mark A. Greer
2012-07-07 12:41 ` Ladislav Michl
2012-07-09 16:16 ` Mark A. Greer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120709161623.GA17180@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=Milo.Kim@ti.com \
--cc=ladis@linux-mips.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox